EXPERIMENT: Use the force-inline pass for more stuff

[scottmcm]

We're already paying for the extra look at stuff, what if we add a second attribute for things that we always want to inline, but are also fine with generic calls not getting inlined? Can we save a bunch of code and functions calls in derived Ords and such? Is it worth the extra overhead of normalizing more calls?

r? ghost

[scottmcm]

@bors try @rust-timer queue

[rust-bors]

⌛ Trying commit e9fcbb2 with merge 5a3178f…

To cancel the try build, run the command @bors try cancel.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 5a3178f (5a3178fa03ad01debfab17b1253662bc45c95eb9, parent: f32b23204a0efe2fe8383ed4be1a30b56c1bbf94)

[rust-timer]

Finished benchmarking commit (5a3178f): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.1%, 3.2%]	93
Regressions ❌ (secondary)	1.0%	[0.1%, 5.2%]	73
Improvements ✅ (primary)	-0.8%	[-2.6%, -0.1%]	5
Improvements ✅ (secondary)	-0.1%	[-0.2%, -0.1%]	2
All ❌✅ (primary)	0.8%	[-2.6%, 3.2%]	98

Max RSS (memory usage)

Results (primary 1.8%, secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[0.6%, 6.2%]	23
Regressions ❌ (secondary)	3.8%	[1.1%, 6.5%]	2
Improvements ✅ (primary)	-3.6%	[-6.3%, -0.9%]	2
Improvements ✅ (secondary)	-1.5%	[-2.2%, -0.7%]	4
All ❌✅ (primary)	1.8%	[-6.3%, 6.2%]	25

Cycles

Results (primary 2.3%, secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.2%, 3.7%]	12
Regressions ❌ (secondary)	2.8%	[1.5%, 4.4%]	12
Improvements ✅ (primary)	-1.9%	[-1.9%, -1.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.3%	[-1.9%, 3.7%]	13

Binary size

Results (primary 1.3%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.4%	[0.0%, 8.5%]	96
Regressions ❌ (secondary)	1.0%	[0.1%, 2.4%]	21
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.0%]	4
Improvements ✅ (secondary)	-0.1%	[-0.3%, -0.0%]	4
All ❌✅ (primary)	1.3%	[-0.2%, 8.5%]	100

Bootstrap: 467.999s -> 468.02s (0.00%)
Artifact size: 376.62 MiB -> 376.79 MiB (0.05%)

[bors]

☔ The latest upstream changes (presumably #144502) made this pull request unmergeable. Please resolve the merge conflicts.

[scottmcm]

Hmm, yeah, way too many new resolve calls to work. Ah well, interesting to know.

[scottmcm]

I was inspired by https://discord.com/channels/273534239310479360/957720175619215380/1401622766536364124 to see if I can do a more limited version of this that would still work.

[scottmcm]

@bors try @rust-timer queue

[rust-bors]

⌛ Trying commit a6adf2d with merge f4b36c8…

To cancel the try build, run the command @bors try cancel.

[rust-log-analyzer]

The job aarch64-gnu-llvm-19-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [ui] tests/ui-fulldeps/rustc_public/crate-info.rs stdout ----

error: test did not exit with success! code=Some(101) so test would pass with `run-fail`
status: exit status: 101
command: cd "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui-fulldeps/rustc_public/crate-info" && RUSTC="/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" RUST_TEST_THREADS="4" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui-fulldeps/rustc_public/crate-info/a"
stdout: none
--- stderr -------------------------------

[rust-bors]

☀️ Try build successful (CI)
Build commit: f4b36c8 (f4b36c8b56f988af2e104136c467ff4a28a21216, parent: 383b9c447b61641e1f1a3850253944a897a60827)

[rust-timer]

Finished benchmarking commit (f4b36c8): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.1%, 1.0%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.7%, secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.9%, 2.4%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-5.4%	[-7.4%, -3.4%]	2
Improvements ✅ (secondary)	-2.1%	[-3.1%, -0.8%]	4
All ❌✅ (primary)	-0.7%	[-7.4%, 2.4%]	6

Cycles

Results (secondary -4.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.7%	[-4.7%, -4.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	12
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	7
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-0.1%, 0.1%]	19

Bootstrap: 468.859s -> 468.747s (-0.02%)
Artifact size: 376.98 MiB -> 377.03 MiB (0.01%)