Perform check_private_in_public by module. #144479

cjgillot · 2025-07-26T01:04:39Z

Based on #116316

cjgillot · 2025-07-26T01:04:51Z

@bors try @rust-timer queue

rust-bors · 2025-07-26T01:04:55Z

⌛ Trying commit 01f0caf with merge 081f8e2…

To cancel the try build, run the command @bors try cancel.

Perform check_private_in_public by module.

rust-bors · 2025-07-26T03:18:43Z

☀️ Try build successful (CI)
Build commit: 081f8e2 (081f8e2fef216b3e6e1e291c960f0ff59cac84f2, parent: 430d6eddfc6a455ca4a0137c0822a982cccd3b2b)

rust-timer · 2025-07-26T10:41:22Z

Finished benchmarking commit (081f8e2): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.1%, 2.5%]	23
Regressions ❌ (secondary)	0.5%	[0.2%, 0.9%]	15
Improvements ✅ (primary)	-0.6%	[-2.8%, -0.1%]	65
Improvements ✅ (secondary)	-0.5%	[-1.3%, -0.2%]	21
All ❌✅ (primary)	-0.2%	[-2.8%, 2.5%]	88

Max RSS (memory usage)

Results (primary 0.1%, secondary -3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.2%	[1.5%, 3.0%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.9%	[-2.3%, -1.6%]	2
Improvements ✅ (secondary)	-3.0%	[-3.9%, -2.2%]	3
All ❌✅ (primary)	0.1%	[-2.3%, 3.0%]	4

Cycles

Results (primary -3.1%, secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.1%	[-3.2%, -3.0%]	2
Improvements ✅ (secondary)	-2.6%	[-2.7%, -2.5%]	2
All ❌✅ (primary)	-3.1%	[-3.2%, -3.0%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.925s -> 466.922s (-0.43%)
Artifact size: 374.68 MiB -> 374.62 MiB (-0.02%)

cjgillot · 2025-07-29T01:25:24Z

With parallelization:
@bors try @rust-timer queue

Perform check_private_in_public by module.

rust-bors · 2025-07-29T01:25:29Z

⌛ Trying commit 1b01dec with merge c0dd63f…

To cancel the try build, run the command @bors try cancel.

rust-bors · 2025-07-29T03:40:46Z

☀️ Try build successful (CI)
Build commit: c0dd63f (c0dd63fba857bfc9d94834df8bb52200884638e8, parent: 498ae9fed2e7d90821d70a048f3770f91af08957)

rust-timer · 2025-07-29T04:50:34Z

Finished benchmarking commit (c0dd63f): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.3%, 1.2%]	12
Regressions ❌ (secondary)	0.5%	[0.3%, 0.8%]	12
Improvements ✅ (primary)	-0.6%	[-2.6%, -0.2%]	60
Improvements ✅ (secondary)	-0.6%	[-1.3%, -0.2%]	18
All ❌✅ (primary)	-0.4%	[-2.6%, 1.2%]	72

Max RSS (memory usage)

Results (primary -0.3%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[1.7%, 1.7%]	1
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-2.4%, 1.7%]	2

Cycles

Results (primary -2.7%, secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-3.5%, -2.0%]	4
Improvements ✅ (secondary)	-2.7%	[-3.2%, -2.1%]	3
All ❌✅ (primary)	-2.7%	[-3.5%, -2.0%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.807s -> 469.856s (0.22%)
Artifact size: 376.77 MiB -> 376.89 MiB (0.03%)

cjgillot · 2025-07-31T01:37:54Z

Now that the first commit is merged
@bors try @rust-timer queue

Perform check_private_in_public by module.

rust-bors · 2025-07-31T01:37:59Z

⌛ Trying commit 1b01dec with merge 6df1d7e…

To cancel the try build, run the command @bors try cancel.

rust-bors · 2025-07-31T03:53:20Z

☀️ Try build successful (CI)
Build commit: 6df1d7e (6df1d7e8336f9f80d1ca1bd4c0adccac33bed57d, parent: 606dcc0d2e54d260f67d8a91f8adaf797a4ed38a)

rust-timer · 2025-07-31T05:09:23Z

Finished benchmarking commit (6df1d7e): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.5%, 0.5%]	2
Improvements ✅ (primary)	-0.7%	[-1.1%, -0.2%]	27
Improvements ✅ (secondary)	-0.6%	[-0.6%, -0.5%]	3
All ❌✅ (primary)	-0.7%	[-1.1%, -0.2%]	27

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.1%	[4.1%, 4.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.729s -> 468.757s (0.01%)
Artifact size: 376.81 MiB -> 376.83 MiB (0.01%)

petrochenkov · 2025-07-31T12:05:04Z

@bors r+

bors · 2025-07-31T12:05:06Z

📌 Commit 1b01dec has been approved by petrochenkov

It is now in the queue for this repository.

bors · 2025-08-02T01:59:15Z

⌛ Testing commit 1b01dec with merge c23f07d...

bors · 2025-08-02T05:08:23Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing c23f07d to master...

github-actions · 2025-08-02T05:11:11Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 63f6845 (parent) -> c23f07d (this PR)

Test differences

Show 45 test diffs

45 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard c23f07d8c56c51b5e634bda55daca2b073306340 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 5115.5s -> 4167.4s (-18.5%)
x86_64-apple-1: 8161.5s -> 9579.5s (17.4%)
dist-aarch64-apple: 6451.2s -> 5605.8s (-13.1%)
aarch64-gnu-llvm-19-1: 3473.8s -> 3905.4s (12.4%)
x86_64-apple-2: 6088.8s -> 5441.6s (-10.6%)
dist-x86_64-solaris: 5141.7s -> 5562.9s (8.2%)
dist-x86_64-apple: 11298.9s -> 10378.6s (-8.1%)
aarch64-gnu-llvm-19-2: 2578.4s -> 2393.7s (-7.2%)
dist-x86_64-msvc-alt: 8842.6s -> 9323.8s (5.4%)
aarch64-msvc-1: 6551.9s -> 6905.9s (5.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-08-02T06:19:43Z

Finished benchmarking commit (c23f07d): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.0%, 0.5%]	3
Improvements ✅ (primary)	-0.7%	[-1.1%, -0.2%]	27
Improvements ✅ (secondary)	-0.5%	[-0.6%, -0.1%]	4
All ❌✅ (primary)	-0.7%	[-1.1%, -0.2%]	27

Max RSS (memory usage)

Results (primary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[1.5%, 2.0%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-6.7%	[-6.7%, -6.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-6.7%, 2.0%]	4

Cycles

Results (primary 2.2%, secondary 6.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	11.2%	[11.1%, 11.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	2.2%	[2.2%, 2.2%]	1

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 468.385s -> 468.795s (0.09%)
Artifact size: 376.83 MiB -> 376.84 MiB (0.00%)

Remove eval_always from check_private_in_public.

a2320b2

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 26, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jul 26, 2025

Auto merge of #144479 - cjgillot:incr-privacy-mod, r=<try>

081f8e2

Perform check_private_in_public by module.

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 26, 2025

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 26, 2025

Perform check_private_in_public by module.

a1f5a6d

cjgillot force-pushed the incr-privacy-mod branch from 01f0caf to a1f5a6d Compare July 26, 2025 22:01

cjgillot mentioned this pull request Jul 26, 2025

Remove eval_always from check_private_in_public. #116316

Merged

petrochenkov self-assigned this Jul 27, 2025

cjgillot added 2 commits July 27, 2025 22:15

Parallelize check_private_in_public.

c0fe285

Do not fetch spans if not required.

1b01dec

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jul 29, 2025

Auto merge of #144479 - cjgillot:incr-privacy-mod, r=<try>

c0dd63f

Perform check_private_in_public by module.

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 29, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 29, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jul 31, 2025

Auto merge of #144479 - cjgillot:incr-privacy-mod, r=<try>

6df1d7e

Perform check_private_in_public by module.

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 31, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 31, 2025

cjgillot marked this pull request as ready for review July 31, 2025 11:00

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 2, 2025

bors merged commit c23f07d into rust-lang:master Aug 2, 2025
12 checks passed

rustbot added this to the 1.90.0 milestone Aug 2, 2025

cjgillot deleted the incr-privacy-mod branch August 2, 2025 07:05

Perform check_private_in_public by module. #144479

Perform check_private_in_public by module. #144479

Conversation

cjgillot commented Jul 26, 2025

Uh oh!

cjgillot commented Jul 26, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jul 26, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jul 26, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jul 26, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

cjgillot commented Jul 29, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jul 29, 2025

Uh oh!

rust-bors bot commented Jul 29, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jul 29, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

cjgillot commented Jul 31, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jul 31, 2025

Uh oh!

rust-bors bot commented Jul 31, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jul 31, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

petrochenkov commented Jul 31, 2025

Uh oh!

bors commented Jul 31, 2025

Uh oh!

bors commented Aug 2, 2025

Uh oh!

bors commented Aug 2, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 2, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Aug 2, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

Uh oh!