Make libtest::ERROR_EXIT_CODE const public to not redefine it in rustdoc
#144297
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @notriddle rustbot has assigned @notriddle. Use |
rustbot
added
S-waiting-on-review
|
Might be better to assign someone from the libs team instead. r? @Amanieu |
jieyouxu
added
T-libs-api
This comment has been minimized.
This comment has been minimized.
fbstj
reviewed
Jul 22, 2025
library/test/src/lib.rs
Outdated
| @@ -90,7 +90,7 @@ use test_result::*; | |||
| use time::TestExecTime; | |||
|
|
|||
| // Process exit code to be used to indicate test failures. | |||
There was a problem hiding this comment.
Suggested change
| // Process exit code to be used to indicate test failures. | |
| /// Process exit code to be used to indicate test failures. |
GuillaumeGomez
force-pushed
the
ERROR_EXIT_CODE
branch
from
d9fe786 to
722e63a
Compare
This comment has been minimized.
This comment has been minimized.
|
Hum... I'll remove the change in librustdoc and make it as a follow-up since it seems it cannot be done in one PR. That's a bit sad. |
|
This is fine since the entire libtest API is unstable. @bors r+ |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #144692) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
ERROR_EXIT_CODE
branch
from
3329c43 to
bee5fbf
Compare
|
@bors r=Amanieu rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 31, 2025
Rollup of 4 pull requests Successful merges: - #136840 (Fix linker-plugin-lto only doing thin lto) - #144053 (Remove install Rust script from CI) - #144297 (Make `libtest::ERROR_EXIT_CODE` const public to not redefine it in rustdoc) - #144721 (`std_detect`: Linux 6.16 support for RISC-V) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 31, 2025
Rollup merge of #144297 - GuillaumeGomez:ERROR_EXIT_CODE, r=Amanieu Make `libtest::ERROR_EXIT_CODE` const public to not redefine it in rustdoc I think it's better to make this constant public so it can be used by crates using `libtest` as dependency. As a side-note, I will update #143900 to make use of this constant once this is current PR is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's better to make this constant public so it can be used by crates using
libtestas dependency.As a side-note, I will update #143900 to make use of this constant once this is current PR is merged.