Skip to content

Remove the ptr_unique lang item #144212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2025
Merged

Remove the ptr_unique lang item #144212

merged 2 commits into from
Jul 21, 2025
+0 −8

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jul 20, 2025

Miri no longer uses it since rust-lang/miri#4307.

@bjorn3
Remove the ptr_unique lang item
fdf8bdb 
Miri no longer uses it.
@rustbot
Copy link
Collaborator

rustbot commented Jul 20, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 20, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3
Copy link
Member Author

bjorn3 commented Jul 20, 2025

There is still a reference to it at

rust/compiler/rustc_mir_transform/src/add_retag.rs

Line 31 in 6707bf0

ty::Adt(adt, _) if tcx.is_lang_item(adt.did(), LangItem::PtrUnique) => true,
as it turns out. Can that safely be removed given the miri PR to remove -Zunique-is-unique?

@asquared31415
Copy link
Contributor

That final existing use seems sketchy given that nothing else assumes that Unique acts like a reference.

@rustbot
Copy link
Collaborator

rustbot commented Jul 21, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented Jul 21, 2025

r=me with CI green

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2025
@bjorn3 bjorn3 force-pushed the remove_unique_lang_item branch from 5344017 to 1fd0697 Compare July 21, 2025 08:08
@bjorn3
Copy link
Member Author

bjorn3 commented Jul 21, 2025

@bors r=oli-obk

@bors
Copy link
Collaborator

bors commented Jul 21, 2025

📌 Commit 1fd0697 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jul 21, 2025
@jieyouxu
Rollup merge of rust-lang#144212 - bjorn3:remove_unique_lang_item, r=…
c497403 
…oli-obk

Remove the ptr_unique lang item

Miri no longer uses it since rust-lang/miri#4307.
@jieyouxu jieyouxu mentioned this pull request Jul 21, 2025
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jul 21, 2025
@jieyouxu
Rollup merge of rust-lang#144212 - bjorn3:remove_unique_lang_item, r=…
7c70e3b 
…oli-obk

Remove the ptr_unique lang item

Miri no longer uses it since rust-lang/miri#4307.
@jieyouxu jieyouxu mentioned this pull request Jul 21, 2025
Closed
bors added a commit that referenced this pull request Jul 21, 2025
@bors
Auto merge of #144262 - jieyouxu:rollup-wxgtyr0, r=jieyouxu
006f365 
Rollup of 15 pull requests

Successful merges:

 - #142097 (gpu offload host code generation)
 - #143430 (Lower extra lifetimes before normal generic params.)
 - #143672 (Fix Box allocator drop elaboration)
 - #143768 (Constify Try, From, TryFrom and relevant traits)
 - #143816 (Implement `check` for compiletest and RA using tool macro)
 - #143985 (rustc_public: de-StableMIR-ize)
 - #144027 (clippy: make tests work in stage 1)
 - #144080 (Mitigate `#[align]` name resolution ambiguity regression with a rename)
 - #144176 (Add approval blocking labels for new bors)
 - #144187 (fix handling of base address for TypeId allocations)
 - #144212 (Remove the ptr_unique lang item)
 - #144243 (Subtree update of `rust-analyzer`)
 - #144246 (Don't use another main test file as auxiliary)
 - #144251 (rustc-dev-guide subtree update)
 - #144254 (opt-dist: make `artifact-dir` an absolute path for `opt-dist local`)

r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxu jieyouxu mentioned this pull request Jul 21, 2025
Merged
bors added a commit that referenced this pull request Jul 21, 2025
@bors
Auto merge of #144269 - jieyouxu:rollup-137ysl2, r=jieyouxu
9748d87 
Rollup of 14 pull requests

Successful merges:

 - #142097 (gpu offload host code generation)
 - #143430 (Lower extra lifetimes before normal generic params.)
 - #143768 (Constify Try, From, TryFrom and relevant traits)
 - #143816 (Implement `check` for compiletest and RA using tool macro)
 - #143985 (rustc_public: de-StableMIR-ize)
 - #144027 (clippy: make tests work in stage 1)
 - #144080 (Mitigate `#[align]` name resolution ambiguity regression with a rename)
 - #144176 (Add approval blocking labels for new bors)
 - #144187 (fix handling of base address for TypeId allocations)
 - #144212 (Remove the ptr_unique lang item)
 - #144243 (Subtree update of `rust-analyzer`)
 - #144246 (Don't use another main test file as auxiliary)
 - #144251 (rustc-dev-guide subtree update)
 - #144254 (opt-dist: make `artifact-dir` an absolute path for `opt-dist local`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 551cef9 into rust-lang:master Jul 21, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 21, 2025
rust-timer added a commit that referenced this pull request Jul 21, 2025
@rust-timer
Unrolled build for #144212
f283679 
Rollup merge of #144212 - bjorn3:remove_unique_lang_item, r=oli-obk

Remove the ptr_unique lang item

Miri no longer uses it since rust-lang/miri#4307.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 22, 2025
@bors
Auto merge of #144269 - jieyouxu:rollup-137ysl2, r=jieyouxu
44b1876 
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#142097 (gpu offload host code generation)
 - rust-lang/rust#143430 (Lower extra lifetimes before normal generic params.)
 - rust-lang/rust#143768 (Constify Try, From, TryFrom and relevant traits)
 - rust-lang/rust#143816 (Implement `check` for compiletest and RA using tool macro)
 - rust-lang/rust#143985 (rustc_public: de-StableMIR-ize)
 - rust-lang/rust#144027 (clippy: make tests work in stage 1)
 - rust-lang/rust#144080 (Mitigate `#[align]` name resolution ambiguity regression with a rename)
 - rust-lang/rust#144176 (Add approval blocking labels for new bors)
 - rust-lang/rust#144187 (fix handling of base address for TypeId allocations)
 - rust-lang/rust#144212 (Remove the ptr_unique lang item)
 - rust-lang/rust#144243 (Subtree update of `rust-analyzer`)
 - rust-lang/rust#144246 (Don't use another main test file as auxiliary)
 - rust-lang/rust#144251 (rustc-dev-guide subtree update)
 - rust-lang/rust#144254 (opt-dist: make `artifact-dir` an absolute path for `opt-dist local`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bjorn3 bjorn3 deleted the remove_unique_lang_item branch July 22, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@bjorn3 @rustbot @rust-log-analyzer @asquared31415 @oli-obk @bors