-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Rehome 35 tests/ui/issues/
tests to other subdirectories under tests/ui/
#144089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There are changes to the cc @jieyouxu |
74fe4ca
to
a62b29d
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #144145) made this pull request unmergeable. Please resolve the merge conflicts. |
a62b29d
to
2cfcf5d
Compare
This comment has been minimized.
This comment has been minimized.
2cfcf5d
to
f63de22
Compare
I'm going to review the PR removing the issue limits check first, as otherwise this and Kivo's other PR moving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. A few nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: isn't this more privacy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: blocked on #144173
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this change should not be needed after #144173.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: this is more of layout or codegen, as it has to do with computing type size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit (general): when you rename tests, can you drop the issue
in e.g. desc-issue-NNNNN.rs
? IMO it makes the test name longer and its useless noise.
#143902 divided into smaller, easier to review chunks.
Part of #133895
Methodology:
tests/ui/SUMMARY.md
The URL addition at the end, as well as moving around the auxiliary files and editing the
stderr
files with the new filename, were done using a Python script.Inspired by the methodology that @Kivooeo was using.
r? @jieyouxu