tests: cover more exported_private_dependencies cases
#144082
+223
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
S-waiting-on-review
epage
reviewed
Jul 18, 2025
mladedav
force-pushed
the
dm/pub-priv-tests
branch
from
f8cf216 to
2390abe
Compare
|
This would conflict with #144098 which will most likely break the tests of RPITIT again. So I'll convert this to a draft so that this doesn't add work there if it's merged first and once that is merged, I'll update this. It might also mean that the parent issue will still have to be kept open even after mergint this since the current fix in the linked PR breaks linting about using traits from private dependencies again. |
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
mladedav
force-pushed
the
dm/pub-priv-tests
branch
from
2390abe to
725523e
Compare
rustbot
added
S-waiting-on-review
|
After #144098, RPITIT is not linted again so that's the last thing that is missing (again). There's a link to a crater run in that PR so if that goes well, that too will be properly linted. Regardless, this can be merged now and #71043 would just have to wait for the resolution of the crater run and the changes behind that. |
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 22, 2025
…ochenkov tests: cover more `exported_private_dependencies` cases This PR adds tests for all missing cases from rust-lang#71043 and some on top of that. I believe with this, that issue can be closed. Some of the lints can be improved, e.g. `provided_impl_trait` and `impl From<PublicWithStdImpl> for OtherType` lint twice. cc `@epage` in case you want to double check I didn't miss anything.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 22, 2025
…ochenkov tests: cover more `exported_private_dependencies` cases This PR adds tests for all missing cases from rust-lang#71043 and some on top of that. I believe with this, that issue can be closed. Some of the lints can be improved, e.g. `provided_impl_trait` and `impl From<PublicWithStdImpl> for OtherType` lint twice. cc ``@epage`` in case you want to double check I didn't miss anything.
bors
added a commit
that referenced
this pull request
Jul 22, 2025
Rollup of 8 pull requests Successful merges: - #142454 (Add modern AVR mcus like avr128db28 and attiny3224) - #142924 (tidy: move rustdoc js stuff into a tidy extra check) - #143373 (Unquerify maybe_unused_trait_imports.) - #143906 (Miri: non-deterministic floating point operations in `foreign_items`) - #144082 (tests: cover more `exported_private_dependencies` cases) - #144126 (Fix empty target_config in apply_rust_config bootstrap) - #144164 ( opt-dist: add an option for setting path to stage0 root) - #144265 (Dont ICE on copy error being suppressed due to overflow) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 22, 2025
…ochenkov tests: cover more `exported_private_dependencies` cases This PR adds tests for all missing cases from rust-lang#71043 and some on top of that. I believe with this, that issue can be closed. Some of the lints can be improved, e.g. `provided_impl_trait` and `impl From<PublicWithStdImpl> for OtherType` lint twice. cc ```@epage``` in case you want to double check I didn't miss anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for all missing cases from #71043 and some on top of that. I believe with this, that issue can be closed.
Some of the lints can be improved, e.g.
provided_impl_traitandimpl From<PublicWithStdImpl> for OtherTypelint twice.cc @epage in case you want to double check I didn't miss anything.