Guarantee 8 bytes of alignment in Thread::into_raw #143859
Open
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
r? libs-api, this adds an alignment guarantee to the unstable |
rustbot
added
the
T-libs-api
This comment has been minimized.
This comment has been minimized.
|
ping @rust-lang/libs-api, as this provides a new guarantee, arguably needing FCP (and at a minimum team involvement) |
jhpratt
added
S-waiting-on-team
ChrisDenton
removed
the
T-libs
Mark-Simulacrum
added
the
needs-fcp
|
@rfcbot fcp merge |
|
Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
AtomicPtrfor synchronization it's incredibly useful when you've got a couple bits you can stuff metadata in. By guaranteeing thatThread'sInnerstruct is aligned to 8 bytes everyone can use the bottom 3 bits to signal other things, such as a critical section, etc.This guarantee is thus very useful and costs us nothing.