Skip to content

ci cleanup: rustdoc-gui-test now installs browser-ui-test #143851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci cleanup: rustdoc-gui-test now installs browser-ui-test #143851

wants to merge 1 commit into from
+44 −100

Conversation

lolbinarycat
Copy link
Contributor

this removes the need for --unsafe-perm in the Dockerfile.

cc @GuillaumeGomez @Kobzol

@rustbot
Copy link
Collaborator

rustbot commented Jul 12, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 12, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat force-pushed the bootstrap-node_modules branch from c070840 to 5bc18df Compare July 12, 2025 18:50
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat force-pushed the bootstrap-node_modules branch from 5bc18df to 4254f64 Compare July 12, 2025 20:10
Kobzol
Kobzol reviewed Jul 12, 2025
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think it's much nicer to make sure that we have a known and exact environment, than trying to guess and compare what comes from the outside world.

@Kobzol
Copy link
Member

Kobzol commented Jul 12, 2025

r? @Kobzol

@rustbot rustbot assigned Kobzol and unassigned Mark-Simulacrum Jul 12, 2025
@lolbinarycat lolbinarycat force-pushed the bootstrap-node_modules branch 2 times, most recently from 8a1869c to 4028b6d Compare July 12, 2025 21:04
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat force-pushed the bootstrap-node_modules branch from 4028b6d to 2f62ee4 Compare July 12, 2025 21:19
@rust-log-analyzer

This comment has been minimized.

Sign in to view
GuillaumeGomez
GuillaumeGomez reviewed Jul 14, 2025
View reviewed changes
src/tools/rustdoc-gui-test/src/main.rs Outdated
Err(e) => eprintln!("Couldn't find the CI browser-ui-test version: {:?}", e),
}
fn get_desired_browser_ui_test_version(src: &Path) -> Result<String, io::Error> {
Ok("0.21.1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have a package.json already? If not, please add a FIXME comment to update/remove this function once we make use of package.json.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, that's being added in a future PR that I want to make this CI change before.

once we have a package.json we could update this function to use npm update, no? would that install a specific package according to the version in the package.json ..?

I suppose probably we'll just use npm install, though.

lolbinarycat
lolbinarycat commented Jul 14, 2025
View reviewed changes
@lolbinarycat lolbinarycat force-pushed the bootstrap-node_modules branch from 2f62ee4 to 4d4da0e Compare July 15, 2025 18:04
@Kobzol
Copy link
Member

Kobzol commented Jul 15, 2025

Looks good! You can r=me once CI is green.

@bors delegate+

@bors
Copy link
Collaborator

bors commented Jul 15, 2025

✌️ @lolbinarycat, you can now approve this pull request!

If @Kobzol told you to "r=me" after making some further change, please make that change, then do @bors r=@Kobzol

@lolbinarycat lolbinarycat force-pushed the bootstrap-node_modules branch from 4d4da0e to 4deb8eb Compare July 15, 2025 19:08
@lolbinarycat
ci cleanup: rustdoc-gui-test now installs browser-ui-test
bbb114e 
this removes the need for --unsafe-perm in the Dockerfile.
@lolbinarycat lolbinarycat force-pushed the bootstrap-node_modules branch from 4deb8eb to bbb114e Compare July 15, 2025 19:39
@lolbinarycat
Copy link
Contributor Author

@bors r=@Kobzol

@bors
Copy link
Collaborator

bors commented Jul 15, 2025

📌 Commit bbb114e has been approved by Kobzol

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 15, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

@Kobzol Kobzol Kobzol left review comments

Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lolbinarycat @rustbot @rust-log-analyzer @Kobzol @bors @GuillaumeGomez @Mark-Simulacrum