-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Unify CoroutineWitness
sooner in typeck, and stall coroutine obligations based off of TypingEnv
#141762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
[experimental] Make witnesses more eager r? lcnr
@@ -1508,7 +1508,8 @@ impl<'cx, 'tcx> SelectionContext<'cx, 'tcx> { | |||
defining_opaque_types_and_generators: defining_opaque_types, | |||
} | |||
| TypingMode::Borrowck { defining_opaque_types } => { | |||
defining_opaque_types.is_empty() || !pred.has_opaque_types() | |||
defining_opaque_types.is_empty() | |||
|| (!pred.has_opaque_types() && !pred.has_coroutines()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i feel like we prolly want to instead never erase the coroutines, only the defining opaques when creating a TypingEnv
from the current infcx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be expensive to erase on every call to TypingEnv
; otherwise i'll keep this and write a comment explaining why it's unsound.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, we don't need to check for has_coroutines
with TypingMode::Borrowck
. But yeah, please add a comment here
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (aa7f5f1): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.4%, secondary -1.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: missing data |
7bff9fb
to
5862717
Compare
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
[experimental] Make witnesses more eager r? lcnr
This comment has been minimized.
This comment has been minimized.
💔 Test failed
|
5862717
to
ec8dc45
Compare
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
[experimental] Make witnesses more eager r? lcnr
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (c5243c3): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 1.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 754.885s -> 753.548s (-0.18%) |
Crater regressions are spurious. I think this is ready to review more. I'll open a tracking issue for "removing |
5f09e4f
to
4560692
Compare
CoroutineWitness
sooner in typeck, and stall coroutine obligations based off of TypingEnv
r=me with the nits btw |
☔ The latest upstream changes (presumably #142223) made this pull request unmergeable. Please resolve the merge conflicts. |
@rustbot author |
4560692
to
216cdb7
Compare
@bors r=lcnr rollup=never |
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 9cd918b (parent) -> e466296 (this PR) Test differencesShow 9 test diffs9 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e4662966273ed58b51f9ff8d682accc202aa1210 --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (e466296): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.7%, secondary -3.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 464.098s -> 464.163s (0.01%) |
Unify `CoroutineWitness` sooner in typeck, and stall coroutine obligations based off of `TypingEnv` * Stall coroutine obligations based off of `TypingMode` in the old solver. * Eagerly assign `TyKind::CoroutineWitness` to the witness arg of coroutines during typeck, rather than deferring them to the end of typeck. r? lcnr This is part of rust-lang#143017.
TypingMode
in the old solver.TyKind::CoroutineWitness
to the witness arg of coroutines during typeck, rather than deferring them to the end of typeck.r? lcnr
This is part of #143017.