-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ports the compiler test cases to new rust_intrinsic format #138364
base: master
Are you sure you want to change the base?
Conversation
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
@RalfJung I ran test rustc_error_codes and the test passed on my local machine. |
First of all, please pick a PR title |
} | ||
#[rustc_intrinsic] | ||
unsafe fn foo(); // error: unrecognized intrinsic function: `foo` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason why you added a new empty line here (and in all the other tests)?
The job Click to see the possible cause of the failure (guessed by this bot)
|
Should we bless the test? |
You'll need to provide a definition for the static, as the error says. |
fn simd_add<T>(a: T, b: T) -> T; | ||
} | ||
#[rustc_intrinsic] | ||
unsafe fn simd_add<T>(_a: T, _b: T) -> T; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the leading _
again (everywhere in this PR)
pr is part of #132735