Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable reliable_f16_math on x86 #138344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable reliable_f16_math on x86 #138344

wants to merge 1 commit into from
+0 −2

Conversation

tgross35
Copy link
Contributor

This has been disabled due to an LLVM misoptimization with powi.f16 1. This was fixed upstream and the fix is included in LLVM20, so tests no longer need to be disabled.

f16 still remains disabled on MinGW due to the ABI issue.

try-job: x86_64-gnu
try-job: i686-gnu-1

@tgross35
Enable reliable_f16_math on x86
2b97977 
This has been disabled due to an LLVM misoptimization with `powi.f16`
[1]. This was fixed upstream and the fix is included in LLVM20, so tests
no longer need to be disabled.

`f16` still remains disabled on MinGW due to the ABI issue.

[1]: llvm/llvm-project#98665
@tgross35
Copy link
Contributor Author

@bors try

@rustbot
Copy link
Collaborator

rustbot commented Mar 11, 2025

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 11, 2025
@bors
Copy link
Contributor

bors commented Mar 11, 2025

⌛ Trying commit 2b97977 with merge 356f837...

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2025
@bors
Auto merge of rust-lang#138344 - tgross35:x86-f16-math, r=<try>
356f837 
Enable `reliable_f16_math` on x86

This has been disabled due to an LLVM misoptimization with `powi.f16` [1]. This was fixed upstream and the fix is included in LLVM20, so tests no longer need to be disabled.

`f16` still remains disabled on MinGW due to the ABI issue.

[1]: llvm/llvm-project#98665

try-job: x86_64-gnu
try-job: i686-gnu-1
@bors
Copy link
Contributor

bors commented Mar 11, 2025

☀️ Try build successful - checks-actions
Build commit: 356f837 (356f83705e3964cdbb5ac3eb707ede90063883e8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tgross35 @rustbot @bors @Amanieu