Rollup of 8 pull requests #138310
Merged
Rollup of 8 pull requests #138310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds dangling impl diagnostics - Rename validation test from dangling_impl to dangling_iml_ref
Warn when the used toolchain looks too old for rust-analyzer
Allow unsetting default cfgs
Support tuple struct patterns for expand_rest_pattern assist
Bump minimum supported toolchain to 1.82
…gling-dyn-diagnostic feat: Add diagnostic for dangling dyn and impl
Twiddle with the `rustup` invocation on CI
Use `std::mem::{size_of, size_of_val, align_of, align_of_val}` from the
prelude instead of importing or qualifying them.
These functions were added to all preludes in Rust 1.80.
Use `size_of` from the prelude instead of imported
The errors are silently dropped elsewhere, which make it really hard to debug issues due to dependency download failures.
Highlight unsafe operations as unsafe, not definitions
Improve keyword completion for 'let' and 'let mut'
Fix syntax highlightingg punct filtering ignoring mods
rustbot
added
A-attributes
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
📌 Perf builds for each rolled up PR:
previous master: 2b285cd5f0 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Mar 10, 2025
|
Finished benchmarking commit (9fb94b3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 779.823s -> 779.019s (-0.10%) |
Kobzol
added a commit
to Kobzol/rust
that referenced
this pull request
Mar 11, 2025
Fix post-merge workflow The command is called `post-merge-report` not `post-merge-analysis`. See https://github.com/rust-lang/rust/blob/90384941aae4ea38de00e4702b50757e9b882a19/src/ci/citool/src/main.rs#L379 Noticed it failing in rust-lang#138310 (comment). r? `@Kobzol` (or `@marcoieni)`
Kobzol
added a commit
to Kobzol/rust
that referenced
this pull request
Mar 11, 2025
Fix post-merge workflow The command is called `post-merge-report` not `post-merge-analysis`. See https://github.com/rust-lang/rust/blob/90384941aae4ea38de00e4702b50757e9b882a19/src/ci/citool/src/main.rs#L379 Noticed it failing in rust-lang#138310 (comment). r? ``@Kobzol`` (or ``@marcoieni)``
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 11, 2025
Rollup merge of rust-lang#138335 - jieyouxu:fix-citool, r=marcoieni Fix post-merge workflow The command is called `post-merge-report` not `post-merge-analysis`. See https://github.com/rust-lang/rust/blob/90384941aae4ea38de00e4702b50757e9b882a19/src/ci/citool/src/main.rs#L379 Noticed it failing in rust-lang#138310 (comment). r? ``@Kobzol`` (or ``@marcoieni)``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
llvm-toolscomponent re.rustc_privatelinker failures related to not finding LLVM libraries #137931 (Add remark for missingllvm-toolscomponent re.rustc_privatelinker failures related to not finding LLVM libraries)InferCtxttoInlineAsmCtxtto properly taint on error #138138 (PassInferCtxttoInlineAsmCtxtto properly taint on error)MethodCallgeneration #138278 (Delegation: fix ICE with invalidMethodCallgeneration)rust-analyzer#138305 (Subtree update ofrust-analyzer)compiler/#138084" #138306 (Revert "Use workspace lints for crates incompiler/Use workspace lints for crates incompiler/#138084")r? @ghost
@rustbot modify labels: rollup
Create a similar rollup