Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load NtOpenFile for UWP #138276

Merged
merged 1 commit into from
Mar 9, 2025
Merged

Conversation

bdbai
Copy link
Contributor

@bdbai bdbai commented Mar 9, 2025

Lazily load NtOpenFile to allow libraries targeting UWP to build and link.

Fixes #138257 .

r? @ChrisDenton

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 9, 2025
@ChrisDenton
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 9, 2025

📌 Commit 33c6c3a has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#122790 (Apply dllimport in ThinLTO)
 - rust-lang#137650 (Move `fs` into `sys`)
 - rust-lang#138228 (Use `disjoint_bitor` inside `borrowing_sub`)
 - rust-lang#138233 (Windows: Don't link std (and run-make) against advapi32, except on win7)
 - rust-lang#138253 (Continue to check attr if meet empty repr for adt)
 - rust-lang#138263 (Fix `repr128-dwarf` test)
 - rust-lang#138276 (Lazy load NtOpenFile for UWP)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 33530e4 into rust-lang:master Mar 9, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2025
Rollup merge of rust-lang#138276 - bdbai:fix-uwp-ntopenfile, r=ChrisDenton

Lazy load NtOpenFile for UWP

Lazily load `NtOpenFile` to allow libraries targeting UWP to build and link.

Fixes rust-lang#138257 .

r? `@ChrisDenton`
@rustbot rustbot added this to the 1.87.0 milestone Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UWP target (e.g. x86_64-uwp-windows-msvc) is broken
4 participants