Prevent ICE in autodiff validation by emitting user-friendly errors #138231
+102
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
ZuseZ4
reviewed
Mar 10, 2025
| builtin_macros_autodiff_ty_activity = {$act} can not be used for this type | ||
|
|
||
|
|
There was a problem hiding this comment.
I'm not sure why I had builtin_macros_autodiff_unknown_activity not grouped together with the rest, but maybe combine them?
There was a problem hiding this comment.
I've just grouped them so all autodiff-related errors are together.
|
@rustbot label +F-autodiff |
|
Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs Some changes occurred in compiler/rustc_codegen_ssa |
oli-obk
reviewed
Mar 10, 2025
|
@bors delegate=ZuseZ4 |
|
Contrary to what the bot said, feel free to |
|
@Sa4dUs It's not strictly necessary, but if you have some time, could you please remove the Remove test_ad commit and just update the previous commit to not include the binary blob? When possible it's preferable to have a cleaner history and let every commit build on it's own, since bors will just apply all of your commits unchanged (and not squash them). |
|
Done! Sorry for the oversight. |
|
Thanks! @bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 11, 2025
Prevent ICE in autodiff validation by emitting user-friendly errors This PR moves `valid_ret_activity` and `valid_input_activity` checks to the macro expansion phase in compiler/rustc_builtin_macros/src/autodiff.rs, replacing the following internal compiler error (ICE): ``` error: internal compiler error: compiler/rustc_codegen_ssa/src/codegen_attrs.rs:935:13: Invalid input activity Dual for Reverse mode ``` with a more user-friendly message. The issue specifically affected the test file `tests/ui/autodiff/autodiff_illegal.rs`, impacting the functions `f5` and `f6`. The ICE can be reproduced by following [Enzyme's Rustbook](https://enzymead.github.io/rustbook/installation.html) installation guide. Additionally, this PR adds tests for invalid return activity in `autodiff_illegal.rs`, which previously triggered an unnoticed ICE before these fixes. r? `@oli-obk`
This was referenced Mar 11, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 11, 2025
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#137715 (Allow int literals for pattern types with int base types) - rust-lang#138002 (Disable CFI for weakly linked syscalls) - rust-lang#138051 (Add support for downloading GCC from CI) - rust-lang#138231 (Prevent ICE in autodiff validation by emitting user-friendly errors) - rust-lang#138245 (stabilize `ci_rustc_if_unchanged_logic` test for local environments) - rust-lang#138256 (Do not feed anon const a type that references generics that it does not have) - rust-lang#138284 (Do not write user type annotation for const param value path) - rust-lang#138296 (Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT) - rust-lang#138352 (miri native_calls: ensure we actually expose *mutable* provenance to the memory FFI can access) - rust-lang#138354 (remove redundant `body` arguments) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
valid_ret_activityandvalid_input_activitychecks to the macro expansion phase in compiler/rustc_builtin_macros/src/autodiff.rs, replacing the following internal compiler error (ICE):with a more user-friendly message.
The issue specifically affected the test file
tests/ui/autodiff/autodiff_illegal.rs, impacting the functionsf5andf6.The ICE can be reproduced by following Enzyme's Rustbook installation guide.
Additionally, this PR adds tests for invalid return activity in
autodiff_illegal.rs, which previously triggered an unnoticed ICE before these fixes.r? @oli-obk