Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip compile::Std and compile::Rustc on forced_compiler #138224

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Mar 8, 2025

Fixes #138220

Set download-rustc = true/false and run x test tests/ui/meta/no_std-extern-libc.rs --force-rerun to debug it.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot
Copy link
Collaborator

rustbot commented Mar 8, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 8, 2025
@onur-ozkan
Copy link
Member Author

Any pipeline using CI-rustc will fail unless this is landed. @bors p=1

@jieyouxu
Copy link
Member

jieyouxu commented Mar 8, 2025

I'll take a look in a few hours unless someone beats me to it.

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks!

@jieyouxu
Copy link
Member

jieyouxu commented Mar 8, 2025

r? jieyouxu @bors r+

@bors
Copy link
Contributor

bors commented Mar 8, 2025

📌 Commit 028aaa1 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Mar 8, 2025

Fix for CI-rustc so
@bors p=10

@bors
Copy link
Contributor

bors commented Mar 8, 2025

⌛ Testing commit 028aaa1 with merge 07292cc...

@bors
Copy link
Contributor

bors commented Mar 8, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 07292cc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 8, 2025
@bors bors merged commit 07292cc into rust-lang:master Mar 8, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 8, 2025
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

gh pr comment ${HEAD_PR} -F output.log
shell: /usr/bin/bash -e {0}
##[endgroup]
fatal: ambiguous argument 'HEAD^1': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
##[error]Process completed with exit code 128.

@onur-ozkan onur-ozkan deleted the fix-multiple-candidates branch March 8, 2025 19:29
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (07292cc): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 766.2s -> 765.562s (-0.08%)
Artifact size: 362.14 MiB -> 362.12 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/ui/meta/no_std-extern-libc.rs fails aarch64-apple
7 participants