library: Use `size_of` from the prelude instead of imported #138034

thaliaarchi · 2025-03-05T05:32:59Z

Use std::mem::{size_of, size_of_val, align_of, align_of_val} from the prelude instead of importing or qualifying them.

These functions were added to all preludes in Rust 1.80.

try-job: test-various
try-job: x86_64-gnu
try-job: x86_64-msvc-1

rustbot · 2025-03-05T05:33:05Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler/rustc_data_structures/src/aligned.rs

compiler-errors · 2025-03-05T05:40:23Z

Please revert all the changes to tests. We don't typically "correct" tests for things like this, formatting, etc. It's simply unnecessary churn. Especially unless you want to verify that every test that was changed doesn't implicitly change the meaning or intention of the test that when it was originally committed (e.g. that the test wasn't exercising minutiae of resolver or path semantics or something else).

You also probably should split this out between library, compiler, and changes to the various tools in src/tools. Different parts of the repository are the responsibility of different teams, and right now the review-ability of a 444 file test is really not great.

@rustbot author

rustbot · 2025-03-05T05:43:37Z

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Some changes occurred in coverage tests.

cc @Zalathar

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

The Miri subtree was changed

cc @rust-lang/miri

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

Portable SIMD is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead.

cc @calebzulawski, @programmerjake

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred in const_evaluatable.rs

cc @BoxyUwU

Some changes occurred in tests/ui/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

thaliaarchi · 2025-03-05T05:53:25Z

Please revert all the changes to tests.

I've removed changes to files in the following directories:

src/tools/clippy/tests/
src/tools/miri/tests/
src/tools/rustfmt/tests/
tests/

thaliaarchi · 2025-03-05T05:59:01Z

Roughly by team, the distribution is now:

library/: 124 files
compiler/: 31 files
src/tools/rust-analyzer/: 11 files
src/tools/clippy/: 4 files
src/bootstrap/: 2 files
src/tools/compiletest/: 1 file
src/tools/miri/: 1 file

Unless I'm splitting library/ somehow, compiler/ might not even be worth splitting out. It's just a lot of files. But, I'm open if you have ideas on how to split it well.

compiler-errors · 2025-03-05T06:06:59Z

By split, I mean there's no reason this needs to happen in a single PR, since it's not like this changes something that needs to be applied concurrently across all the repository in a singular PR. It's just a bunch of changes squashed into one by choice.

The 31 changes in compiler/ can get reviewed and approved by a compiler reviewer separately. Same with library/, which should have a dedicated reviewer, though that likely requires a bunch of CI back and forth with all the platform cfg's that aren't tested locally. What I mean is to split this into several PRs.

This PR also touches several tools that really should have PRs made to their own repositories, like rust-analyzer, rustfmt, etc (pls re-read the rustbot ping list for some of those submodules by name), since this is not a critical change or something that breaks rust-analyzer or rustfmt in CI or anything.

tgross35 · 2025-03-07T04:15:39Z

portable-simd should go through its subtree at https://github.com/rust-lang/portable-simd so as to avoid conflicts during sync. Everything else LGTM.

Might as well run a try to double check the changes to platform-specific files.

@bors try

bors · 2025-03-07T04:16:52Z

⌛ Trying commit b4a107d with merge 937b979...

…try> library: Use `size_of` from the prelude instead of imported Use `std::mem::{size_of, size_of_val, align_of, align_of_val}` from the prelude instead of importing or qualifying them. These functions were added to all preludes in Rust 1.80. try-job: test-various try-job: x86_64-gnu try-job: x86_64-msvc-1

Use `std::mem::{size_of, size_of_val, align_of, align_of_val}` from the prelude instead of importing or qualifying them. These functions were added to all preludes in Rust 1.80.

thaliaarchi · 2025-03-07T04:21:39Z

Would pushing the portable-simd removal cancel the bors try?

tgross35 · 2025-03-07T04:25:25Z

No idea, I thought it did but recently it seems like it leaves them running. It hasn't been very long in any case.

compiler-errors · 2025-03-07T04:26:04Z

pushing cancels a try

thaliaarchi · 2025-03-07T04:28:39Z

Well, it hasn't been long, so I pushed anyways.

tgross35 · 2025-03-07T04:34:58Z

pushing cancels a try

It seems to be going still. I had the same thing at #138087, two jobs with a push in between ran in parallel until they both failed.

tgross35

In any case, r=me after try completes

thaliaarchi · 2025-03-07T04:36:27Z

I don't see it in the queue, but I also don't mind waiting anyways

tgross35 · 2025-03-07T04:40:15Z

Yeah looks like bors doesn't show it in the UI after a push, but it is still running https://github.com/rust-lang-ci/rust/actions/runs/13713644338

thaliaarchi · 2025-03-07T07:10:27Z

@tgross35 The try run passed.

tgross35 · 2025-03-07T07:24:11Z

@bors r+

bors · 2025-03-07T07:24:13Z

📌 Commit 5dfa2f5 has been approved by tgross35

It is now in the queue for this repository.

jieyouxu · 2025-03-07T07:51:21Z

pushing cancels a try

(it does not, you can run concurrent try-jobs, you may just confuse rust-log-analyzer)

…=tgross35 library: Use `size_of` from the prelude instead of imported Use `std::mem::{size_of, size_of_val, align_of, align_of_val}` from the prelude instead of importing or qualifying them. These functions were added to all preludes in Rust 1.80. try-job: test-various try-job: x86_64-gnu try-job: x86_64-msvc-1

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#137674 (Enable `f16` for LoongArch) - rust-lang#138034 (library: Use `size_of` from the prelude instead of imported) - rust-lang#138060 (Revert rust-lang#138019 after further discussion about how hir-pretty printing should work) - rust-lang#138073 (Break critical edges in inline asm before code generation) - rust-lang#138107 (`librustdoc`: clippy fixes) - rust-lang#138111 (Use `default_field_values` for `rustc_errors::Context`, `rustc_session::config::NextSolverConfig` and `rustc_session::config::ErrorOutputType`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#138034 - thaliaarchi:use-prelude-size-of, r=tgross35 library: Use `size_of` from the prelude instead of imported Use `std::mem::{size_of, size_of_val, align_of, align_of_val}` from the prelude instead of importing or qualifying them. These functions were added to all preludes in Rust 1.80. try-job: test-various try-job: x86_64-gnu try-job: x86_64-msvc-1

rustbot assigned jieyouxu Mar 5, 2025

workingjubilee reviewed Mar 5, 2025

View reviewed changes

compiler/rustc_data_structures/src/aligned.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2025

This comment has been minimized.

Sign in to view

thaliaarchi force-pushed the use-prelude-size-of branch from 88cec8c to ae1a15a Compare March 5, 2025 05:53

This comment has been minimized.

Sign in to view

thaliaarchi requested a review from tgross35 March 7, 2025 01:18

thaliaarchi added 2 commits March 6, 2025 20:20

library: Use size_of from the prelude instead of imported

988eb19

Use `std::mem::{size_of, size_of_val, align_of, align_of_val}` from the prelude instead of importing or qualifying them. These functions were added to all preludes in Rust 1.80.

Use turbofish for size_of<T> and align_of<T> in docs

5dfa2f5

thaliaarchi force-pushed the use-prelude-size-of branch from b4a107d to 5dfa2f5 Compare March 7, 2025 04:27

tgross35 approved these changes Mar 7, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2025

jhpratt mentioned this pull request Mar 7, 2025

Rollup of 13 pull requests #138152

Closed

This was referenced Mar 7, 2025

Rollup of 7 pull requests #138153

Closed

Rollup of 6 pull requests #138155

Merged

bors merged commit b834632 into rust-lang:master Mar 7, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Mar 7, 2025

thaliaarchi deleted the use-prelude-size-of branch March 7, 2025 18:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

library: Use `size_of` from the prelude instead of imported #138034

library: Use `size_of` from the prelude instead of imported #138034

thaliaarchi commented Mar 5, 2025 •

edited by tgross35

Loading

rustbot commented Mar 5, 2025

This comment has been minimized.

compiler-errors commented Mar 5, 2025 •

edited

Loading

rustbot commented Mar 5, 2025

This comment has been minimized.

thaliaarchi commented Mar 5, 2025

This comment has been minimized.

thaliaarchi commented Mar 5, 2025

compiler-errors commented Mar 5, 2025 •

edited

Loading

tgross35 commented Mar 7, 2025

bors commented Mar 7, 2025

thaliaarchi commented Mar 7, 2025

tgross35 commented Mar 7, 2025

compiler-errors commented Mar 7, 2025

thaliaarchi commented Mar 7, 2025

tgross35 commented Mar 7, 2025

tgross35 left a comment

thaliaarchi commented Mar 7, 2025

tgross35 commented Mar 7, 2025 •

edited

Loading

thaliaarchi commented Mar 7, 2025

tgross35 commented Mar 7, 2025

bors commented Mar 7, 2025

jieyouxu commented Mar 7, 2025

library: Use size_of from the prelude instead of imported #138034

library: Use size_of from the prelude instead of imported #138034

Conversation

thaliaarchi commented Mar 5, 2025 • edited by tgross35 Loading

rustbot commented Mar 5, 2025

This comment has been minimized.

compiler-errors commented Mar 5, 2025 • edited Loading

rustbot commented Mar 5, 2025

This comment has been minimized.

thaliaarchi commented Mar 5, 2025

This comment has been minimized.

thaliaarchi commented Mar 5, 2025

compiler-errors commented Mar 5, 2025 • edited Loading

tgross35 commented Mar 7, 2025

bors commented Mar 7, 2025

thaliaarchi commented Mar 7, 2025

tgross35 commented Mar 7, 2025

compiler-errors commented Mar 7, 2025

thaliaarchi commented Mar 7, 2025

tgross35 commented Mar 7, 2025

tgross35 left a comment

Choose a reason for hiding this comment

thaliaarchi commented Mar 7, 2025

tgross35 commented Mar 7, 2025 • edited Loading

thaliaarchi commented Mar 7, 2025

tgross35 commented Mar 7, 2025

bors commented Mar 7, 2025

jieyouxu commented Mar 7, 2025

library: Use `size_of` from the prelude instead of imported #138034

library: Use `size_of` from the prelude instead of imported #138034

thaliaarchi commented Mar 5, 2025 •

edited by tgross35

Loading

compiler-errors commented Mar 5, 2025 •

edited

Loading

compiler-errors commented Mar 5, 2025 •

edited

Loading

tgross35 commented Mar 7, 2025 •

edited

Loading