Various coretests improvements #137679

bjorn3 · 2025-02-26T15:02:02Z

The first commit is not yet strictly necessary as directly testing libcore works though useless work, but will be necessary once #136642 migrates the liballoc tests into a separate package. The second commit fixes #137478 and ensures that coretests actually gets tested on all CI job. The third commit fixes an error that didn't get caught because coretests doesn't run on the wasm32 CI job.

This overrides the test=false flag in Cargo.toml and it shouldn't be necessary as --tests is already passed.

rustbot · 2025-02-26T15:02:09Z

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

It is reasonable to expect that ./x.py test core is enough to run tests when you are working on core. In addition it seems like CI for wasm32 at least doesn't run coretests currently, which this commit fixes.

RalfJung · 2025-02-26T15:42:37Z

The second commit fixes #137478, fixes rust-lang/miri-test-libstd#88 and

I don't think it does; miri-test-libstd does not use x.py.

bjorn3 · 2025-02-26T15:58:50Z

Removed it from the PR description again.

Kobzol · 2025-02-26T16:30:48Z

The changes make sense, but I don't know much about how std/core tests are configured, so would appreciate another look.

@jieyouxu?

jieyouxu · 2025-02-27T00:11:08Z

Sure, I'll also take a look.

jieyouxu

This does make ./x test library/core or ./x test core also run coretests, though I'm slightly iffy about how coretests get added.

jieyouxu · 2025-03-03T13:46:49Z

src/bootstrap/src/core/build_steps/test.rs

+        let mut crates = self.crates.clone();
+        // The core crate can't directly be tested. We could silently
+        // ignore it, but adding it's own test crate is less confusing
+        // for users. We still keep core itself for doctests.
+        if crates.iter().any(|crate_| crate_ == "core") {
+            crates.push("coretests".to_owned());
+        }


Adding this here feels somewhat iffy to me, but the Crate step is iffy itself (I feel like we really ought to be splitting it to be a library-crate-facing step vs compiler-crate-facing step).

jieyouxu · 2025-03-03T13:48:56Z

r? @onur-ozkan for a third pair of eyes...

Can we maybe have the Crate step ensure a dedicated library/coretests step instead of doing the crate-name-is-core hack?

onur-ozkan

r? @onur-ozkan for a third pair of eyes...

Thanks for the ping, it LGTM.

jieyouxu · 2025-03-03T20:46:41Z

I think it doesn't hurt to improve ./x test core / ./x test library/core in the mean time, so feel free to also r=me.

bjorn3 · 2025-03-04T08:55:27Z

Do you mean that I can do r=jieyouxu?

jieyouxu · 2025-03-04T08:57:52Z

Sorry, I forgor to actually talk to bors.

@bors r=jieyouxu,onur-ozkan

bors · 2025-03-04T08:57:55Z

📌 Commit 169e731 has been approved by jieyouxu,onur-ozkan

It is now in the queue for this repository.

…ieyouxu,onur-ozkan Various coretests improvements The first commit is not yet strictly necessary as directly testing libcore works though useless work, but will be necessary once rust-lang#136642 migrates the liballoc tests into a separate package. The second commit fixes rust-lang#137478 and ensures that coretests actually gets tested on all CI job. The third commit fixes an error that didn't get caught because coretests doesn't run on the wasm32 CI job.

Rollup of 10 pull requests Successful merges: - rust-lang#136581 (Retire the legacy `Makefile`-based `run-make` test infra) - rust-lang#136865 (Perform deeper compiletest path normalization for `$TEST_BUILD_DIR` to account for compare-mode/debugger cases, and normalize long type file filename hashes) - rust-lang#136975 (Look for `python3` first on MacOS, not `py`) - rust-lang#137240 (Slightly reformat `std::fs::remove_dir_all` error docs) - rust-lang#137303 (Remove `MaybeForgetReturn` suggestion) - rust-lang#137634 (Update `compiler-builtins` to 0.1.149) - rust-lang#137679 (Various coretests improvements) - rust-lang#137685 (self-contained linker: conservatively default to `-znostart-stop-gc`) - rust-lang#137850 (Stabilize `box_uninit_write`) - rust-lang#137947 (Do not install rustup on Rust for Linux job) r? `@ghost` `@rustbot` modify labels: rollup

…ieyouxu,onur-ozkan Various coretests improvements The first commit is not yet strictly necessary as directly testing libcore works though useless work, but will be necessary once rust-lang#136642 migrates the liballoc tests into a separate package. The second commit fixes rust-lang#137478 and ensures that coretests actually gets tested on all CI job. The third commit fixes an error that didn't get caught because coretests doesn't run on the wasm32 CI job.

…kingjubilee Rollup of 25 pull requests Successful merges: - rust-lang#134063 (dec2flt: Clean up float parsing modules) - rust-lang#136581 (Retire the legacy `Makefile`-based `run-make` test infra) - rust-lang#136662 (Count char width at most once in `Formatter::pad`) - rust-lang#136798 (Added documentation for flushing per rust-lang#74348) - rust-lang#137240 (Slightly reformat `std::fs::remove_dir_all` error docs) - rust-lang#137303 (Remove `MaybeForgetReturn` suggestion) - rust-lang#137327 (Undeprecate env::home_dir) - rust-lang#137463 ([illumos] attempt to use posix_spawn to spawn processes) - rust-lang#137477 (uefi: Add Service Binding Protocol abstraction) - rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var) - rust-lang#137569 (Stabilize `string_extend_from_within`) - rust-lang#137612 (Update bootstrap to edition 2024) - rust-lang#137633 (Only use implied bounds hack if bevy, and use deeply normalize in implied bounds hack) - rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums) - rust-lang#137679 (Various coretests improvements) - rust-lang#137723 (Make `rust.description` more general-purpose and pass `CFG_VER_DESCRIPTION`) - rust-lang#137758 (fix usage of ty decl macro fragments in attributes) - rust-lang#137764 (Ensure that negative auto impls are always applicable) - rust-lang#137772 (Fix char count in `Display` for `ByteStr`) - rust-lang#137798 (ci: use ubuntu 24 on arm large runner) - rust-lang#137805 (adjust Layout debug printing to match the internal field name) - rust-lang#137808 (Do not require that unsafe fields lack drop glue) - rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists) - rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN) - rust-lang#138028 (compiler: add `ExternAbi::is_rustic_abi`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 20 pull requests Successful merges: - rust-lang#134063 (dec2flt: Clean up float parsing modules) - rust-lang#136581 (Retire the legacy `Makefile`-based `run-make` test infra) - rust-lang#136662 (Count char width at most once in `Formatter::pad`) - rust-lang#136764 (Make `ptr_cast_add_auto_to_object` lint into hard error) - rust-lang#136798 (Added documentation for flushing per rust-lang#74348) - rust-lang#136865 (Perform deeper compiletest path normalization for `$TEST_BUILD_DIR` to account for compare-mode/debugger cases, and normalize long type file filename hashes) - rust-lang#136975 (Look for `python3` first on MacOS, not `py`) - rust-lang#136977 (Upload Datadog metrics with citool) - rust-lang#137240 (Slightly reformat `std::fs::remove_dir_all` error docs) - rust-lang#137298 (Check signature WF when lowering MIR body) - rust-lang#137463 ([illumos] attempt to use posix_spawn to spawn processes) - rust-lang#137477 (uefi: Add Service Binding Protocol abstraction) - rust-lang#137569 (Stabilize `string_extend_from_within`) - rust-lang#137633 (Only use implied bounds hack if bevy, and use deeply normalize in implied bounds hack) - rust-lang#137679 (Various coretests improvements) - rust-lang#137723 (Make `rust.description` more general-purpose and pass `CFG_VER_DESCRIPTION`) - rust-lang#137728 (Remove unsizing coercions for tuples) - rust-lang#137731 (Resume one waiter at once in deadlock handler) - rust-lang#137875 (mir_build: Integrate "simplification" steps into match-pair-tree creation) - rust-lang#138028 (compiler: add `ExternAbi::is_rustic_abi`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#137679 - bjorn3:coretests_improvements, r=jieyouxu,onur-ozkan Various coretests improvements The first commit is not yet strictly necessary as directly testing libcore works though useless work, but will be necessary once rust-lang#136642 migrates the liballoc tests into a separate package. The second commit fixes rust-lang#137478 and ensures that coretests actually gets tested on all CI job. The third commit fixes an error that didn't get caught because coretests doesn't run on the wasm32 CI job.

Stop passing --lib to cargo test

b60aeb0

This overrides the test=false flag in Cargo.toml and it shouldn't be necessary as --tests is already passed.

rustbot assigned Kobzol Feb 26, 2025

bjorn3 mentioned this pull request Feb 26, 2025

Put the alloc unit tests in a separate alloctests package #136642

Merged

bjorn3 force-pushed the coretests_improvements branch from fc146ad to a535d6d Compare February 26, 2025 15:08

bjorn3 added 2 commits February 26, 2025 15:11

Also test coretests when running ./x.py test core

b491494

It is reasonable to expect that ./x.py test core is enough to run tests when you are working on core. In addition it seems like CI for wasm32 at least doesn't run coretests currently, which this commit fixes.

Fix unused import in coretests on wasm32

169e731

bjorn3 force-pushed the coretests_improvements branch from a535d6d to 169e731 Compare February 26, 2025 15:11

This was referenced Feb 26, 2025

Put the core unit tests in a separate coretests package #135937

Merged

Update to run "coretests" rust-lang/miri-test-libstd#88

Closed

jieyouxu self-assigned this Feb 27, 2025

jieyouxu reviewed Mar 3, 2025

View reviewed changes

rustbot assigned onur-ozkan and unassigned Kobzol and jieyouxu Mar 3, 2025

onur-ozkan approved these changes Mar 3, 2025

View reviewed changes

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2025

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 4, 2025

jieyouxu mentioned this pull request Mar 4, 2025

Rollup of 10 pull requests #138007

Closed

workingjubilee mentioned this pull request Mar 5, 2025

Rollup of 25 pull requests #138044

Closed

jieyouxu mentioned this pull request Mar 5, 2025

Rollup of 20 pull requests #138058

Merged

bors merged commit 4aa61e7 into rust-lang:master Mar 5, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Mar 5, 2025

bjorn3 deleted the coretests_improvements branch March 6, 2025 12:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various coretests improvements #137679

Various coretests improvements #137679

bjorn3 commented Feb 26, 2025 •

edited

Loading

rustbot commented Feb 26, 2025

RalfJung commented Feb 26, 2025

bjorn3 commented Feb 26, 2025

Kobzol commented Feb 26, 2025

jieyouxu commented Feb 27, 2025

jieyouxu left a comment

jieyouxu Mar 3, 2025

jieyouxu commented Mar 3, 2025

onur-ozkan left a comment

jieyouxu commented Mar 3, 2025

bjorn3 commented Mar 4, 2025

jieyouxu commented Mar 4, 2025

bors commented Mar 4, 2025

Various coretests improvements #137679

Various coretests improvements #137679

Conversation

bjorn3 commented Feb 26, 2025 • edited Loading

rustbot commented Feb 26, 2025

RalfJung commented Feb 26, 2025

bjorn3 commented Feb 26, 2025

Kobzol commented Feb 26, 2025

jieyouxu commented Feb 27, 2025

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu Mar 3, 2025

Choose a reason for hiding this comment

jieyouxu commented Mar 3, 2025

onur-ozkan left a comment

Choose a reason for hiding this comment

jieyouxu commented Mar 3, 2025

bjorn3 commented Mar 4, 2025

jieyouxu commented Mar 4, 2025

bors commented Mar 4, 2025

bjorn3 commented Feb 26, 2025 •

edited

Loading