Use `edition = "2024"` in the compiler (redux) #137333

compiler-errors · 2025-02-20T19:08:16Z

Most of this is binding mode changes, which I fixed by running x.py fix.

Also adds some miscellaneous unsafe blocks for new unsafe standard library functions (the setenv ones), and a missing unsafe extern block in some enzyme codegen code, and fixes some precise capturing lifetime changes (but only when they led to errors).

cc @ehuss @traviscross

rustbot · 2025-02-20T19:08:26Z

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Nadrieril · 2025-02-20T20:26:07Z

LGTM @bors r+

I'm quite pleased with the binding mode changes. Apart from that one macro, did you have to fix up anything manually for binding modes or was it all automated?

bors · 2025-02-20T20:26:09Z

📌 Commit c10f47d has been approved by Nadrieril

It is now in the queue for this repository.

compiler-errors · 2025-02-20T20:33:07Z

I recall a few places where I had to manually fix the binding mode 🤔 had to do something where we were matching Node::Expr(Expr { .. }) | Node::Stmt(Stmt { StmtKind::Semi(Expr { .. })} )

…, r=Nadrieril Use `edition = "2024"` in the compiler (redux) Most of this is binding mode changes, which I fixed by running `x.py fix`. Also adds some miscellaneous `unsafe` blocks for new unsafe standard library functions (the setenv ones), and a missing `unsafe extern` block in some enzyme codegen code, and fixes some precise capturing lifetime changes (but only when they led to errors). cc `@ehuss` `@traviscross`

Rollup of 12 pull requests Successful merges: - rust-lang#128080 (Specify scope in `out_of_scope_macro_calls` lint) - rust-lang#135354 ([Debuginfo] Add MSVC Synthetic and Summary providers to LLDB) - rust-lang#135630 (add more `s390x` target features) - rust-lang#136089 (Reduce `Box::default` stack copies in debug mode) - rust-lang#136148 (Optionally add type names to `TypeId`s.) - rust-lang#137192 (Remove obsolete Windows ThinLTO+TLS workaround) - rust-lang#137204 (Clarify MIR dialects and phases) - rust-lang#137299 (Simplify `Postorder` customization.) - rust-lang#137302 (Use a probe to avoid registering stray region obligations when re-checking drops in MIR typeck) - rust-lang#137305 (Tweaks in and around `rustc_middle`) - rust-lang#137313 (Some codegen_llvm cleanups) - rust-lang#137333 (Use `edition = "2024"` in the compiler (redux)) r? `@ghost` `@rustbot` modify labels: rollup try-job: test-various try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: i686-mingw-1 try-job: i686-mingw-2 try-job: i686-mingw-3 try-job: x86_64-gnu-nopt

…, r=Nadrieril Use `edition = "2024"` in the compiler (redux) Most of this is binding mode changes, which I fixed by running `x.py fix`. Also adds some miscellaneous `unsafe` blocks for new unsafe standard library functions (the setenv ones), and a missing `unsafe extern` block in some enzyme codegen code, and fixes some precise capturing lifetime changes (but only when they led to errors). cc ``@ehuss`` ``@traviscross``

Rollup of 10 pull requests Successful merges: - rust-lang#128080 (Specify scope in `out_of_scope_macro_calls` lint) - rust-lang#135630 (add more `s390x` target features) - rust-lang#136089 (Reduce `Box::default` stack copies in debug mode) - rust-lang#137192 (Remove obsolete Windows ThinLTO+TLS workaround) - rust-lang#137204 (Clarify MIR dialects and phases) - rust-lang#137299 (Simplify `Postorder` customization.) - rust-lang#137302 (Use a probe to avoid registering stray region obligations when re-checking drops in MIR typeck) - rust-lang#137305 (Tweaks in and around `rustc_middle`) - rust-lang#137313 (Some codegen_llvm cleanups) - rust-lang#137333 (Use `edition = "2024"` in the compiler (redux)) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-gnu try-job: armhf-gnu try-job: i686-mingw-1 try-job: i686-mingw-2 try-job: i686-mingw-3 try-job: test-various try-job: x86_64-gnu-nopt try-job: x86_64-msvc-1 try-job: x86_64-msvc-2

…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#128080 (Specify scope in `out_of_scope_macro_calls` lint) - rust-lang#135630 (add more `s390x` target features) - rust-lang#136089 (Reduce `Box::default` stack copies in debug mode) - rust-lang#137192 (Remove obsolete Windows ThinLTO+TLS workaround) - rust-lang#137204 (Clarify MIR dialects and phases) - rust-lang#137299 (Simplify `Postorder` customization.) - rust-lang#137302 (Use a probe to avoid registering stray region obligations when re-checking drops in MIR typeck) - rust-lang#137305 (Tweaks in and around `rustc_middle`) - rust-lang#137313 (Some codegen_llvm cleanups) - rust-lang#137333 (Use `edition = "2024"` in the compiler (redux)) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2025-02-21T11:44:52Z

@bors r-
#137352 (comment)

rustbot · 2025-02-21T17:44:20Z

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

HIR ty lowering was modified

cc @fmease

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred in compiler/rustc_sanitizers

cc @rust-lang/project-exploit-mitigations, @rcvalle

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in exhaustiveness checking

cc @Nadrieril

compiler-errors · 2025-02-21T17:45:07Z

@bors r=Nadrieril

bors · 2025-02-21T17:45:11Z

📌 Commit 9dc3f5c has been approved by Nadrieril

It is now in the queue for this repository.

compiler-errors · 2025-02-22T00:08:14Z

@bors r=Nadrieril

bors · 2025-02-22T00:08:17Z

📌 Commit b621c9b has been approved by Nadrieril

It is now in the queue for this repository.

compiler-errors · 2025-02-22T00:15:28Z

@bors r=Nadrieril

bors · 2025-02-22T00:15:30Z

📌 Commit 3d5438a has been approved by Nadrieril

It is now in the queue for this repository.

…, r=Nadrieril Use `edition = "2024"` in the compiler (redux) Most of this is binding mode changes, which I fixed by running `x.py fix`. Also adds some miscellaneous `unsafe` blocks for new unsafe standard library functions (the setenv ones), and a missing `unsafe extern` block in some enzyme codegen code, and fixes some precise capturing lifetime changes (but only when they led to errors). cc `@ehuss` `@traviscross`

…mpiler-errors Rollup of 10 pull requests Successful merges: - rust-lang#136642 (Put the alloc unit tests in a separate alloctests package) - rust-lang#136910 (Implement feature `isolate_most_least_significant_one` for integer types) - rust-lang#137183 (Prune dead regionck code) - rust-lang#137333 (Use `edition = "2024"` in the compiler (redux)) - rust-lang#137356 (Ferris 🦀 Identifier naming conventions) - rust-lang#137362 (Add build step log for `run-make-support`) - rust-lang#137377 (Always allow reusing cratenum in CrateLoader::load) - rust-lang#137388 (Fix(lib/fs/tests): Disable rename POSIX semantics FS tests under Windows 7) - rust-lang#137410 (Use StableHasher + Hash64 for dep_tracking_hash) - rust-lang#137413 (jubilee cleared out the review queue) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#136910 (Implement feature `isolate_most_least_significant_one` for integer types) - rust-lang#137183 (Prune dead regionck code) - rust-lang#137333 (Use `edition = "2024"` in the compiler (redux)) - rust-lang#137356 (Ferris 🦀 Identifier naming conventions) - rust-lang#137362 (Add build step log for `run-make-support`) - rust-lang#137377 (Always allow reusing cratenum in CrateLoader::load) - rust-lang#137388 (Fix(lib/fs/tests): Disable rename POSIX semantics FS tests under Windows 7) - rust-lang#137410 (Use StableHasher + Hash64 for dep_tracking_hash) - rust-lang#137413 (jubilee cleared out the review queue) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#137333 - compiler-errors:edition-2024-fresh, r=Nadrieril Use `edition = "2024"` in the compiler (redux) Most of this is binding mode changes, which I fixed by running `x.py fix`. Also adds some miscellaneous `unsafe` blocks for new unsafe standard library functions (the setenv ones), and a missing `unsafe extern` block in some enzyme codegen code, and fixes some precise capturing lifetime changes (but only when they led to errors). cc ``@ehuss`` ``@traviscross``

rustbot assigned Nadrieril Feb 20, 2025

compiler-errors mentioned this pull request Feb 20, 2025

Greatly simplify lifetime captures in edition 2024 #137334

Open

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2025

workingjubilee mentioned this pull request Feb 20, 2025

Rollup of 12 pull requests #137347

Closed

workingjubilee mentioned this pull request Feb 20, 2025

Rollup of 10 pull requests #137352

Closed

traviscross approved these changes Feb 21, 2025

View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 21, 2025

compiler-errors force-pushed the edition-2024-fresh branch from c10f47d to 9dc3f5c Compare February 21, 2025 17:44

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 21, 2025

compiler-errors added 3 commits February 22, 2025 00:01

Upgrade the compiler to edition 2024

76d341f

Fix builtin lints

7f6873f

Fix overcapturing, unsafe extern blocks, and new unsafe ops

e1819a8

compiler-errors force-pushed the edition-2024-fresh branch from 9dc3f5c to b621c9b Compare February 22, 2025 00:03

This comment has been minimized.

Sign in to view

Fix binding mode problems

3d5438a

compiler-errors force-pushed the edition-2024-fresh branch from b621c9b to 3d5438a Compare February 22, 2025 00:14

compiler-errors mentioned this pull request Feb 22, 2025

Rollup of 10 pull requests #137416

Closed

matthiaskrgr mentioned this pull request Feb 22, 2025

Rollup of 9 pull requests #137420

Merged

lqd mentioned this pull request Feb 22, 2025

Use edition = "2024" in the compiler #129636

Closed

bors merged commit 37e0d13 into rust-lang:master Feb 22, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Feb 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `edition = "2024"` in the compiler (redux) #137333

Use `edition = "2024"` in the compiler (redux) #137333

compiler-errors commented Feb 20, 2025

rustbot commented Feb 20, 2025

Nadrieril commented Feb 20, 2025

bors commented Feb 20, 2025

compiler-errors commented Feb 20, 2025 •

edited

Loading

matthiaskrgr commented Feb 21, 2025

rustbot commented Feb 21, 2025

compiler-errors commented Feb 21, 2025

bors commented Feb 21, 2025

compiler-errors commented Feb 22, 2025

bors commented Feb 22, 2025

This comment has been minimized.

compiler-errors commented Feb 22, 2025

bors commented Feb 22, 2025

Use edition = "2024" in the compiler (redux) #137333

Use edition = "2024" in the compiler (redux) #137333

Conversation

compiler-errors commented Feb 20, 2025

rustbot commented Feb 20, 2025

Nadrieril commented Feb 20, 2025

bors commented Feb 20, 2025

compiler-errors commented Feb 20, 2025 • edited Loading

matthiaskrgr commented Feb 21, 2025

rustbot commented Feb 21, 2025

compiler-errors commented Feb 21, 2025

bors commented Feb 21, 2025

compiler-errors commented Feb 22, 2025

bors commented Feb 22, 2025

This comment has been minimized.

compiler-errors commented Feb 22, 2025

bors commented Feb 22, 2025

Use `edition = "2024"` in the compiler (redux) #137333

Use `edition = "2024"` in the compiler (redux) #137333

compiler-errors commented Feb 20, 2025 •

edited

Loading