Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: move x86_64-msvc-ext jobs to windows 2025 #136478

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ci: move x86_64-msvc-ext jobs to windows 2025 #136478

wants to merge 1 commit into from
+3 −3

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Feb 3, 2025 •
edited
Loading

These jobs are a bit flaky. See this zulip thread and this GitHub issue.
Windows 2025 is working well for x86_64-msvc jobs since we moved them in #135632

Analysis

  • The jobs x86_64-msvc-ext2 and x86_64-msvc-ext3 never failed in the last month
  • The job x86_64-msvc-ext1 failed 6 times:
    image

try-job: x86_64-msvc-ext1
try-job: x86_64-msvc-ext2
try-job: x86_64-msvc-ext3

@rustbot
Copy link
Collaborator

rustbot commented Feb 3, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 3, 2025
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2025
@bors
Auto merge of rust-lang#136478 - marcoieni:x86_64-msvc-ext-windows-25…
bfe1bef 
…, r=<try>

ci: move x86_64-msvc-ext jobs to windows 2025

try-job: x86_64-msvc-ext1
try-job: x86_64-msvc-ext2
try-job: x86_64-msvc-ext3
@bors
Copy link
Contributor

bors commented Feb 3, 2025

⌛ Trying commit e9925ae with merge bfe1bef...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-ext1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Updating files:  98% (50710/51744)
Updating files:  99% (51227/51744)
Updating files: 100% (51744/51744)
Updating files: 100% (51744/51744), done.
branch 'try' set up to track 'origin/try'.
Switched to a new branch 'try'
[command]"C:\Program Files\Git\bin\git.exe" log -1 --format=%H
bfe1beff9608a8daa2aa65f25dbdf815ee2ba800
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
---
file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config remote.upstream.fetch=+refs/heads/*:refs/remotes/upstream/*
file:.git/config submodule.library/backtrace.active=true
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
---
   Verifying foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2241\foo)
 Downloading crates ...
  Downloaded bar v1.0.0 (registry `dummy-registry`)
   Compiling bar v1.0.0
   Compiling foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2241\foo\target\package\foo-0.0.1)



failures:

@bors
Copy link
Contributor

bors commented Feb 3, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2025
@marcoieni
Copy link
Member Author

marcoieni commented Feb 3, 2025 •
edited
Loading

weird error 🤔
Has anybody seen this before?

@ChrisDenton
Copy link
Member

The test is here: https://github.com/rust-lang/cargo/blob/0e3d73849ab8cbbab3ec5c65cbd555586cb21339/tests/testsuite/package.rs#L2847

On newer versions of Windows those "reserved" names are allowed so the test fails. Which Cargo seems to be aware of given the test is gated by https://github.com/rust-lang/cargo/blob/0e3d73849ab8cbbab3ec5c65cbd555586cb21339/crates/cargo-test-support/src/paths.rs#L373.

However, that is set to always return false in CI. Probably should open an issue with Cargo asking how they want to proceed.

@marcoieni marcoieni mentioned this pull request Feb 3, 2025
Merged
@marcoieni
Copy link
Member Author

Thanks a lot! Opened rust-lang/cargo#15135

github-merge-queue bot pushed a commit to rust-lang/cargo that referenced this pull request Feb 3, 2025
@ehuss
allow windows reserved names in CI (#15135)
e82878c 
<!--
Thanks for submitting a pull request 🎉! Here are some tips for you:

* If this is your first contribution, read "Cargo Contribution Guide"
first:
  https://doc.crates.io/contrib/
* Run `cargo fmt --all` to format your code changes.
* Small commits and pull requests are always preferable and easy to
review.
* If your idea is large and needs feedback from the community, read how:
  https://doc.crates.io/contrib/process/#working-on-large-features
* Cargo takes care of compatibility. Read our design principles:
  https://doc.crates.io/contrib/design.html
* When changing help text of cargo commands, follow the steps to
generate docs:

https://github.com/rust-lang/cargo/tree/master/src/doc#building-the-man-pages
* If your PR is not finished, set it as "draft" PR or add "WIP" in its
title.
* It's ok to use the CI resources to test your PR, but please don't
abuse them.

### What does this PR try to resolve?

Explain the motivation behind this change.
A clear overview along with an in-depth explanation are helpful.

You can use `Fixes #<issue number>` to associate this PR to an existing
issue.

### How should we test and review this PR?

Demonstrate how you test this change and guide reviewers through your
PR.
With a smooth review process, a pull request usually gets reviewed
quicker.

If you don't know how to write and run your tests, please read the
guide:
https://doc.crates.io/contrib/tests

### Additional information

Other information you want to mention in this PR, such as prior arts,
future extensions, an unresolved problem, or a TODO list.
-->

We are progressively moving the windows CI from windows 2022 to windows
2025 because we found windows 2025 more stable.

In rust-lang/rust#136478 a cargo test failed and
this might solve the issue. See
[this](rust-lang/rust#136478 (comment))
comment. What do you think?

If you have a better way of solving this, let me know 👍
@marcoieni
Copy link
Member Author

marcoieni commented Feb 4, 2025 •
edited
Loading

The cargo PR was merged. Now we need to wait for the cargo team to update cargo inside this repository.
I.e. a PR similar to #136376

@marcoieni marcoieni marked this pull request as draft February 6, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcoieni @rustbot @bors @rust-log-analyzer @ChrisDenton @Mark-Simulacrum