-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Store THIR patterns in Arc instead of Box #136421
Conversation
Some changes occurred in cc @BoxyUwU Some changes occurred in match checking cc @Nadrieril Some changes occurred in exhaustiveness checking cc @Nadrieril |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
[DO NOT MERGE] Store THIR patterns in Arc instead of Box (Checking if this has any measurable effect on perf.) r? ghost `@rustbot` experimental
⌛ Trying commit 0201b00 with merge ac7601f83319191e022cff963ad437230fb27043... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (ac7601f): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.6%, secondary 1.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 777.275s -> 777.712s (0.06%) |
I've proposed some less ambitious changes in #136435. |
(Checking if this has any measurable effect on perf.)
r? ghost
@rustbot experimental