-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct small grammar and typo issues in compiler docs/tests #136383
Conversation
MarsonKotovi4
commented
Feb 1, 2025
- Changed “preceded” and “intended” typos.
- Replaced “thi” → “this” and fixed a few minor grammar points across various comments.
- No functional code changes, just documentation cleanup.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Same argumentation as #136384 (comment) applies, |
/// #[cfg(widnows)] | ||
/// #[cfg(windows)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intended, and "fixing" this is wrong.
We've seen a wave of tiny typo fix PRs similar to yours that we suspect are linked with blockchain rewards. These sometimes result in github deleting the entire account and all PRs of that account, causing trouble for tooling processing commits and corresponding PRs. To avoid encouraging such PRs and to prevent churn from deleted PRs we will not accept such PRs. If you would like to contribute to the project, you are more than welcome to contribute something more substantial. |
This comment was marked as spam.
This comment was marked as spam.
Internal-facing stylistic PRs are not worth reviewer bandwidth or the required churn, c.f. #58619 |