Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct small grammar and typo issues in compiler docs/tests #136383

Closed
wants to merge 9 commits into from

Conversation

MarsonKotovi4
Copy link

  • Changed “preceded” and “intended” typos.
  • Replaced “thi” → “this” and fixed a few minor grammar points across various comments.
  • No functional code changes, just documentation cleanup.

@rustbot
Copy link
Collaborator

rustbot commented Feb 1, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 1, 2025
@cyrgani
Copy link
Contributor

cyrgani commented Feb 1, 2025

Same argumentation as #136384 (comment) applies,

/// #[cfg(widnows)]
/// #[cfg(windows)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intended, and "fixing" this is wrong.

@jieyouxu
Copy link
Member

jieyouxu commented Feb 1, 2025

We've seen a wave of tiny typo fix PRs similar to yours that we suspect are linked with blockchain rewards. These sometimes result in github deleting the entire account and all PRs of that account, causing trouble for tooling processing commits and corresponding PRs. To avoid encouraging such PRs and to prevent churn from deleted PRs we will not accept such PRs. If you would like to contribute to the project, you are more than welcome to contribute something more substantial.

@jieyouxu jieyouxu closed this Feb 1, 2025
@MarsonKotovi4

This comment was marked as spam.

@workingjubilee
Copy link
Member

Internal-facing stylistic PRs are not worth reviewer bandwidth or the required churn, c.f. #58619

@rust-lang rust-lang locked as spam and limited conversation to collaborators Feb 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants