ci: refactor how directories are removed in free-disk-space disk

[marcoieni]

• refactor how directories are removed.
• add set -euo pipefail to fail if there's an error in the script. This helps us realize when we make mistakes.
• don't delete directory "/opt/ghc" because it doesn't exist. This directory isn't present in ubuntu 24 as well.
• solve all shellcheck issues.

try-job: aarch64-gnu

[rustbot]

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[marcoieni]

@rustbot ready

[Kobzol]

@bors r+ rollup

[bors]

📌 Commit 89de239 has been approved by Kobzol

It is now in the queue for this repository.

[matthiaskrgr]

@bors r-
this is not working #136285 (comment)

2025-01-30T11:38:35.9453186Z 3ddd26ca0e11854152de3b22030cba1560f6ca8f
2025-01-30T11:38:35.9618451Z ##[group]Run src/ci/scripts/free-disk-space.sh
2025-01-30T11:38:35.9618881Z �[36;1msrc/ci/scripts/free-disk-space.sh�[0m
2025-01-30T11:38:35.9657806Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2025-01-30T11:38:35.9658136Z env:
2025-01-30T11:38:35.9658473Z   TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
2025-01-30T11:38:35.9659380Z   TOOLSTATE_REPO_ACCESS_TOKEN: ***
2025-01-30T11:38:35.9659637Z   CI_JOB_NAME: aarch64-gnu
2025-01-30T11:38:35.9659894Z   CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
2025-01-30T11:38:35.9660202Z   HEAD_SHA: 3ddd26ca0e11854152de3b22030cba1560f6ca8f
2025-01-30T11:38:35.9660570Z   DOCKER_TOKEN: ***
2025-01-30T11:38:35.9660783Z   SCCACHE_BUCKET: rust-lang-ci-sccache2
2025-01-30T11:38:35.9661052Z   CACHE_DOMAIN: ci-caches.rust-lang.org
2025-01-30T11:38:35.9661306Z ##[endgroup]
2025-01-30T11:38:35.9756411Z ================================================================================
2025-01-30T11:38:35.9756837Z BEFORE CLEAN-UP:
2025-01-30T11:38:35.9756992Z 
2025-01-30T11:38:35.9757071Z $ df -h
2025-01-30T11:38:35.9757196Z 
2025-01-30T11:38:35.9766959Z Filesystem      Size  Used Avail Use% Mounted on
2025-01-30T11:38:35.9767330Z /dev/root        73G   27G   46G  37% /
2025-01-30T11:38:35.9767604Z tmpfs           7.8G  4.0K  7.8G   1% /dev/shm
2025-01-30T11:38:35.9767880Z tmpfs           3.2G 1000K  3.2G   1% /run
2025-01-30T11:38:35.9768166Z tmpfs           5.0M     0  5.0M   0% /run/lock
2025-01-30T11:38:35.9768481Z efivarfs        128M   16K  128M   1% /sys/firmware/efi/efivars
2025-01-30T11:38:35.9768801Z /dev/sda15       98M  6.3M   92M   7% /boot/efi
2025-01-30T11:38:35.9769093Z tmpfs           1.6G  4.0K  1.6G   1% /run/user/1001
2025-01-30T11:38:35.9771069Z ================================================================================
2025-01-30T11:38:35.9771291Z 
2025-01-30T11:38:41.8955476Z E: Unable to locate package google-chrome-stable
2025-01-30T11:38:41.8955843Z E: Unable to locate package powershell
2025-01-30T11:38:41.8956165Z E: Unable to locate package google-cloud-sdk
2025-01-30T11:38:41.8956477Z E: Unable to locate package google-cloud-cli
2025-01-30T11:38:41.8987897Z ##[error]Process completed with exit code 100.
2025-01-30T11:38:41.9201938Z Post job cleanup.
2025-01-30T11:38:41.9981899Z [command]/usr/bin/git version
2025-01-30T11:38:42.0013286Z git version 2.48.1

[matthiaskrgr]

@bors try

[bors]

⌛ Trying commit 89de239 with merge 5b9c2fb...

[marcoieni]

I'll have a look, thanks!

I added aarch64-gnu to the try jobs list.

[bors]

☀️ Try build successful - checks-actions
Build commit: 5b9c2fb (5b9c2fb066fa7167b38d45ef0d493795a0e66f3b)

[bors]

💔 Test failed - checks-actions

[marcoieni]

@bors try

[bors]

⌛ Trying commit 053fa1c with merge 934ad23...

[marcoieni]

The issue was that certain packages aren't installed in the arm runners.
I think the script should work now 👍

[Kobzol]

@bors r+ rollup=never

[bors]

📌 Commit 053fa1c has been approved by Kobzol

It is now in the queue for this repository.

[bors]

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 934ad23 to master...

[bors]

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

[Kobzol]

Crap, I didn't notice that the try build was still running. Hopefully nothing got broken.

@bors r-

[Kobzol]

@bors r+

[bors]

📌 Commit 053fa1c has been approved by Kobzol

It is now in the queue for this repository.

[bors]

⌛ Testing commit 053fa1c with merge 6dd75f0...

[bors]

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 6dd75f0 to master...

[rust-timer]

Finished benchmarking commit (6dd75f0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 5.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.7%	[5.7%, 5.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.275s -> 778.443s (0.15%)
Artifact size: 328.69 MiB -> 328.63 MiB (-0.02%)