Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #136070

Merged
merged 16 commits into from
Jan 26, 2025
Merged

Rollup of 7 pull requests #136070

merged 16 commits into from
Jan 26, 2025

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJung and others added 16 commits January 21, 2025 17:29
- Simplify some of the language
- Minor grammar fixes
- Don't imply that pipes *only* work across multiple processes; instead,
  *suggest* that they're typically used across two or more separate
  processes.
- Specify that portable applications cannot use multiple readers or
  multiple writers for messages larger than a byte, due to potential
  interleaving.
- Remove no-longer-referenced footnote URLs.
…yukang

remove long-deprecated no-op attributes no_start and crate_id

These have emitted a deprecation warning since forever (rust-lang#64471) and they already don't do anything. In fact they [apparently](rust-lang#64471 (comment)) have done nothing since pre-1.0, so... do we even need a crater run? Doesn't seem worth it.
Improve and expand documentation of pipes

- Reference UNIX, not just Linux
- Simplify some of the language
- Don't imply that pipes *only* work across multiple processes; instead,
  *suggest* that they're typically used across two or more separate
  processes.
- Specify that portable applications cannot use multiple readers or
  multiple writers for messages larger than a byte, due to potential
  interleaving.

Tracking issue for anonymous pipes:
rust-lang#127154
…-Simulacrum

Include missing item in the 1.81 release notes

It was pointed out to me that when I prepared the CVE-2024-43402 fix in the stable branch, I added the release notes in the stable PR (rust-lang#129960), but I forgot to do so in the beta or nightly PR. Because of that, the relnotes line only appeared in 1.81, and disappeared afterwards.
ports last few library files to new intrinsic style

This pr ports the last 2 library files to new intrinsic style this pr is part of issue rust-lang#132735
… r=jieyouxu

Improve check-cfg expected names diagnostic

This PR improves the check-cfg `allow-same-level` test by ~~normalizing it's output and by~~ adding more context to the test.

It also filters the well known cfgs from the `expected names are` note, as to reduce the size of the diagnostic. Users can still find the full list on the [rustc book](https://doc.rust-lang.org/nightly/rustc/check-cfg.html#well-known-names-and-values), which is reinforced for Cargo users by adding a note in the Cargo check-cfg specific section.

Fixes rust-lang#135995
r? `@jieyouxu`
docs: fix typo in std::pin overview

Unimportant fix in `std::pin` documentation.
…t, r=jieyouxu

Fix typo in const stability error message
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 25, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Jan 25, 2025

📌 Commit 08c4d63 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2025
@bors
Copy link
Contributor

bors commented Jan 26, 2025

⌛ Testing commit 08c4d63 with merge 2f0ad2a...

@bors
Copy link
Contributor

bors commented Jan 26, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 2f0ad2a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 26, 2025
@bors bors merged commit 2f0ad2a into rust-lang:master Jan 26, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 26, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#134300 remove long-deprecated no-op attributes no_start and crate_… 5c8b00fdcc5df6eb8f2f82f27c37b8f2ddb7f43a (link)
#134373 Improve and expand documentation of pipes c2e9dbcd85618e19ba182a484a9832a6b2068066 (link)
#135934 Include missing item in the 1.81 release notes 45e2ccb86f3cee4c774d87edca76f1afd528bf5f (link)
#136005 ports last few library files to new intrinsic style a98f116234cfee704bbf546c37875a12ab3b7c48 (link)
#136016 Improve check-cfg expected names diagnostic 5c236b45b7b3eed446285adcf340e5ce7f5f714f (link)
#136039 docs: fix typo in std::pin overview 195fe84f0d128312f334b76918542b678942c0d1 (link)
#136056 Fix typo in const stability error message 490350a8baedc272dace17959430b0c5a98ed24a (link)

previous master: 6fb03584cf

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2f0ad2a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.2% [-4.4%, -0.2%] 28
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) -1.2% [-4.4%, -0.2%] 28

Max RSS (memory usage)

Results (primary 0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.5% [2.1%, 3.2%] 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.8% [-2.9%, -0.6%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.8% [-2.9%, 3.2%] 5

Cycles

Results (primary -3.2%, secondary 13.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
13.2% [11.2%, 15.3%] 6
Improvements ✅
(primary)
-3.2% [-3.5%, -2.9%] 5
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.2% [-3.5%, -2.9%] 5

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.759s -> 773.228s (0.19%)
Artifact size: 325.83 MiB -> 325.80 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.