Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolstate maintainers #135940

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Update toolstate maintainers #135940

merged 2 commits into from
Feb 7, 2025

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jan 23, 2025

This updates the toolstate maintainers to more closely match who is still active.

This is not tracked in toolstate.
@rust-log-analyzer

This comment has been minimized.

This updates the toolstate maintainers to more closely match who is
still active. I am adding myself to ensure these get resolved if they
break, since otherwise it causes other problems.
@ehuss
Copy link
Contributor Author

ehuss commented Jan 23, 2025

r? @Mark-Simulacrum

@ehuss
Copy link
Contributor Author

ehuss commented Feb 6, 2025

Ping @Mark-Simulacrum

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 7, 2025
@Mark-Simulacrum
Copy link
Member

Hm, not sure why this didn't get labeled (I only look at waiting on review things in my ~weekly reviews).

Seems good. @bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 7, 2025

📌 Commit af8c33d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2025
@ehuss
Copy link
Contributor Author

ehuss commented Feb 7, 2025

Oh, I didn't think to add the label.
Triagebot missed auto-assignment. We were talking about it at https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/New.20PR.20assignment!/near/495558322, but didn't have an answer why.

It missed assignment again this morning, and I opened https://rust-lang.zulipchat.com/#narrow/channel/224082-triagebot/topic/dropped.20assignment/near/498205908 to talk about it. I have a theory that the Postgres connections are timing out. I don't know how much of an expert you are on Amazon RDS, but I'd be curious what your thoughts are.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 7, 2025
…ulacrum

Update toolstate maintainers

This updates the toolstate maintainers to more closely match who is still active.
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#134367 (Stabilize `feature(trait_upcasting)`)
 - rust-lang#135354 ([Debuginfo] Add MSVC Synthetic and Summary providers to LLDB)
 - rust-lang#135940 (Update toolstate maintainers)
 - rust-lang#135945 (Remove some unnecessary parens in `assert!` conditions)
 - rust-lang#136577 (Pattern Migration 2024: try to suggest eliding redundant binding modifiers)
 - rust-lang#136598 (Fix suggestion for `dependency_on_unit_never_type_fallback` involving closures + format args expansions)
 - rust-lang#136653 (Remove dead code from rustc_codegen_llvm and the LLVM wrapper)
 - rust-lang#136664 (replace one `.map_or(true, ...)` with `.is_none_or(...)`)

Failed merges:

 - rust-lang#136193 (Implement pattern type ffi checks)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#134367 (Stabilize `feature(trait_upcasting)`)
 - rust-lang#135940 (Update toolstate maintainers)
 - rust-lang#135945 (Remove some unnecessary parens in `assert!` conditions)
 - rust-lang#136577 (Pattern Migration 2024: try to suggest eliding redundant binding modifiers)
 - rust-lang#136598 (Fix suggestion for `dependency_on_unit_never_type_fallback` involving closures + format args expansions)
 - rust-lang#136653 (Remove dead code from rustc_codegen_llvm and the LLVM wrapper)
 - rust-lang#136664 (replace one `.map_or(true, ...)` with `.is_none_or(...)`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 32f7733 into rust-lang:master Feb 7, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 7, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2025
Rollup merge of rust-lang#135940 - ehuss:toolstate-update, r=Mark-Simulacrum

Update toolstate maintainers

This updates the toolstate maintainers to more closely match who is still active.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants