Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document purpose of closure in from_fn.rs more clearly #135886

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Document purpose of closure in from_fn.rs more clearly #135886

merged 1 commit into from
Jan 28, 2025

Conversation

hkBst
Copy link
Member

@hkBst hkBst commented Jan 22, 2025 •
edited
Loading

partial fix for #135087 together with #135895

@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 22, 2025
@joboet
Copy link
Member

joboet commented Jan 22, 2025

That's very tidy, good idea. Perhaps you could also add a link to the documentation for the next method? Otherwise this seems fine to me.

hkBst added a commit to hkBst/rust that referenced this pull request Jan 22, 2025
@hkBst
Document workings of successors more clearly
ae6dbb8 
This is an attempt to fix rust-lang#135087 together with rust-lang#135886, but I am not sure if I've succeeded in adding much clarity here, so don't be shy with your comments.
@hkBst hkBst mentioned this pull request Jan 22, 2025
Merged
@joboet
Copy link
Member

joboet commented Jan 24, 2025

Thank you!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 24, 2025

📌 Commit 7328de0 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2025
joboet added a commit to joboet/rust that referenced this pull request Jan 24, 2025
@joboet
Rollup merge of rust-lang#135886 - hkBst:patch-14, r=joboet
6e38f43 
Document purpose of closure in from_fn.rs more clearly

partial fix for rust-lang#135087 together with rust-lang#135895
@joboet joboet mentioned this pull request Jan 24, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
@bors
Auto merge of rust-lang#136002 - joboet:rollup-f7cf3xs, r=joboet
88d021a 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#135728 (document order of items in iterator from drain)
 - rust-lang#135829 (Rustc dev guide subtree update)
 - rust-lang#135886 (Document purpose of closure in from_fn.rs more clearly)
 - rust-lang#135977 (Fix `FormattingOptions` instantiation with `Default`)
 - rust-lang#135983 (Doc difference between extend and extend_from_slice)
 - rust-lang#135985 (Rename test to `unresolvable-upvar-issue-87987.rs` and add some notes)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee
Copy link
Member

There was really no need to split this and #135895

There was definitely no need to split this into two commits. Please squash.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 24, 2025
@workingjubilee workingjubilee self-assigned this Jan 24, 2025
@hkBst
Copy link
Member Author

hkBst commented Jan 26, 2025

squashed
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 26, 2025
@workingjubilee
Copy link
Member

Thank you.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 27, 2025

📌 Commit d3cd832 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 28, 2025
@Zalathar
Rollup merge of rust-lang#135886 - hkBst:patch-14, r=workingjubilee
d960b9e 
Document purpose of closure in from_fn.rs more clearly

partial fix for rust-lang#135087 together with rust-lang#135895
@Zalathar Zalathar mentioned this pull request Jan 28, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2025
@bors
Auto merge of rust-lang#136165 - Zalathar:rollup-9v69i9w, r=Zalathar
3ec8575 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#133151 (Trim extra whitespace in fn ptr suggestion span)
 - rust-lang#133929 (Remove -Zinline-in-all-cgus and clean up tests/codegen-units/)
 - rust-lang#134290 (Windows x86: Change i128 to return via the vector ABI)
 - rust-lang#135886 (Document purpose of closure in from_fn.rs more clearly)
 - rust-lang#136012 (Document powf and powi values that are always 1.0)
 - rust-lang#136104 (Add mermaid graphs of NLL regions and SCCs to polonius MIR dump)
 - rust-lang#136117 (Subtree update of `rust-analyzer`)
 - rust-lang#136143 (Update books)
 - rust-lang#136153 (Locate asan-odr-win with other sanitizer tests)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 28, 2025
@Zalathar
Rollup merge of rust-lang#135886 - hkBst:patch-14, r=workingjubilee
3e8c84c 
Document purpose of closure in from_fn.rs more clearly

partial fix for rust-lang#135087 together with rust-lang#135895
@Zalathar Zalathar mentioned this pull request Jan 28, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2025
@bors
Auto merge of rust-lang#136169 - Zalathar:rollup-w09vw0j, r=Zalathar
1efb705 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#133151 (Trim extra whitespace in fn ptr suggestion span)
 - rust-lang#134290 (Windows x86: Change i128 to return via the vector ABI)
 - rust-lang#135886 (Document purpose of closure in from_fn.rs more clearly)
 - rust-lang#136012 (Document powf and powi values that are always 1.0)
 - rust-lang#136104 (Add mermaid graphs of NLL regions and SCCs to polonius MIR dump)
 - rust-lang#136143 (Update books)
 - rust-lang#136153 (Locate asan-odr-win with other sanitizer tests)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 28, 2025
@Zalathar
Rollup merge of rust-lang#135886 - hkBst:patch-14, r=workingjubilee
9e96c80 
Document purpose of closure in from_fn.rs more clearly

partial fix for rust-lang#135087 together with rust-lang#135895
@Zalathar Zalathar mentioned this pull request Jan 28, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2025
@bors
Auto merge of rust-lang#136174 - Zalathar:rollup-bgdzjlo, r=Zalathar
0bcd6d7 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#133151 (Trim extra whitespace in fn ptr suggestion span)
 - rust-lang#133929 (Remove -Zinline-in-all-cgus and clean up tests/codegen-units/)
 - rust-lang#135886 (Document purpose of closure in from_fn.rs more clearly)
 - rust-lang#135961 (Fix 2/4 tests skipped by opt-dist)
 - rust-lang#136104 (Add mermaid graphs of NLL regions and SCCs to polonius MIR dump)
 - rust-lang#136124 (Arbitrary self types v2: explain test.)
 - rust-lang#136153 (Locate asan-odr-win with other sanitizer tests)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 28, 2025
@matthiaskrgr
Rollup merge of rust-lang#135886 - hkBst:patch-14, r=workingjubilee
903a9ba 
Document purpose of closure in from_fn.rs more clearly

partial fix for rust-lang#135087 together with rust-lang#135895
This was referenced Jan 28, 2025
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2025
@bors
Auto merge of rust-lang#136185 - matthiaskrgr:rollup-zqzy6wb, r=matth…
fdd1a3b 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#133151 (Trim extra whitespace in fn ptr suggestion span)
 - rust-lang#133829 (Implement `AtomicT::update` & `AtomicT::try_update`)
 - rust-lang#135367 (Enable `unreachable_pub` lint in `alloc`)
 - rust-lang#135748 (Lower index bounds checking to `PtrMetadata`, this time with the right fake borrow semantics 😸)
 - rust-lang#135805 (Add missing allocator safety in alloc crate)
 - rust-lang#135886 (Document purpose of closure in from_fn.rs more clearly)
 - rust-lang#135961 (Fix 2/4 tests skipped by opt-dist)
 - rust-lang#136012 (Document powf and powi values that are always 1.0)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 448fa11 into rust-lang:master Jan 28, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 28, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2025
@rust-timer
Unrolled build for rust-lang#135886
1f424b2 
Rollup merge of rust-lang#135886 - hkBst:patch-14, r=workingjubilee

Document purpose of closure in from_fn.rs more clearly

partial fix for rust-lang#135087 together with rust-lang#135895
@hkBst hkBst deleted the patch-14 branch February 2, 2025 11:08
hkBst added a commit to hkBst/rust that referenced this pull request Mar 2, 2025
@hkBst
Document workings of successors more clearly
6867806 
This is an attempt to fix rust-lang#135087 together with rust-lang#135886, but I am not sure if I've succeeded in adding much clarity here, so don't be shy with your comments.
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Mar 6, 2025
@compiler-errors
Rollup merge of rust-lang#135895 - hkBst:patch-15, r=joboet
5b07412 
Document workings of successors more clearly

This is an attempt to fix rust-lang#135087 together with rust-lang#135886, but I am not sure if I've succeeded in adding much clarity here, so don't be shy with your comments.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
@rust-timer
Unrolled build for rust-lang#135895
46b7581 
Rollup merge of rust-lang#135895 - hkBst:patch-15, r=joboet

Document workings of successors more clearly

This is an attempt to fix rust-lang#135087 together with rust-lang#135886, but I am not sure if I've succeeded in adding much clarity here, so don't be shy with your comments.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Mar 7, 2025
@compiler-errors
Rollup merge of #135895 - hkBst:patch-15, r=joboet
09e8b3c 
Document workings of successors more clearly

This is an attempt to fix #135087 together with rust-lang/rust#135886, but I am not sure if I've succeeded in adding much clarity here, so don't be shy with your comments.
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Mar 10, 2025
@compiler-errors
Rollup merge of #135895 - hkBst:patch-15, r=joboet
c4002d3 
Document workings of successors more clearly

This is an attempt to fix #135087 together with rust-lang/rust#135886, but I am not sure if I've succeeded in adding much clarity here, so don't be shy with your comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joboet joboet

@workingjubilee workingjubilee

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hkBst @rustbot @joboet @bors @workingjubilee