fix underlining of hovered intra-doc links. #135499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @notriddle rustbot has assigned @notriddle. Use |
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
rustbot
added
the
T-rustdoc
notriddle
reviewed
Jan 14, 2025
lolbinarycat
force-pushed
the
rustdoc-link-underline-133484
branch
from
3c5de87 to
4f6902d
Compare
|
For the test, it needs to be a |
|
it would probably be easier for you to implement it yourself, as it can be difficult to get software running correctly on NixOS, expecially with underpowered hardware. |
|
Ok, let's do that then. Thanks for the improvement! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2025
…kingjubilee Rollup of 11 pull requests Successful merges: - rust-lang#134913 (bootstrap: do not rely on LIBRARY_PATH env variable) - rust-lang#134940 (Make sure to scrape region constraints from deeply normalizing type outlives assumptions in borrowck) - rust-lang#135228 (Improve `DispatchFromDyn` and `CoerceUnsized` impl validation) - rust-lang#135264 (Consider more erroneous layouts as `LayoutError::ReferencesError` to suppress spurious errors) - rust-lang#135302 (for purely return-type based searches, deprioritize clone-like functions) - rust-lang#135353 (re-add --disable-minification to rustdoc) - rust-lang#135380 (Make sure we can produce `ConstArgHasWrongType` errors for valtree consts) - rust-lang#135423 (Enforce syntactical stability of const traits in HIR) - rust-lang#135425 (Do not consider traits that have unsatisfied const conditions to be conditionally const) - rust-lang#135499 (fix underlining of hovered intra-doc links.) - rust-lang#135505 (Fix clippy lints in rustdoc) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2025
Rollup merge of rust-lang#135499 - lolbinarycat:rustdoc-link-underline-133484, r=GuillaumeGomez fix underlining of hovered intra-doc links. fixes rust-lang#133484 i'm not sure how to create a test case for this, or if that is even possible.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 15, 2025
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 15, 2025
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 15, 2025
…notriddle Add GUI test for rust-lang#135499 Fixes rust-lang#135510. cc `@lolbinarycat` r? `@notriddle`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#135497 (fix typo in typenames of pin documentation) - rust-lang#135522 (add incremental test for issue 135514) - rust-lang#135523 (const traits: remove some known-bug that do not seem to make sense) - rust-lang#135535 (Add GUI test for rust-lang#135499) - rust-lang#135541 (Methods of const traits are const) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 16, 2025
Rollup merge of rust-lang#135535 - GuillaumeGomez:gui-test-135499, r=notriddle Add GUI test for rust-lang#135499 Fixes rust-lang#135510. cc `@lolbinarycat` r? `@notriddle`
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#135497 (fix typo in typenames of pin documentation) - rust-lang#135522 (add incremental test for issue 135514) - rust-lang#135523 (const traits: remove some known-bug that do not seem to make sense) - rust-lang#135535 (Add GUI test for rust-lang#135499) - rust-lang#135541 (Methods of const traits are const) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #133484
i'm not sure how to create a test case for this, or if that is even possible.