-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target: Add mips mti baremetal support #135074
Conversation
Do the same thing as gcc, which use the vendor `mti` to mark the toolchain as MIPS32r2 default. We support both big endian and little endian flavor: mips-mti-none-elf mipsel-mti-none-elf
These commits modify compiler targets. Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
I noticed #134721. |
This comment has been minimized.
This comment has been minimized.
Who is maintaining the mips targets? |
It's me. I am also the MIPS maintainer of GCC/LLVM mips maintainer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is the new mipsel target different from mipsel-unknown-none and should the none target keep existing at all?
Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de>
Maybe we should remove We use the vendor If there is no objection, I will switch |
For |
@bors r+ rollup Let's land this and look at the unknown target(s?) In follow-ups. If they have no users we should probably just remove them instead of doing sth that no one is testing that it works |
☀️ Test successful - checks-actions |
Finished benchmarking commit (7270e73): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -3.2%, secondary -1.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -2.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 763.624s -> 763.064s (-0.07%) |
Do the same thing as gcc, which use the vendor
mti
to mark the toolchain as MIPS32r2 default.We support both big endian and little endian flavor:
mips-mti-none-elf
mipsel-mti-none-elf