Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused function params #135069

Merged
merged 1 commit into from
Jan 4, 2025
Merged

remove unused function params #135069

merged 1 commit into from
Jan 4, 2025

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2025

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

jieyouxu
jieyouxu approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me after PR CI is green.

@jieyouxu jieyouxu assigned jieyouxu and unassigned chenyukang Jan 3, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jan 3, 2025

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 3, 2025

📌 Commit e839d05 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 4, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2025
@bors
Auto merge of rust-lang#135095 - matthiaskrgr:rollup-tmgxckq, r=matth…
f17cf74 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#133964 (core: implement `bool::select_unpredictable`)
 - rust-lang#135001 (Allow using self-contained LLD in bootstrap)
 - rust-lang#135055 (Report impl method has stricter requirements even when RPITIT inference gets in the way)
 - rust-lang#135064 (const-in-pattern: test that the PartialEq impl does not need to be const)
 - rust-lang#135066 (bootstrap: support `./x check run-make-support`)
 - rust-lang#135069 (remove unused function params)
 - rust-lang#135084 (Update carrying_mul_add test to tolerate `nuw`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 725b799 into rust-lang:master Jan 4, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 4, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2025
@rust-timer
Unrolled build for rust-lang#135069
3a3067a 
Rollup merge of rust-lang#135069 - matthiaskrgr:param_rec_usage, r=jieyouxu

remove unused function params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
5 participants
@matthiaskrgr @rustbot @jieyouxu @bors @chenyukang