Don't ice on bad transmute in typeck in new solver #134744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
lcnr
reviewed
Jan 6, 2025
| @@ -46,7 +46,17 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { | |||
| let span = tcx.hir().span(hir_id); | |||
| let normalize = |ty| { | |||
| let ty = self.resolve_vars_if_possible(ty); | |||
| self.tcx.normalize_erasing_regions(self.typing_env(self.param_env), ty) | |||
| if let Ok(ty) = | |||
| self.tcx.try_normalize_erasing_regions(self.typing_env(self.param_env), ty) | |||
There was a problem hiding this comment.
hmm, we should prolly just move this out of HIR typeck into a separate query and then check whether the typeck results are tainted instead, especially as computing the layout uses reveal all anyways, so we get query cycles when revealing opaques.
can you add that as a fixme? after that r=me
compiler-errors
force-pushed
the
transmute-non-wf
branch
from
1677200 to
96285bd
Compare
|
@bors r=lcnr rollup |
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jan 7, 2025
…r=lcnr Don't ice on bad transmute in typeck in new solver Old trait solver ends up getting its infcx tainted because we try to normalize the type, but the new trait solver doesn't. This means we try to compute the stalled transmute obligations, which tries to normalize a type an ICEs. Let's make this a delayed bug. r? lcnr
This was referenced Jan 7, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 7, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#131830 (Add support for wasm exception handling to Emscripten target) - rust-lang#132345 (Improve diagnostics for `HostEffectPredicate` in the new solver) - rust-lang#134568 (Release notes for 1.84.0) - rust-lang#134744 (Don't ice on bad transmute in typeck in new solver) - rust-lang#135090 (Suggest to replace tuple constructor through projection) - rust-lang#135116 (rustdoc: Fix mismatched capitalization in sidebar) - rust-lang#135126 (mark deprecated option as deprecated in rustc_session to remove copypasta and small refactor) - rust-lang#135139 ([generic_assert] Constify methods used by the formatting system) - rust-lang#135170 (Update triagebot.toml: celinval vacation is over) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 7, 2025
Rollup merge of rust-lang#134744 - compiler-errors:transmute-non-wf, r=lcnr Don't ice on bad transmute in typeck in new solver Old trait solver ends up getting its infcx tainted because we try to normalize the type, but the new trait solver doesn't. This means we try to compute the stalled transmute obligations, which tries to normalize a type an ICEs. Let's make this a delayed bug. r? lcnr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old trait solver ends up getting its infcx tainted because we try to normalize the type, but the new trait solver doesn't. This means we try to compute the stalled transmute obligations, which tries to normalize a type an ICEs. Let's make this a delayed bug.
r? lcnr