-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use ubuntu 24
instead of latest
#134519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 19, 2024
@rustbot ready |
@bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 19, 2024
Should the large runners be included after #134433 merges? |
we don't use ubuntu-latest on large runners 👍 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#134366 (Fix logical error with what text is considered whitespace.) - rust-lang#134514 (Improve dependency_format a bit) - rust-lang#134519 (ci: use ubuntu `24` instead of `latest`) - rust-lang#134551 (coverage: Rename `basic_coverage_blocks` to just `graph`) - rust-lang#134553 (add member constraints comment) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#134366 (Fix logical error with what text is considered whitespace.) - rust-lang#134514 (Improve dependency_format a bit) - rust-lang#134519 (ci: use ubuntu `24` instead of `latest`) - rust-lang#134551 (coverage: Rename `basic_coverage_blocks` to just `graph`) - rust-lang#134553 (add member constraints comment) r? `@ghost` `@rustbot` modify labels: rollup
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Dec 20, 2024
…obzol ci: use ubuntu `24` instead of `latest`
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Dec 20, 2024
…obzol ci: use ubuntu `24` instead of `latest`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2024
Rollup merge of rust-lang#134519 - MarcoIeni:ubuntu-latest-to-24, r=Kobzol ci: use ubuntu `24` instead of `latest`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub is progressively migrating
ubuntu-latest
toubuntu-24
. See announcement here.Let's do this update intentionally without waiting for it to happen on a random day so that we can catch errors earlier. 👍
Personally, I'm not a fan of the
-latest
images because of this reason. So if you agree we should stop using them in this repo.