Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use ubuntu 24 instead of latest #134519

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

MarcoIeni
Copy link
Member

GitHub is progressively migrating ubuntu-latest to ubuntu-24. See announcement here.

Let's do this update intentionally without waiting for it to happen on a random day so that we can catch errors earlier. 👍

Personally, I'm not a fan of the -latest images because of this reason. So if you agree we should stop using them in this repo.

@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 19, 2024
@MarcoIeni
Copy link
Member Author

@rustbot ready

@MarcoIeni MarcoIeni marked this pull request as ready for review December 19, 2024 20:45
@Kobzol
Copy link
Contributor

Kobzol commented Dec 19, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Dec 19, 2024

📌 Commit b731c36 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2024
@tgross35
Copy link
Contributor

Should the large runners be included after #134433 merges?

@MarcoIeni
Copy link
Member Author

we don't use ubuntu-latest on large runners 👍

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
Rollup of 5 pull requests

Successful merges:

 - rust-lang#134366 (Fix logical error with what text is considered whitespace.)
 - rust-lang#134514 (Improve dependency_format a bit)
 - rust-lang#134519 (ci: use ubuntu `24` instead of `latest`)
 - rust-lang#134551 (coverage: Rename `basic_coverage_blocks` to just `graph`)
 - rust-lang#134553 (add member constraints comment)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
Rollup of 5 pull requests

Successful merges:

 - rust-lang#134366 (Fix logical error with what text is considered whitespace.)
 - rust-lang#134514 (Improve dependency_format a bit)
 - rust-lang#134519 (ci: use ubuntu `24` instead of `latest`)
 - rust-lang#134551 (coverage: Rename `basic_coverage_blocks` to just `graph`)
 - rust-lang#134553 (add member constraints comment)

r? `@ghost`
`@rustbot` modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 20, 2024
…obzol

ci: use ubuntu `24` instead of `latest`
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 20, 2024
…obzol

ci: use ubuntu `24` instead of `latest`
@bors bors merged commit d7f62bc into rust-lang:master Dec 20, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 20, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
Rollup merge of rust-lang#134519 - MarcoIeni:ubuntu-latest-to-24, r=Kobzol

ci: use ubuntu `24` instead of `latest`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants