Rename `rustc_mir_build::build` to `builder` #134365

Zalathar · 2024-12-16T02:18:16Z

GitHub's “Go to file” feature silently ignores all files in this module, presumably because they are in a directory named build, which is mistaken for a build-output directory. That makes it meaningfully harder to view those files and their history via GitHub.

This PR sidesteps that issue by renaming build to builder, which in context has basically the same meaning, but can't be mistaken for a build-output directory.

Extracted from #133404, after #133592 changed the .gitignore rule from build/ to /build. The problem of GitHub ignoring these files still exists even after that change, which suggests that GitHub's behaviour is a hard-coded heuristic that isn't influenced by the repository's git settings.

Currently this PR doesn't include the tidy rule forbidding build as a module name, but that could be added if people think it's a good idea.

rustbot · 2024-12-16T02:18:23Z

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

nnethercote · 2024-12-16T03:35:48Z

compiler/rustc_mir_build/src/lib.rs

@@ -11,7 +11,7 @@
 #![warn(unreachable_pub)]
 // tidy-alphabetical-end

-mod build;
+mod builder;


Please add a comment here, e.g. "This used to be called build, but that causes GitHub's “Go to file” feature to silently ignore all files in this module, presumably because they are in a directory named build, which is mistaken for a build-output directory."

r=me with that change.

Zalathar · 2024-12-16T04:30:19Z

@bors r=nnethercote

bors · 2024-12-16T04:30:22Z

📌 Commit 6af1afe has been approved by nnethercote

It is now in the queue for this repository.

jieyouxu · 2024-12-16T04:50:37Z

@Zalathar are u sure this is still a problem in github ui, as we changed gitignore from

build/

to

/build

It seems plausible that github has special handling for "build" named dirs, but I suspect that is from gitignore?

@bors r- (sorry one question)

r=@nnethercote again if this is still a problem.

Zalathar · 2024-12-16T04:59:06Z

@jieyouxu Yeah, it's still a problem even after #133592, which is why I think it's a hard-coded heuristic that doesn't depend on .gitignore.

(I edited the PR description to make this more clear.)

jieyouxu · 2024-12-16T05:19:18Z

Thanks, that is very funny.

@bors r=@nnethercote

bors · 2024-12-16T05:19:21Z

📌 Commit 6af1afe has been approved by nnethercote

It is now in the queue for this repository.

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#134314 (Make sure to use normalized ty for unevaluated const in default struct value) - rust-lang#134342 (crashes: more tests) - rust-lang#134357 (Fix `trimmed_def_paths` ICE in the function ptr comparison lint) - rust-lang#134369 (Update spelling of "referring") - rust-lang#134372 (Disable `tests/ui/associated-consts/issue-93775.rs` on windows msvc) Failed merges: - rust-lang#134365 (Rename `rustc_mir_build::build` to `builder`) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-12-16T11:59:22Z

☔ The latest upstream changes (presumably #134374) made this pull request unmergeable. Please resolve the merge conflicts.

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#134202 (Remove `rustc::existing_doc_keyword` lint) - rust-lang#134354 (Handle fndef rendering together with signature rendering) - rust-lang#134368 (Use links to edition guide for edition migrations) - rust-lang#134371 (Check for array lengths that aren't actually `usize`) - rust-lang#134378 (An octuple of polonius fact generation cleanups) Failed merges: - rust-lang#134365 (Rename `rustc_mir_build::build` to `builder`) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2024-12-16T14:09:59Z

Rebased to fix trivial conflict; no changes.

@bors r=nnethercote

bors · 2024-12-16T14:10:01Z

📌 Commit fb0f329 has been approved by nnethercote

It is now in the queue for this repository.

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#134202 (Remove `rustc::existing_doc_keyword` lint) - rust-lang#134354 (Handle fndef rendering together with signature rendering) - rust-lang#134368 (Use links to edition guide for edition migrations) - rust-lang#134371 (Check for array lengths that aren't actually `usize`) - rust-lang#134378 (An octuple of polonius fact generation cleanups) Failed merges: - rust-lang#134365 (Rename `rustc_mir_build::build` to `builder`) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-12-17T00:02:40Z

☔ The latest upstream changes (presumably #134395) made this pull request unmergeable. Please resolve the merge conflicts.

Zalathar · 2024-12-17T00:44:49Z

Rebased again.

@bors r=nnethercote

bors · 2024-12-17T00:44:52Z

📌 Commit c58219b has been approved by nnethercote

It is now in the queue for this repository.

Rename `rustc_mir_build::build` to `builder` GitHub's “Go to file” feature silently ignores all files in this module, presumably because they are in a directory named `build`, which is mistaken for a build-output directory. That makes it meaningfully harder to view those files and their history via GitHub. This PR sidesteps that issue by renaming `build` to `builder`, which in context has basically the same meaning, but can't be mistaken for a build-output directory. --- Extracted from rust-lang#133404, after rust-lang#133592 changed the .gitignore rule from `build/` to `/build`. The problem of GitHub ignoring these files still exists even after that change, which suggests that GitHub's behaviour is a hard-coded heuristic that isn't influenced by the repository's git settings. Currently this PR doesn't include the tidy rule forbidding `build` as a module name, but that could be added if people think it's a good idea.

Rollup of 9 pull requests Successful merges: - rust-lang#133265 (Add a range argument to vec.extract_if) - rust-lang#134202 (Remove `rustc::existing_doc_keyword` lint) - rust-lang#134354 (Handle fndef rendering together with signature rendering) - rust-lang#134365 (Rename `rustc_mir_build::build` to `builder`) - rust-lang#134368 (Use links to edition guide for edition migrations) - rust-lang#134388 (Update books) - rust-lang#134397 (rustc_borrowck: Suggest changing `&raw const` to `&raw mut` if applicable) - rust-lang#134398 (AIX: add alignment info for test) - rust-lang#134400 (Fix some comments related to upvars handling) Failed merges: - rust-lang#134399 (Do not do if ! else, use unnegated cond and swap the branches instead) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - rust-lang#134202 (Remove `rustc::existing_doc_keyword` lint) - rust-lang#134354 (Handle fndef rendering together with signature rendering) - rust-lang#134365 (Rename `rustc_mir_build::build` to `builder`) - rust-lang#134368 (Use links to edition guide for edition migrations) - rust-lang#134397 (rustc_borrowck: Suggest changing `&raw const` to `&raw mut` if applicable) - rust-lang#134398 (AIX: add alignment info for test) - rust-lang#134400 (Fix some comments related to upvars handling) - rust-lang#134406 (Fix `-Z input-stats` ordering) - rust-lang#134409 (bootstrap: fix a comment) - rust-lang#134412 (small borrowck cleanup) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#134365 - Zalathar:builder, r=nnethercote Rename `rustc_mir_build::build` to `builder` GitHub's “Go to file” feature silently ignores all files in this module, presumably because they are in a directory named `build`, which is mistaken for a build-output directory. That makes it meaningfully harder to view those files and their history via GitHub. This PR sidesteps that issue by renaming `build` to `builder`, which in context has basically the same meaning, but can't be mistaken for a build-output directory. --- Extracted from rust-lang#133404, after rust-lang#133592 changed the .gitignore rule from `build/` to `/build`. The problem of GitHub ignoring these files still exists even after that change, which suggests that GitHub's behaviour is a hard-coded heuristic that isn't influenced by the repository's git settings. Currently this PR doesn't include the tidy rule forbidding `build` as a module name, but that could be added if people think it's a good idea.

rustbot assigned cjgillot Dec 16, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 16, 2024

Zalathar mentioned this pull request Dec 16, 2024

Add a tidy rule forbidding modules named build #133404

Closed

nnethercote reviewed Dec 16, 2024

View reviewed changes

Zalathar assigned nnethercote and unassigned cjgillot Dec 16, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2024

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 16, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 16, 2024

matthiaskrgr mentioned this pull request Dec 16, 2024

Rollup of 5 pull requests #134374

Merged

matthiaskrgr mentioned this pull request Dec 16, 2024

Rollup of 5 pull requests #134380

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 16, 2024

Zalathar force-pushed the builder branch from 6af1afe to fb0f329 Compare December 16, 2024 14:06

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 16, 2024

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 17, 2024

Zalathar added 2 commits December 17, 2024 11:41

Rename rustc_mir_build::build to builder

bccbe70

Explain why build was renamed to builder

c58219b

Zalathar force-pushed the builder branch from fb0f329 to c58219b Compare December 17, 2024 00:44

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 17, 2024

jhpratt mentioned this pull request Dec 17, 2024

Rollup of 9 pull requests #134411

Closed

jhpratt mentioned this pull request Dec 17, 2024

Rollup of 10 pull requests #134414

Merged

bors merged commit 7e72c3e into rust-lang:master Dec 17, 2024
6 checks passed

rustbot added this to the 1.85.0 milestone Dec 17, 2024

Zalathar deleted the builder branch December 17, 2024 14:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename `rustc_mir_build::build` to `builder` #134365

Rename `rustc_mir_build::build` to `builder` #134365

Zalathar commented Dec 16, 2024 •

edited

Loading

rustbot commented Dec 16, 2024

nnethercote Dec 16, 2024

Zalathar commented Dec 16, 2024

bors commented Dec 16, 2024

jieyouxu commented Dec 16, 2024 •

edited

Loading

Zalathar commented Dec 16, 2024

jieyouxu commented Dec 16, 2024

bors commented Dec 16, 2024

bors commented Dec 16, 2024

Zalathar commented Dec 16, 2024

bors commented Dec 16, 2024

bors commented Dec 17, 2024

Zalathar commented Dec 17, 2024

bors commented Dec 17, 2024

Rename rustc_mir_build::build to builder #134365

Rename rustc_mir_build::build to builder #134365

Conversation

Zalathar commented Dec 16, 2024 • edited Loading

rustbot commented Dec 16, 2024

nnethercote Dec 16, 2024

Choose a reason for hiding this comment

Zalathar commented Dec 16, 2024

bors commented Dec 16, 2024

jieyouxu commented Dec 16, 2024 • edited Loading

Zalathar commented Dec 16, 2024

jieyouxu commented Dec 16, 2024

bors commented Dec 16, 2024

bors commented Dec 16, 2024

Zalathar commented Dec 16, 2024

bors commented Dec 16, 2024

bors commented Dec 17, 2024

Zalathar commented Dec 17, 2024

bors commented Dec 17, 2024

Rename `rustc_mir_build::build` to `builder` #134365

Rename `rustc_mir_build::build` to `builder` #134365

Zalathar commented Dec 16, 2024 •

edited

Loading

jieyouxu commented Dec 16, 2024 •

edited

Loading