Pass TyCtxt to early diagostics decoration
#134339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
jieyouxu
requested changes
Dec 15, 2024
rustbot
added
S-waiting-on-author
Urgau
force-pushed
the
tcx-in-early-diag
branch
from
51263a3 to
291c519
Compare
rustbot
added
S-waiting-on-review
jieyouxu
approved these changes
Dec 15, 2024
|
@bors r=jieyouxu rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 15, 2024
Rollup of 4 pull requests Successful merges: - rust-lang#134111 (Fix `--nocapture` for run-make tests) - rust-lang#134329 (Add m68k_target_feature) - rust-lang#134331 (bootstrap: make ./x test error-index work) - rust-lang#134339 (Pass `TyCtxt` to early diagostics decoration) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 15, 2024
Rollup merge of rust-lang#134339 - Urgau:tcx-in-early-diag, r=jieyouxu Pass `TyCtxt` to early diagostics decoration This PR pass a `TyCtxt` to the early diagnostics decoration code so that diagnostics code that take advantage of (a very limited but still useful) `TyCtxt` in their note, help, suggestions, ... This is particulary useful for rust-lang#133221 which wants to get the crate name of a `DefId`, which is possible with `tcx.crate_name(...)`. I highly recommend reviewing this PR commit by commit. r? `@jieyouxu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pass a
TyCtxtto the early diagnostics decoration code so that diagnostics code that take advantage of (a very limited but still useful)TyCtxtin their note, help, suggestions, ...This is particulary useful for #133221 which wants to get the crate name of a
DefId, which is possible withtcx.crate_name(...).I highly recommend reviewing this PR commit by commit.
r? @jieyouxu