Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Fuchsia #134188

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Bump Fuchsia #134188

merged 1 commit into from
Dec 12, 2024

Conversation

steven807
Copy link
Contributor

try-job: x86_64-fuchsia

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 12, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2024

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

@erickt
Copy link
Contributor

erickt commented Dec 12, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 12, 2024
@bors
Auto merge of rust-lang#134188 - steven807:master, r=<try>
3b3f841 
Bump Fuchsia

try-job: x86_64-fuchsia
@bors
Copy link
Contributor

bors commented Dec 12, 2024

⌛ Trying commit f39e813 with merge 3b3f841...

@bors
Copy link
Contributor

bors commented Dec 12, 2024

☀️ Try build successful - checks-actions
Build commit: 3b3f841 (3b3f84167ee5e16a6bbbe54f12d4d7465d812e8c)

@lqd
Copy link
Member

lqd commented Dec 12, 2024

The try build passed, so this should be safe to rollup.

r? lqd @bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 12, 2024

📌 Commit f39e813 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 12, 2024
@lqd lqd removed the has-merge-commits PR has merge commits, merge with caution. label Dec 12, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 12, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 12, 2024
@bors
Auto merge of rust-lang#134223 - matthiaskrgr:rollup-qy69vqb, r=matth…
d4025ee 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#133122 (Add unpolished, experimental support for AFIDT (async fn in dyn trait))
 - rust-lang#133249 (ABI checks: add support for loongarch)
 - rust-lang#134089 (Use newly added exceptions to non default branch warning)
 - rust-lang#134188 (Bump Fuchsia)
 - rust-lang#134204 (Fix our `llvm::Bool` typedef to be signed, to match `LLVMBool`)
 - rust-lang#134207 (Revert "bootstrap: print{ln}! -> eprint{ln}! (take 2) rust-lang#134040")
 - rust-lang#134214 (rustdoc: fix self cmp)

r? `@ghost`
`@rustbot` modify labels: rollup
@lqd lqd mentioned this pull request Dec 12, 2024
Closed
@bors bors merged commit f620e46 into rust-lang:master Dec 12, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 12, 2024
@rust-timer
Unrolled build for rust-lang#134188
616ebf7 
Rollup merge of rust-lang#134188 - steven807:master, r=lqd

Bump Fuchsia

try-job: x86_64-fuchsia
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickt erickt erickt approved these changes

Assignees

@lqd lqd

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
6 participants
@steven807 @rustbot @erickt @bors @lqd @Mark-Simulacrum