Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove static HashSet for default IDs list #133745

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Remove static HashSet for default IDs list #133745

merged 1 commit into from
Dec 2, 2024

Conversation

GuillaumeGomez
Copy link
Member

Follow-up of #133345.

Let's see how it impacts performance.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 2, 2024
@GuillaumeGomez
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 2, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2024
@bors
Auto merge of rust-lang#133745 - GuillaumeGomez:default-ids-match, r=…
a62dcf1 
…<try>

Remove static HashSet for default IDs list

Follow-up of rust-lang#133345.

Let's see how it impacts performance.

r? `@notriddle`
@bors
Copy link
Contributor

bors commented Dec 2, 2024

⌛ Trying commit b863c0d with merge a62dcf1...

@Kobzol
Copy link
Contributor

Kobzol commented Dec 2, 2024

Nooo, my beautiful optimization, I was so proud of it 😆 Seriously though, quite interested in whether the hashmap lookup can still beat a linear match scan!

@GuillaumeGomez
Copy link
Member Author

I'm very curious about it too! :)

@bors
Copy link
Contributor

bors commented Dec 2, 2024

☀️ Try build successful - checks-actions
Build commit: a62dcf1 (a62dcf15416992482c8f86b49bbc0ba4b6367592)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a62dcf1): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.8%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)		 -1.8% [-1.8%, -1.8%] 1
Improvements ✅
(secondary)		 -4.3% [-4.6%, -4.1%] 2
All ❌✅ (primary) -1.8% [-1.8%, -1.8%] 1

Cycles

Results (secondary -1.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.6% [-1.6%, -1.6%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 768.592s -> 769.381s (0.10%)
Artifact size: 332.14 MiB -> 332.15 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 2, 2024
@notriddle
Copy link
Contributor

Doesn't seem to matter at all?

@GuillaumeGomez
Copy link
Member Author

Oh well. At least the code is simpler now.

@Kobzol
Copy link
Contributor

Kobzol commented Dec 2, 2024

Yeah, this is a nice cleanup.

@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 2, 2024

📌 Commit b863c0d has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 2, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2024
@bors
Auto merge of rust-lang#133760 - GuillaumeGomez:rollup-2c1y8c3, r=Gui…
d49be02 
…llaumeGomez

Rollup of 13 pull requests

Successful merges:

 - rust-lang#133603 (Eliminate magic numbers from expression precedence)
 - rust-lang#133715 (rustdoc-json: Include safety of `static`s)
 - rust-lang#133721 (rustdoc-json: Add test for `impl Trait for dyn Trait`)
 - rust-lang#133725 (Remove `//@ compare-output-lines-by-subset`)
 - rust-lang#133730 (Add pretty-printer parenthesis insertion test)
 - rust-lang#133736 (Add `needs-target-has-atomic` directive)
 - rust-lang#133739 (Re-add myself to rotation)
 - rust-lang#133743 (Fix docs for `<[T]>::as_array`.)
 - rust-lang#133744 (Fix typo README.md)
 - rust-lang#133745 (Remove static HashSet for default IDs list)
 - rust-lang#133749 (mir validator: don't store mir phase)
 - rust-lang#133751 (remove `Ty::is_copy_modulo_regions`)
 - rust-lang#133757 (`impl Default for EarlyDiagCtxt`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7145e4e into rust-lang:master Dec 2, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 2, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2024
@rust-timer
Unrolled build for rust-lang#133745
b8371c8 
Rollup merge of rust-lang#133745 - GuillaumeGomez:default-ids-match, r=notriddle

Remove static HashSet for default IDs list

Follow-up of rust-lang#133345.

Let's see how it impacts performance.

r? `@notriddle`
@GuillaumeGomez GuillaumeGomez deleted the default-ids-match branch December 2, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @rust-timer @bors @Kobzol @notriddle @rustbot