-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add submodule for document translation #133562
Conversation
|
This comment has been minimized.
This comment has been minimized.
0f772fa
to
3b4f2a5
Compare
This comment has been minimized.
This comment has been minimized.
3b4f2a5
to
f814728
Compare
This comment has been minimized.
This comment has been minimized.
5b172f4
to
38ab498
Compare
38ab498
to
1458b74
Compare
☔ The latest upstream changes (presumably #133950) made this pull request unmergeable. Please resolve the merge conflicts. |
@ehuss Hi, Could you give me any comment about this PR? Especially I want a comment whether the main idea of this PR ( adding translation submodule ) is acceptable. If it is acceptable, I'll work to improve techincal detail. If not, I'll consider another idea. |
Hi @dalance! Sorry for the delay. Unfortunately I don't think this is something we can support at this time. I don't think the project currently has the capacity to manage something like this. I would like to see us get to that point at some time, though! |
Thank you for your response! |
@ehuss |
I found rust-lang/leadership-council#123. |
Thanks @dalance for your interest and enthusiasm here, and for being responsive to the feedback. In reading through this and the linked issues, here's how I'd break down the questions:
People here have, I think, reservations about the first two of these. That is, it's just not clear that there's a sufficiently large and active community of people with the right skills and interest in the Rust project to make this maintainable, and this is an area where we've struggled in the past. On the third item, this runs into trouble at a meta level, which is that it takes a lot of work to answer this question. This would require seeking and receiving input from many busy people, and for that work to make sense -- for it to be prioritized over other important work -- we'd need a lot of confidence about the first two points. I know this is a dissatisfying answer and doesn't really leave a clear path forward for this. We all kind of feel bad about that, because obviously you're willing to put in work here and, all else being equal, we'd prefer to support that. And in an ideal world, we'd of course love to have comprehensive and continuously up-to-date translations of everything we produce. So, anyway, we're going to close this as it doesn't have any path forward for being accepted at the moment, and it's better for us to be straightforward about that. In discussion, we were curious though about the source of your interest in this work. Maybe you could tell us more about what has inspired and supported your interest in seeing these books translated. It's not going to change the outcome in this case, but it may help inform how we think about this in the future. |
@traviscross
I'm a maintainer of Rust By Example Japanese translation, and interersting in sustainability of translation. In the process, I found some problems around document translation, for example, translation support of mdbook get stuck, there are many disjointed translation works of TRPL. |
This PR adds a submodule for document translation.
Motivation
Now translation DBs are placed at the each document repositories (e.g. rust-by-example).
This causes to increse merging cost of translation update by document maintainers.
Instead of it, the merging cost can be reduced by splitting the translation DBs to another submodule.
I tried to gather feedback about this idea through Internal Forum and Zulip, and I create this PR because there was no feedback.
https://internals.rust-lang.org/t/pre-rfc-translation-sub-repository-for-rust-docs/21666
Summary of this PR
This PR adds the following steps to bootstrap build of doc.
po-dir
to specify the translation DB in the translation submodule.TODO
This PR is incomplete yet.
If this is acceptable, I think the following items should be done before merging this PR.
index.hbs
from rust-by-example ( because it conflicts with this PR )src/bootstrap/src/core/build_steps/doc.rs
and add a mechanism to refer the entries from the translation submodule