Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIX: add run-make support #132657

Merged
merged 3 commits into from
Nov 12, 2024
Merged

AIX: add run-make support #132657

merged 3 commits into from
Nov 12, 2024

Conversation

mustartt
Copy link
Contributor

@mustartt mustartt commented Nov 5, 2024

On AIX, we are required explicit link against c++ and c++abi to support running the run-make test suite.

@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jieyouxu (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 5, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2024

The run-make-support library was changed

cc @jieyouxu

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@mustartt
Copy link
Contributor Author

mustartt commented Nov 5, 2024

@daltenty fyi

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@mustartt mustartt marked this pull request as draft November 5, 2024 19:01
@jieyouxu
Copy link
Member

jieyouxu commented Nov 8, 2024

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2024
@mustartt
Copy link
Contributor Author

Instead of vec![] add the args directly.

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 11, 2024
@mustartt mustartt marked this pull request as ready for review November 11, 2024 04:51
@mustartt mustartt requested a review from daltenty November 11, 2024 04:51
jieyouxu
jieyouxu approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 11, 2024

📌 Commit 405017a has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 12, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 12, 2024
@bors
Auto merge of rust-lang#132954 - matthiaskrgr:rollup-x3rww9h, r=matth…
f7273e0 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#131831 (extend the "if-unchanged" logic for compiler builds)
 - rust-lang#132541 (Proper support for cross-crate recursive const stability checks)
 - rust-lang#132657 (AIX: add run-make support)
 - rust-lang#132901 (Warn about invalid `mir-enable-passes` pass names)
 - rust-lang#132923 (Triagebot: Consolidate the T-compiler ad hoc assignment groups)
 - rust-lang#132938 (Make precise capturing suggestion machine-applicable only if it has no APITs)
 - rust-lang#132947 (clarify `must_produce_diag` ICE for debugging)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8f67b5b into rust-lang:master Nov 12, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 12, 2024
@rust-timer
Unrolled build for rust-lang#132657
1a6d2a3 
Rollup merge of rust-lang#132657 - mustartt:aix-run-make-support, r=jieyouxu

AIX: add run-make support

On AIX, we are required explicit link against `c++` and `c++abi` to support running the run-make test suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

@daltenty daltenty Awaiting requested review from daltenty

Assignees

@jieyouxu jieyouxu

Labels
A-compiletest Area: The compiletest test runner A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mustartt @rustbot @rust-log-analyzer @jieyouxu @bors @daltenty