Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core/fmt] Replace checked slice indexing by unchecked to support panic-free code #132473

Merged
merged 3 commits into from
Nov 5, 2024
Merged

[core/fmt] Replace checked slice indexing by unchecked to support panic-free code #132473

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02a1ab8
Replace checked slice indexing by unchecked to support panic-free code
Nov 1, 2024
37f48da
Updated SAFETY comment to address underflow
Nov 4, 2024
65d8f1b
Fixed typo, rebased
Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion library/core/src/fmt/num.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@ unsafe trait GenericRadix: Sized {
};
}
}
let buf = &buf[curr..];
// SAFETY: `curr` is initialized to `buf.len()` and is only decremented, so it can't overflow. It is
// decremented exactly once for each digit. Since u128 is the widest fixed width integer format supported,
// the maximum number of digits (bits) is 128 for base-2, so `curr` won't underflow as well.
let buf = unsafe { buf.get_unchecked(curr..) };
// SAFETY: The only chars in `buf` are created by `Self::digit` which are assumed to be
// valid UTF-8
let buf = unsafe {
Expand Down
Loading