Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace an FTP link in comments with an equivalent HTTPS link #132096

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Replace an FTP link in comments with an equivalent HTTPS link #132096

merged 1 commit into from
Oct 24, 2024

Conversation

Zalathar
Copy link
Contributor

Modern browsers and editors often don't support following FTP links, so using an ordinary web link gives the same result in a more convenient way.

@rustbot
Copy link
Collaborator

rustbot commented Oct 24, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 24, 2024
@jieyouxu
Copy link
Member

Huh. Thanks. @bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 24, 2024

📌 Commit 3dfc352 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 24, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 24, 2024
@bors
Auto merge of rust-lang#132099 - matthiaskrgr:rollup-myi94r8, r=matth…
5ae4d75 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#129248 (Taking a raw ref (`&raw (const|mut)`) of a deref of pointer (`*ptr`) is always safe)
 - rust-lang#131906 (rustdoc: adjust spacing and typography in header)
 - rust-lang#132084 (Consider param-env candidates even if they have errors)
 - rust-lang#132096 (Replace an FTP link in comments with an equivalent HTTPS link)
 - rust-lang#132098 (rustc_feature::Features: explain what that 'Option<Symbol>' is about)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 35ebcec into rust-lang:master Oct 24, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 24, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 24, 2024
@rust-timer
Unrolled build for rust-lang#132096
7f39e5a 
Rollup merge of rust-lang#132096 - Zalathar:ftp-link, r=jieyouxu

Replace an FTP link in comments with an equivalent HTTPS link

Modern browsers and editors often don't support following FTP links, so using an ordinary web link gives the same result in a more convenient way.
@Zalathar Zalathar deleted the ftp-link branch October 24, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Zalathar @rustbot @jieyouxu @bors