Rollup of 8 pull requests #131690

matthiaskrgr · 2024-10-14T15:06:40Z

Successful merges:

Stabilize Pin::as_deref_mut() #129424 (Stabilize Pin::as_deref_mut())
Fix clobber_abi and disallow SVE-related registers in Arm64EC inline assembly #131332 (Fix clobber_abi and disallow SVE-related registers in Arm64EC inline assembly)
Update precondition tests (especially for zero-size access to null) #131384 (Update precondition tests (especially for zero-size access to null))
Special treatment empty tuple when suggest adding a string literal in format macro. #131430 (Special treatment empty tuple when suggest adding a string literal in format macro.)
Make some tweaks to extern block diagnostics #131550 (Make some tweaks to extern block diagnostics)
Fix AArch64InlineAsmReg::emit #131667 (Fix AArch64InlineAsmReg::emit)
compiletest: Document various parts of compiletest's lib.rs #131679 (compiletest: Document various parts of compiletest's lib.rs)
Tag PRs affecting compiletest with A-compiletest #131682 (Tag PRs affecting compiletest with A-compiletest)

Failed merges:

Stabilise const_make_ascii. #131496 (Stabilise const_make_ascii.)

r? @ghost
@rustbot modify labels: rollup

…assembly

… format macro. For example: ```rust let s = "123"; println!({}, "sss", s); ``` Suggest: `println!("{:?} {} {}", {}, "sss", s);` fixes rust-lang#130170

…f_mut, r=dtolnay Stabilize `Pin::as_deref_mut()` Tracking issue: closes rust-lang#86918 Stabilizing the following API: ```rust impl<Ptr: DerefMut> Pin<Ptr> { pub fn as_deref_mut(self: Pin<&mut Pin<Ptr>>) -> Pin<&mut Ptr::Target>; } ``` I know that an FCP has not been started yet, but this isn't a very complex stabilization, and I'm hoping this can motivate an FCP to *get* started - this has been pending for a while and it's a very useful function when writing Future impls. r? ``@jonhoo``

…nieu Fix clobber_abi and disallow SVE-related registers in Arm64EC inline assembly Currently `clobber_abi` in Arm64EC inline assembly is implemented using `InlineAsmClobberAbi::AArch64NoX18`, but broken since it attempts to clobber registers that cannot be used in Arm64EC: https://godbolt.org/z/r3PTrGz5r ``` error: cannot use register `x13`: x13, x14, x23, x24, x28, v16-v31 cannot be used for Arm64EC --> <source>:6:14 | 6 | asm!("", clobber_abi("C"), options(nostack, nomem, preserves_flags)); | ^^^^^^^^^^^^^^^^ error: cannot use register `x14`: x13, x14, x23, x24, x28, v16-v31 cannot be used for Arm64EC --> <source>:6:14 | 6 | asm!("", clobber_abi("C"), options(nostack, nomem, preserves_flags)); | ^^^^^^^^^^^^^^^^ <omitted the same errors for v16-v31> ``` Additionally, this disallows SVE-related registers per rust-lang#131332 (comment). cc ``@dpaoliello`` r? ``@Amanieu`` ``@rustbot`` label O-windows O-AArch64 +A-inline-assembly

…aheemdev Update precondition tests (especially for zero-size access to null) I don't much like the current way I've updated the precondition check helpers, but I couldn't come up with anything better. Ideas welcome. I've organized `tests/ui/precondition-checks` mostly with one file per function that has `assert_unsafe_precondition` in it, with revisions that check each precondition. The important new test is `tests/ui/precondition-checks/zero-size-null.rs`.

Special treatment empty tuple when suggest adding a string literal in format macro. For example: ```rust let s = "123"; println!({}, "sss", s); ``` Suggest: `println!("{:?} {} {}", {}, "sss", s);` fixes rust-lang#130170

…astorino Make some tweaks to extern block diagnostics Self-explanatory. See the diagnostic changes; I hope they make them a bit more descriptive. r? spastorino

…t, r=Amanieu Fix AArch64InlineAsmReg::emit Currently, this method uses `self as u32 - Self::x0 as u32` to get register index: https://github.com/rust-lang/rust/blob/36780360b62320a61e2234b17ec600e8e4785509/compiler/rustc_target/src/asm/aarch64.rs#L204 However, this is incorrect for reasons explained in the following comment: https://github.com/rust-lang/rust/blob/36780360b62320a61e2234b17ec600e8e4785509/compiler/rustc_codegen_llvm/src/asm.rs#L544-L549 r? ``@Amanieu`` ``@rustbot`` label O-AArch64 +A-inline-assembly

compiletest: Document various parts of compiletest's `lib.rs` This adds some much-needed comments to many of the items in compiletest's `lib.rs`, giving a better overview of how a compiletest invocation actually proceeds. To make review easier I have refrained from renames or functional changes, though I couldn't resist getting rid of one obviously-redundant `Arc::clone` in `make_test_closure`.

…thar Tag PRs affecting compiletest with `A-compiletest`

matthiaskrgr · 2024-10-14T15:07:13Z

@bors r+ rollup=never p=9

bors · 2024-10-14T15:07:16Z

📌 Commit ac9b212 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-10-14T15:09:15Z

⌛ Testing commit ac9b212 with merge 1d45b2d...

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#129424 (Stabilize `Pin::as_deref_mut()`) - rust-lang#131332 (Fix clobber_abi and disallow SVE-related registers in Arm64EC inline assembly) - rust-lang#131384 (Update precondition tests (especially for zero-size access to null)) - rust-lang#131430 (Special treatment empty tuple when suggest adding a string literal in format macro.) - rust-lang#131550 (Make some tweaks to extern block diagnostics) - rust-lang#131667 (Fix AArch64InlineAsmReg::emit) - rust-lang#131679 (compiletest: Document various parts of compiletest's `lib.rs`) - rust-lang#131682 (Tag PRs affecting compiletest with `A-compiletest`) Failed merges: - rust-lang#131496 (Stabilise `const_make_ascii`.) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-10-14T15:11:48Z

💔 Test failed - checks-actions

matthiaskrgr · 2024-10-14T15:12:41Z

@bors treeclosed=1000 Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading

rust-log-analyzer · 2024-10-14T15:13:52Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#4 [auth] library/ubuntu:pull token for registry-1.docker.io
#4 DONE 0.0s

#3 [internal] load metadata for docker.io/library/ubuntu:22.04
#3 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:58b87898e82351c6cf9cf5b9f3c20257bb9e2dcf33af051e12ce532d7f94e3fe: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
 > [internal] load metadata for docker.io/library/ubuntu:22.04:
------
Dockerfile:1
--------------------
--------------------
   1 | >>> FROM ubuntu:22.04
   2 |     
   3 |     ARG DEBIAN_FRONTEND=noninteractive
--------------------
ERROR: failed to solve: ubuntu:22.04: failed to resolve source metadata for docker.io/library/ubuntu:22.04: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:58b87898e82351c6cf9cf5b9f3c20257bb9e2dcf33af051e12ce532d7f94e3fe: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
#0 building with "boring_nobel" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 3.32kB done
#1 transferring dockerfile: 3.32kB done
#1 DONE 0.0s

#2 [internal] load metadata for docker.io/library/ubuntu:22.04
#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:58b87898e82351c6cf9cf5b9f3c20257bb9e2dcf33af051e12ce532d7f94e3fe: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
 > [internal] load metadata for docker.io/library/ubuntu:22.04:
------
Dockerfile:1
--------------------
--------------------
   1 | >>> FROM ubuntu:22.04
   2 |     
   3 |     ARG DEBIAN_FRONTEND=noninteractive
--------------------
ERROR: failed to solve: ubuntu:22.04: failed to resolve source metadata for docker.io/library/ubuntu:22.04: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:58b87898e82351c6cf9cf5b9f3c20257bb9e2dcf33af051e12ce532d7f94e3fe: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
#0 building with "boring_nobel" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 3.32kB done
#1 transferring dockerfile: 3.32kB done
#1 DONE 0.0s

#2 [internal] load metadata for docker.io/library/ubuntu:22.04
#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:58b87898e82351c6cf9cf5b9f3c20257bb9e2dcf33af051e12ce532d7f94e3fe: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
 > [internal] load metadata for docker.io/library/ubuntu:22.04:
------
Dockerfile:1
--------------------
--------------------
   1 | >>> FROM ubuntu:22.04
   2 |     
   3 |     ARG DEBIAN_FRONTEND=noninteractive
--------------------
ERROR: failed to solve: ubuntu:22.04: failed to resolve source metadata for docker.io/library/ubuntu:22.04: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:58b87898e82351c6cf9cf5b9f3c20257bb9e2dcf33af051e12ce532d7f94e3fe: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
#0 building with "boring_nobel" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 3.32kB done
#1 transferring dockerfile: 3.32kB done
#1 DONE 0.0s

#2 [internal] load metadata for docker.io/library/ubuntu:22.04
#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:58b87898e82351c6cf9cf5b9f3c20257bb9e2dcf33af051e12ce532d7f94e3fe: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
 > [internal] load metadata for docker.io/library/ubuntu:22.04:
------
Dockerfile:1
--------------------
--------------------
   1 | >>> FROM ubuntu:22.04
   2 |     
   3 |     ARG DEBIAN_FRONTEND=noninteractive
--------------------
ERROR: failed to solve: ubuntu:22.04: failed to resolve source metadata for docker.io/library/ubuntu:22.04: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:58b87898e82351c6cf9cf5b9f3c20257bb9e2dcf33af051e12ce532d7f94e3fe: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
#0 building with "boring_nobel" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 3.32kB done
#1 transferring dockerfile: 3.32kB done
#1 DONE 0.0s

#2 [internal] load metadata for docker.io/library/ubuntu:22.04
#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:58b87898e82351c6cf9cf5b9f3c20257bb9e2dcf33af051e12ce532d7f94e3fe: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
 > [internal] load metadata for docker.io/library/ubuntu:22.04:
------
Dockerfile:1
--------------------
--------------------
   1 | >>> FROM ubuntu:22.04
   2 |     
   3 |     ARG DEBIAN_FRONTEND=noninteractive
--------------------
ERROR: failed to solve: ubuntu:22.04: failed to resolve source metadata for docker.io/library/ubuntu:22.04: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/ubuntu/manifests/sha256:58b87898e82351c6cf9cf5b9f3c20257bb9e2dcf33af051e12ce532d7f94e3fe: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
##[error]Process completed with exit code 1.
Post job cleanup.

matthiaskrgr · 2024-10-14T15:15:35Z

@bors r+ rollup=never p=9

bors · 2024-10-14T15:15:38Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: [DO NOT MERGE] Why is enzyme frontend PR failing in post-opt-dist crashes test #131685

bors · 2024-10-14T15:15:38Z

📌 Commit ac9b212 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-10-14T15:15:39Z

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

rust-log-analyzer · 2024-10-14T15:20:35Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#4 [auth] library/centos:pull token for registry-1.docker.io
#4 DONE 0.0s

#3 [internal] load metadata for docker.io/library/centos:7
#3 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/centos/manifests/sha256:be65f488b7764ad3638f236b7b515b3678369a5124c47b8d32916d6487418ea4: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
 > [internal] load metadata for docker.io/library/centos:7:
------
Dockerfile:5
--------------------
--------------------
   3 |     # actually use newer APIs in rustc or std without a fallback. It's more
   4 |     # important that we match glibc for ELF symbol versioning.
   5 | >>> FROM centos:7
   6 |     
   7 |     WORKDIR /build
--------------------
ERROR: failed to solve: centos:7: failed to resolve source metadata for docker.io/library/centos:7: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/centos/manifests/sha256:be65f488b7764ad3638f236b7b515b3678369a5124c47b8d32916d6487418ea4: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit (did you mean centos?)
#0 building with "hopeful_bhabha" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 3.22kB done
#1 transferring dockerfile: 3.22kB done
#1 DONE 0.0s

#2 [internal] load metadata for docker.io/library/centos:7
#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/centos/manifests/sha256:be65f488b7764ad3638f236b7b515b3678369a5124c47b8d32916d6487418ea4: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
 > [internal] load metadata for docker.io/library/centos:7:
------
Dockerfile:5
--------------------
--------------------
   3 |     # actually use newer APIs in rustc or std without a fallback. It's more
   4 |     # important that we match glibc for ELF symbol versioning.
   5 | >>> FROM centos:7
   6 |     
   7 |     WORKDIR /build
--------------------
ERROR: failed to solve: centos:7: failed to resolve source metadata for docker.io/library/centos:7: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/centos/manifests/sha256:be65f488b7764ad3638f236b7b515b3678369a5124c47b8d32916d6487418ea4: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit (did you mean centos?)
#0 building with "hopeful_bhabha" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 3.22kB done
#1 transferring dockerfile: 3.22kB done
#1 DONE 0.0s

#2 [internal] load metadata for docker.io/library/centos:7
#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/centos/manifests/sha256:be65f488b7764ad3638f236b7b515b3678369a5124c47b8d32916d6487418ea4: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
 > [internal] load metadata for docker.io/library/centos:7:
------
Dockerfile:5
--------------------
--------------------
   3 |     # actually use newer APIs in rustc or std without a fallback. It's more
   4 |     # important that we match glibc for ELF symbol versioning.
   5 | >>> FROM centos:7
   6 |     
   7 |     WORKDIR /build
--------------------
ERROR: failed to solve: centos:7: failed to resolve source metadata for docker.io/library/centos:7: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/centos/manifests/sha256:be65f488b7764ad3638f236b7b515b3678369a5124c47b8d32916d6487418ea4: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit (did you mean centos?)
#0 building with "hopeful_bhabha" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 3.22kB done
#1 transferring dockerfile: 3.22kB done
#1 DONE 0.0s

#2 [internal] load metadata for docker.io/library/centos:7
#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/centos/manifests/sha256:be65f488b7764ad3638f236b7b515b3678369a5124c47b8d32916d6487418ea4: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
 > [internal] load metadata for docker.io/library/centos:7:
------
Dockerfile:5
--------------------
--------------------
   3 |     # actually use newer APIs in rustc or std without a fallback. It's more
   4 |     # important that we match glibc for ELF symbol versioning.
   5 | >>> FROM centos:7
   6 |     
   7 |     WORKDIR /build
--------------------
ERROR: failed to solve: centos:7: failed to resolve source metadata for docker.io/library/centos:7: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/centos/manifests/sha256:be65f488b7764ad3638f236b7b515b3678369a5124c47b8d32916d6487418ea4: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit (did you mean centos?)
#0 building with "hopeful_bhabha" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 3.22kB done
#1 transferring dockerfile: 3.22kB done
#1 DONE 0.0s

#2 [internal] load metadata for docker.io/library/centos:7
#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/centos/manifests/sha256:be65f488b7764ad3638f236b7b515b3678369a5124c47b8d32916d6487418ea4: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
 > [internal] load metadata for docker.io/library/centos:7:
------
Dockerfile:5
--------------------
--------------------
   3 |     # actually use newer APIs in rustc or std without a fallback. It's more
   4 |     # important that we match glibc for ELF symbol versioning.
   5 | >>> FROM centos:7
   6 |     
   7 |     WORKDIR /build
--------------------
ERROR: failed to solve: centos:7: failed to resolve source metadata for docker.io/library/centos:7: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/centos/manifests/sha256:be65f488b7764ad3638f236b7b515b3678369a5124c47b8d32916d6487418ea4: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit (did you mean centos?)
##[error]Process completed with exit code 1.
Post job cleanup.

matthiaskrgr · 2024-10-14T16:37:34Z

@bors p=1010

bors · 2024-10-14T16:38:43Z

⌛ Testing commit ac9b212 with merge 9322d18...

matthiaskrgr · 2024-10-14T16:58:42Z

@bors treeclosed-

bors · 2024-10-14T19:24:08Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 9322d18 to master...

rust-timer · 2024-10-14T19:26:23Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#129424	Stabilize `Pin::as_deref_mut()`	`a988f8011c9e1ecad9afb03cb7b17badd07f85fb` (link)
#131332	Fix clobber_abi and disallow SVE-related registers in Arm64…	`8b6d641cf0cab52e77672f7797301e88d6e7f723` (link)
#131384	Update precondition tests (especially for zero-size access …	`0560c6a7d5a113866db501cf430e4c0f34f4afff` (link)
#131430	Special treatment empty tuple when suggest adding a string …	`ba46fc13898e8214eb6beccd573fc2808be79839` (link)
#131550	Make some tweaks to extern block diagnostics	`b284fb94785657cf142ee88dfbcd7d74d5df7212` (link)
#131667	Fix AArch64InlineAsmReg::emit	`dd6dc1b8e0fb73e8ca8eca0a9dbe6628b6fb0b84` (link)
#131679	compiletest: Document various parts of compiletest's `lib.r…	`08d3f07481e08d87bdc25115457d003e1c2fb58d` (link)
#131682	Tag PRs affecting compiletest with `A-compiletest`	`2d701f858d103ab27c22aa75d2fb951a2ac4e42e` (link)

previous master: 17a19e684c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-10-14T22:06:07Z

Finished benchmarking commit (9322d18): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.8%, -0.3%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	[-0.8%, 0.4%]	3

Max RSS (memory usage)

Results (primary 6.5%, secondary 2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	9.5%	[3.6%, 12.9%]	3
Regressions ❌ (secondary)	2.7%	[2.7%, 2.8%]	2
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	6.5%	[-2.4%, 12.9%]	4

Cycles

Results (primary -0.6%, secondary -2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	1
Improvements ✅ (secondary)	-2.1%	[-2.4%, -2.0%]	3
All ❌✅ (primary)	-0.6%	[-0.6%, -0.6%]	1

Binary size

Results (primary 0.0%, secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.3%]	39
Regressions ❌ (secondary)	0.1%	[0.0%, 0.4%]	13
Improvements ✅ (primary)	-0.2%	[-0.4%, -0.0%]	13
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	0.0%	[-0.4%, 0.3%]	52

Bootstrap: 782.597s -> 781.98s (-0.08%)
Artifact size: 332.70 MiB -> 332.66 MiB (-0.01%)

pnkfelix · 2024-10-21T18:56:05Z

regression to cargo opt-full; improvements to image and html5ever opt-full
briefly skimmed detailed results. nothing stood out.
not worth digging into further; marking as triaged

@rustbot label: +perf-regression-triaged

coolreader18 and others added 20 commits October 8, 2024 15:00

Stabilize Pin::as_deref_mut

5db54be

Allow zero-size reads/writes on null pointers

0c41c34

Add more precondition check tests

84dacc1

Clean up is_aligned_and_not_null

aec09a4

Add a test for zero-sized writes through null

a3606d7

Remove unadorned

c085071

Note what qualifier

d6391d5

Fix clobber_abi and disallow SVE-related registers in Arm64EC inline …

d858dfe

…assembly

Fix AArch64InlineAsmReg::emit

67ebb6c

Special treatment empty tuple when suggest adding a string literal in…

ceced53

… format macro. For example: ```rust let s = "123"; println!({}, "sss", s); ``` Suggest: `println!("{:?} {} {}", {}, "sss", s);` fixes rust-lang#130170

Document various parts of compiletest's lib.rs

cec5986

triagebot: tag PRs affecting compiletest with A-compiletest

9f42f94

Rollup merge of rust-lang#131430 - surechen:fix_130495, r=jieyouxu

75231f8

Special treatment empty tuple when suggest adding a string literal in format macro. For example: ```rust let s = "123"; println!({}, "sss", s); ``` Suggest: `println!("{:?} {} {}", {}, "sss", s);` fixes rust-lang#130170

Rollup merge of rust-lang#131550 - compiler-errors:extern-diags, r=sp…

b8cdca8

…astorino Make some tweaks to extern block diagnostics Self-explanatory. See the diagnostic changes; I hope they make them a bit more descriptive. r? spastorino

Rollup merge of rust-lang#131682 - jieyouxu:compiletest-label, r=Zala…

ac9b212

…thar Tag PRs affecting compiletest with `A-compiletest`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 14, 2024

bors merged commit 9322d18 into rust-lang:master Oct 14, 2024
3 of 7 checks passed

rustbot added this to the 1.84.0 milestone Oct 14, 2024

rustbot added the perf-regression Performance regression. label Oct 14, 2024

rustbot added the perf-regression-triaged The performance regression has been triaged. label Oct 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #131690

Rollup of 8 pull requests #131690

matthiaskrgr commented Oct 14, 2024

matthiaskrgr commented Oct 14, 2024

bors commented Oct 14, 2024

bors commented Oct 14, 2024

bors commented Oct 14, 2024

matthiaskrgr commented Oct 14, 2024

rust-log-analyzer commented Oct 14, 2024

matthiaskrgr commented Oct 14, 2024

bors commented Oct 14, 2024

bors commented Oct 14, 2024

bors commented Oct 14, 2024

rust-log-analyzer commented Oct 14, 2024

matthiaskrgr commented Oct 14, 2024

bors commented Oct 14, 2024

matthiaskrgr commented Oct 14, 2024

bors commented Oct 14, 2024

rust-timer commented Oct 14, 2024

rust-timer commented Oct 14, 2024

pnkfelix commented Oct 21, 2024

Rollup of 8 pull requests #131690

Rollup of 8 pull requests #131690

Conversation

matthiaskrgr commented Oct 14, 2024

matthiaskrgr commented Oct 14, 2024

bors commented Oct 14, 2024

bors commented Oct 14, 2024

bors commented Oct 14, 2024

matthiaskrgr commented Oct 14, 2024

rust-log-analyzer commented Oct 14, 2024

matthiaskrgr commented Oct 14, 2024

bors commented Oct 14, 2024

bors commented Oct 14, 2024

bors commented Oct 14, 2024

rust-log-analyzer commented Oct 14, 2024

matthiaskrgr commented Oct 14, 2024

bors commented Oct 14, 2024

matthiaskrgr commented Oct 14, 2024

bors commented Oct 14, 2024

rust-timer commented Oct 14, 2024

rust-timer commented Oct 14, 2024

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

pnkfelix commented Oct 21, 2024