-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: rewrite stability inheritance as a doc pass #131076
Conversation
Some changes occurred in src/librustdoc/clean/types.rs cc @camelid |
d110c80
to
cd31b3a
Compare
Yes, this makes sense. I don't particularly like adding another pass, but it does obviously avoid the problem here. @bors r+ rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (07f08ff): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 1.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 2.1%, secondary -3.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 771.378s -> 769.179s (-0.29%) |
Documentation correctness fix, but the results are a wash anyway, especially on primary benchmarks. @rustbot label: +perf-regression-triaged |
Since doc inlining can almost arbitrarily change the module hierarchy, we can't just use the HIR ancestors of an item to compute its effective stability. This PR moves the stability inheritance that I implemented in #130798 into a new doc pass
propagate-stability
that runs after doc inlining and uses the post-inlining ancestors of an item to correctly compute its effective stability.fixes #131020
r? @notriddle