Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register tool docs for src/tools/build_helper #130420

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

jieyouxu
Copy link
Member

Fixes #130355.

@jieyouxu jieyouxu added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 16, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2024
@onur-ozkan
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 16, 2024

📌 Commit 1f48a67 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2024
…kingjubilee

Rollup of 5 pull requests

Successful merges:

 - rust-lang#127879 (Document futility of printing temporary pointers)
 - rust-lang#130325 (Use -0.0 in `intrinsics::simd::reduce_add_unordered`)
 - rust-lang#130336 (simplify `Build::update_existing_submodule`)
 - rust-lang#130398 (Add system libs for LLVM when cross compiling for Windows)
 - rust-lang#130420 (Register tool docs for `src/tools/build_helper`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f64d1c1 into rust-lang:master Sep 16, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2024
Rollup merge of rust-lang#130420 - jieyouxu:build_helpers_docs, r=onur-ozkan

Register tool docs for `src/tools/build_helper`

Fixes rust-lang#130355.
@rustbot rustbot added this to the 1.83.0 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build_helper isn't documented in the rustc internal docs
5 participants