Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline HirCollector #130419

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Streamline HirCollector #130419

wants to merge 3 commits into from
+25 −37

Conversation

nnethercote
Copy link
Contributor

@nnethercote
Remove HirCollector::sess.
fbe58a2 
It's redundant w.r.t. `HirCollector::tcx`. This removes the unnecessary
`'a` lifetime.
@nnethercote
Remove HirCollector::map.
55670d2 
Because `rustc_middle::hir::map::Map` is a trivial wrapper around
`TyCtxt`, and `HirCollector` has a `TyCtxt` field.
@nnethercote
Rename AstValidator::session as AstValidator::sess.
7ad1fcd 
Because `sess` is the standard name used everywhere else.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 16, 2024
@nnethercote
Copy link
Contributor Author

@oli-obk recently added "forbid storing a TyCtxt and a Session in the same struct or use both in function args. Only use tcx" to the list of potential internal compiler lints in #49509. The first commit is an example of this, and the other two are just related cleanups that I found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnethercote @GuillaumeGomez @rustbot