Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy button to crate version. #130374

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MeetThePatel
Copy link

This PR closes #111143.

Instead of copying strictly the crate version number, this implementation copies a Cargo.toml 'snippet' (the same behavior as the Crates.io copy button). i.e. For a crate called very_useful_crate on version 0.1.0, the copied string would be: very_useful_crate = "0.1.0".

@rustbot
Copy link
Collaborator

rustbot commented Sep 14, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 14, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 14, 2024

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
.......... (130/131)
F          (131/131)


/checkout/tests/rustdoc-gui/sidebar.goml sidebar... FAILED
[ERROR] `tests/rustdoc-gui/sidebar.goml` line 200: The following errors happened: [different X values: -5.453125 (or -5) != -3]: for command `assert-position: (".sidebar-crate > h2 > a", {"x": -3})`
Error: ()
Build completed unsuccessfully in 0:03:18
  local time: Sat Sep 14 23:53:36 UTC 2024
  network time: Sat, 14 Sep 2024 23:53:37 GMT

@MeetThePatel MeetThePatel changed the title Add copy button to crate version. (Closes #111143) Add copy button to crate version. Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: copy version number when click
4 participants