Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify docs for std::collections #130205

Closed
wants to merge 1 commit into from
Closed

Clarify docs for std::collections #130205

wants to merge 1 commit into from

Conversation

root-goblin
Copy link
Contributor

@root-goblin root-goblin commented Sep 10, 2024 •
edited
Loading

Clone of #129866 with less fork syncing disaster

Page affected: doc.rust-lang.org/std/collections/index.html#performance

Changes:

  • bulleted conventions
  • expanded definitions on terms used
  • more accessible language
  • merged Sequence and Map performance cost tables

r​? @workingjubilee

@root-goblin
Clarify docs for std::collections
4345b8d 
Page affected: doc.rust-lang.org/std/collections/index.html#performance

Changes:

- bulleted conventions
- expanded definitions on terms used
- more accessible language
- merged Sequence and Map performance cost tables
@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@root-goblin @rustbot @Mark-Simulacrum @workingjubilee