refactor libcollections::List, add documentation #13011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it's not a persistent list, then I don't really see a point of having it. Why not just use a vector in the arena? |
|
This type/collection seems to have been limping along for quite some time now. It's never really sat well with me, no matter what the api we expose from it is. This may be indicative that it should just be removed. Do we have any real world use cases of this type? |
|
I'd be fine with us removing |
|
We decided in today's meeting that this type should just get removed for now. @erickt, do you want to amend this PR? If you're running low on time, I'd be willing to take over! |
|
Closing in favor of #13183. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
libcollections::Listto remove the@and replace it with unique pointers. I did this for two reasons. First, none of our otherlibcollectionsdata structures attempt to share any data between copies. I feel we should instead investigate a separate library for persistent data structures instead of just having this one standing out on it's own.Second, there is only one user of
List, and it'slibarena, and this change gets rid of an reference counted pointer in it's structure. It's minor, but it may make it a teensy bit faster.While I was here, I added a bunch of documentation and extended the api to be a little more consistent with the rest of the sequence data structures. I also removed an old purity test that is now redundant.