Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename variant AddrOfRegion of RegionVariableOrigin to BorrowRegion #130070

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Rename variant AddrOfRegion of RegionVariableOrigin to BorrowRegion #130070

merged 1 commit into from
Sep 9, 2024

Conversation

gurry
Copy link
Contributor

@gurry gurry commented Sep 7, 2024 •
edited
Loading

because "Borrow" is the more idiomatic Rust term than "AddrOf".

@rustbot
Copy link
Collaborator

rustbot commented Sep 7, 2024

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 7, 2024
@gurry
Rename variant AddrOfRegion of RegionVariableOrigin to `BorrowReg…
c0b0627 
…ion`

because "Borrow" is the more idiomatic Rust term than "AddrOf".
@gurry gurry force-pushed the rename-regionkind-addof-to-ref branch from e593120 to c0b0627 Compare September 7, 2024 13:21
@gurry gurry changed the title Rename variant AddrOfRegion of RegionVariableOrigin to Borrow Rename variant AddrOfRegion of RegionVariableOrigin to BorrowRegion Sep 7, 2024
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 8, 2024

📌 Commit c0b0627 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned fee1-dead Sep 8, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 8, 2024
@matthiaskrgr
Rollup merge of rust-lang#130070 - gurry:rename-regionkind-addof-to-r…
8940640 
…ef, r=compiler-errors

Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`

because "Borrow" is the more idiomatic Rust term than "AddrOf".
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 8, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 8, 2024
@bors
Auto merge of rust-lang#130100 - matthiaskrgr:rollup-nk36g91, r=matth…
537e9e5 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#129337 (rustdoc rfc#3662 changes under unstable flags)
 - rust-lang#129473 (use  `download-ci-llvm=true` in the default compiler config)
 - rust-lang#129529 (Add test to build crates used by r-a on stable)
 - rust-lang#130025 (Also emit `missing_docs` lint with `--test` to fulfil expectations)
 - rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`)
 - rust-lang#130087 (remove 'const' from 'Option::iter')
 - rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 8, 2024
@matthiaskrgr
Rollup merge of rust-lang#130070 - gurry:rename-regionkind-addof-to-r…
0d0c4dd 
…ef, r=compiler-errors

Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`

because "Borrow" is the more idiomatic Rust term than "AddrOf".
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 8, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 8, 2024
@bors
Auto merge of rust-lang#130109 - matthiaskrgr:rollup-tnuoj7e, r=matth…
8f429c5 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#129473 (use  `download-ci-llvm=true` in the default compiler config)
 - rust-lang#129529 (Add test to build crates used by r-a on stable)
 - rust-lang#130025 (Also emit `missing_docs` lint with `--test` to fulfil expectations)
 - rust-lang#130048 (run-make-support: Add llvm-pdbutil)
 - rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`)
 - rust-lang#130087 (remove 'const' from 'Option::iter')
 - rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment)

r? `@ghost`
`@rustbot` modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 9, 2024
@workingjubilee
Rollup merge of rust-lang#130070 - gurry:rename-regionkind-addof-to-r…
1a7b68a 
…ef, r=compiler-errors

Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`

because "Borrow" is the more idiomatic Rust term than "AddrOf".
@workingjubilee workingjubilee mentioned this pull request Sep 9, 2024
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 9, 2024
@workingjubilee
Rollup merge of rust-lang#130070 - gurry:rename-regionkind-addof-to-r…
6433a73 
…ef, r=compiler-errors

Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`

because "Borrow" is the more idiomatic Rust term than "AddrOf".
@workingjubilee workingjubilee mentioned this pull request Sep 9, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2024
@bors
Auto merge of rust-lang#130129 - workingjubilee:rollup-yfakrkp, r=wor…
23ed20d 
…kingjubilee

Rollup of 16 pull requests

Successful merges:

 - rust-lang#119229 (Update mingw-w64 + GNU toolchain)
 - rust-lang#128345 (added support for GNU/Hurd on x86_64)
 - rust-lang#128667 (rustdoc: normalise type/field names)
 - rust-lang#128939 (Distribute rustc_codegen_cranelift for Windows)
 - rust-lang#129529 (Add test to build crates used by r-a on stable)
 - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`)
 - rust-lang#129876 (Use sysroot crates maximally in `rustc_codegen_gcc`.)
 - rust-lang#130034 ( Fix enabling wasm-component-ld to match other tools )
 - rust-lang#130048 (run-make-support: Add llvm-pdbutil)
 - rust-lang#130068 (Test codegen when setting deployment target)
 - rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`)
 - rust-lang#130087 (remove 'const' from 'Option::iter')
 - rust-lang#130090 (make Result::copied unstably const)
 - rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment)
 - rust-lang#130107 (const: make ptr.is_null() stop execution on ambiguity)
 - rust-lang#130115 (Remove needless returns detected by clippy in libraries)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee workingjubilee mentioned this pull request Sep 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2024
@bors
Auto merge of rust-lang#130133 - workingjubilee:rollup-t5o827k, r=wor…
1f44f0a 
…kingjubilee

Rollup of 14 pull requests

Successful merges:

 - rust-lang#119229 (Update mingw-w64 + GNU toolchain)
 - rust-lang#128345 (added support for GNU/Hurd on x86_64)
 - rust-lang#128667 (rustdoc: normalise type/field names)
 - rust-lang#129876 (Use sysroot crates maximally in `rustc_codegen_gcc`.)
 - rust-lang#130034 ( Fix enabling wasm-component-ld to match other tools )
 - rust-lang#130048 (run-make-support: Add llvm-pdbutil)
 - rust-lang#130068 (Test codegen when setting deployment target)
 - rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`)
 - rust-lang#130087 (remove 'const' from 'Option::iter')
 - rust-lang#130090 (make Result::copied unstably const)
 - rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment)
 - rust-lang#130107 (const: make ptr.is_null() stop execution on ambiguity)
 - rust-lang#130115 (Remove needless returns detected by clippy in libraries)
 - rust-lang#130130 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 09373b9 into rust-lang:master Sep 9, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2024
@rust-timer
Unrolled build for rust-lang#130070
815c2f1 
Rollup merge of rust-lang#130070 - gurry:rename-regionkind-addof-to-ref, r=compiler-errors

Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`

because "Borrow" is the more idiomatic Rust term than "AddrOf".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gurry @rustbot @compiler-errors @bors @fee1-dead