Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-mono MIR opts #130051

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Post-mono MIR opts #130051

wants to merge 4 commits into from
+134 −128

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Sep 6, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2024

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 6, 2024
@cjgillot
Copy link
Contributor Author

cjgillot commented Sep 6, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 6, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 6, 2024
@bors
Auto merge of rust-lang#130051 - cjgillot:clone-mir, r=<try>
8aad989 
Post-mono MIR opts
@bors
Copy link
Contributor

bors commented Sep 6, 2024

⌛ Trying commit 83effc2 with merge 8aad989...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Sep 6, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2024
@cjgillot
Copy link
Contributor Author

cjgillot commented Sep 7, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Sep 7, 2024

⌛ Trying commit 142c276 with merge 388d6dc...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2024
@bors
Auto merge of rust-lang#130051 - cjgillot:clone-mir, r=<try>
388d6dc 
Post-mono MIR opts
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Sep 7, 2024

☀️ Try build successful - checks-actions
Build commit: 388d6dc (388d6dc0ebeba060e002e4c0111f92a25aedc437)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (388d6dc): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.7% [0.2%, 1.2%] 21
Regressions ❌
(secondary)		 9.2% [0.3%, 18.2%] 2
Improvements ✅
(primary)		 -0.3% [-0.3%, -0.3%] 4
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.5% [-0.3%, 1.2%] 25

Max RSS (memory usage)

Results (primary -0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 7.2% [7.2%, 7.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.2% [-5.7%, -0.9%] 5
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.7% [-5.7%, 7.2%] 6

Cycles

Results (secondary 8.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 8.8% [1.0%, 16.5%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

Results (primary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.2% [0.0%, 0.8%] 10
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.3%, -0.0%] 14
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.0% [-0.3%, 0.8%] 24

Bootstrap: 756.217s -> 761.565s (0.71%)
Artifact size: 341.14 MiB -> 341.21 MiB (0.02%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 7, 2024
@cjgillot
Copy link
Contributor Author

cjgillot commented Sep 7, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 7, 2024
@bors
Copy link
Contributor

bors commented Sep 7, 2024

⌛ Trying commit 6ded72b with merge 182dada...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2024
@bors
Auto merge of rust-lang#130051 - cjgillot:clone-mir, r=<try>
182dada 
Post-mono MIR opts
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
------
 > importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:fb97a1d6377f6cf2227825318ca4bbde3889e0c420746f5a03ba46a07e9a862725c26a09b9fc49a0d129ebd75935d3f6cd19acf41cc4267a6846fd4aa574b12c:
------
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-17]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-17', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-17/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---

---- [coverage-map] tests/coverage/branch/generics.rs stdout ----
diff of cov-map:

1 Function name: generics::print_size::<()>
- Raw bytes (33): 0x[01, 01, 01, 01, 05, 05, 01, 06, 01, 01, 24, 20, 05, 02, 01, 08, 00, 24, 05, 00, 25, 02, 06, 02, 02, 0c, 02, 06, 01, 03, 01, 00, 02]
+ Raw bytes (33): 0x[01, 01, 01, 01, 00, 05, 01, 06, 01, 01, 24, 20, 00, 02, 01, 08, 00, 24, 00, 00, 25, 02, 06, 02, 02, 0c, 02, 06, 01, 03, 01, 00, 02]
4 - file 0 => global file 1
5 Number of expressions: 1

- - expression 0 operands: lhs = Counter(0), rhs = Counter(1)
- - expression 0 operands: lhs = Counter(0), rhs = Counter(1)
+ - expression 0 operands: lhs = Counter(0), rhs = Zero
7 Number of file 0 mappings: 5
8 - Code(Counter(0)) at (prev + 6, 1) to (start + 1, 36)
- - Branch { true: Counter(1), false: Expression(0, Sub) } at (prev + 1, 8) to (start + 0, 36)
-     true  = c1
-     false = (c0 - c1)
- - Code(Counter(1)) at (prev + 0, 37) to (start + 2, 6)
+ - Branch { true: Zero, false: Expression(0, Sub) } at (prev + 1, 8) to (start + 0, 36)
+     true  = Zero
+     false = (c0 - Zero)
+ - Code(Zero) at (prev + 0, 37) to (start + 2, 6)
13 - Code(Expression(0, Sub)) at (prev + 2, 12) to (start + 2, 6)
-     = (c0 - c1)
+     = (c0 - Zero)
15 - Code(Counter(0)) at (prev + 3, 1) to (start + 0, 2)
17 Function name: generics::print_size::<u32>


- Raw bytes (33): 0x[01, 01, 01, 01, 05, 05, 01, 06, 01, 01, 24, 20, 05, 02, 01, 08, 00, 24, 05, 00, 25, 02, 06, 02, 02, 0c, 02, 06, 01, 03, 01, 00, 02]
+ Raw bytes (33): 0x[01, 01, 01, 01, 00, 05, 01, 06, 01, 01, 24, 20, 00, 02, 01, 08, 00, 24, 00, 00, 25, 02, 06, 02, 02, 0c, 02, 06, 01, 03, 01, 00, 02]
20 - file 0 => global file 1
21 Number of expressions: 1

- - expression 0 operands: lhs = Counter(0), rhs = Counter(1)
- - expression 0 operands: lhs = Counter(0), rhs = Counter(1)
+ - expression 0 operands: lhs = Counter(0), rhs = Zero
23 Number of file 0 mappings: 5
24 - Code(Counter(0)) at (prev + 6, 1) to (start + 1, 36)
- - Branch { true: Counter(1), false: Expression(0, Sub) } at (prev + 1, 8) to (start + 0, 36)
-     true  = c1
-     false = (c0 - c1)
- - Code(Counter(1)) at (prev + 0, 37) to (start + 2, 6)
+ - Branch { true: Zero, false: Expression(0, Sub) } at (prev + 1, 8) to (start + 0, 36)
+     true  = Zero
+     false = (c0 - Zero)
+ - Code(Zero) at (prev + 0, 37) to (start + 2, 6)
29 - Code(Expression(0, Sub)) at (prev + 2, 12) to (start + 2, 6)
-     = (c0 - c1)
+     = (c0 - Zero)
31 - Code(Counter(0)) at (prev + 3, 1) to (start + 0, 2)
33 Function name: generics::print_size::<u64>


- Raw bytes (33): 0x[01, 01, 01, 01, 05, 05, 01, 06, 01, 01, 24, 20, 05, 02, 01, 08, 00, 24, 05, 00, 25, 02, 06, 02, 02, 0c, 02, 06, 01, 03, 01, 00, 02]
+ Raw bytes (31): 0x[01, 01, 00, 05, 01, 06, 01, 01, 24, 20, 05, 00, 01, 08, 00, 24, 05, 00, 25, 02, 06, 00, 02, 0c, 02, 06, 01, 03, 01, 00, 02]
36 - file 0 => global file 1
- Number of expressions: 1
- - expression 0 operands: lhs = Counter(0), rhs = Counter(1)
+ Number of expressions: 0
+ Number of expressions: 0
39 Number of file 0 mappings: 5
40 - Code(Counter(0)) at (prev + 6, 1) to (start + 1, 36)
- - Branch { true: Counter(1), false: Expression(0, Sub) } at (prev + 1, 8) to (start + 0, 36)
+ - Branch { true: Counter(1), false: Zero } at (prev + 1, 8) to (start + 0, 36)
42     true  = c1
-     false = (c0 - c1)
+     false = Zero
44 - Code(Counter(1)) at (prev + 0, 37) to (start + 2, 6)
- - Code(Expression(0, Sub)) at (prev + 2, 12) to (start + 2, 6)
-     = (c0 - c1)
+ - Code(Zero) at (prev + 2, 12) to (start + 2, 6)
47 - Code(Counter(0)) at (prev + 3, 1) to (start + 0, 2)
49 


The actual cov-map differed from the expected cov-map.
The actual cov-map differed from the expected cov-map.
Actual cov-map saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/coverage/branch/generics.coverage-map/generics.cov-map
error: 1 errors occurred comparing coverage output.
status: exit status: 0
status: exit status: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/coverage-dump" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/coverage/branch/generics.coverage-map/generics.ll"
Function name: generics::print_size::<()>
Function name: generics::print_size::<()>
Raw bytes (33): 0x[01, 01, 01, 01, 00, 05, 01, 06, 01, 01, 24, 20, 00, 02, 01, 08, 00, 24, 00, 00, 25, 02, 06, 02, 02, 0c, 02, 06, 01, 03, 01, 00, 02]
- file 0 => global file 1
Number of expressions: 1
Number of expressions: 1
- expression 0 operands: lhs = Counter(0), rhs = Zero
Number of file 0 mappings: 5
- Code(Counter(0)) at (prev + 6, 1) to (start + 1, 36)
- Branch { true: Zero, false: Expression(0, Sub) } at (prev + 1, 8) to (start + 0, 36)
    true  = Zero
    false = (c0 - Zero)
- Code(Zero) at (prev + 0, 37) to (start + 2, 6)
- Code(Expression(0, Sub)) at (prev + 2, 12) to (start + 2, 6)
    = (c0 - Zero)
- Code(Counter(0)) at (prev + 3, 1) to (start + 0, 2)
Function name: generics::print_size::<u32>
Function name: generics::print_size::<u32>
Raw bytes (33): 0x[01, 01, 01, 01, 00, 05, 01, 06, 01, 01, 24, 20, 00, 02, 01, 08, 00, 24, 00, 00, 25, 02, 06, 02, 02, 0c, 02, 06, 01, 03, 01, 00, 02]
- file 0 => global file 1
Number of expressions: 1
Number of expressions: 1
- expression 0 operands: lhs = Counter(0), rhs = Zero
Number of file 0 mappings: 5
- Code(Counter(0)) at (prev + 6, 1) to (start + 1, 36)
- Branch { true: Zero, false: Expression(0, Sub) } at (prev + 1, 8) to (start + 0, 36)
    true  = Zero
    false = (c0 - Zero)
- Code(Zero) at (prev + 0, 37) to (start + 2, 6)
- Code(Expression(0, Sub)) at (prev + 2, 12) to (start + 2, 6)
    = (c0 - Zero)
- Code(Counter(0)) at (prev + 3, 1) to (start + 0, 2)
Function name: generics::print_size::<u64>
Function name: generics::print_size::<u64>
Raw bytes (31): 0x[01, 01, 00, 05, 01, 06, 01, 01, 24, 20, 05, 00, 01, 08, 00, 24, 05, 00, 25, 02, 06, 00, 02, 0c, 02, 06, 01, 03, 01, 00, 02]
- file 0 => global file 1
Number of expressions: 0
Number of file 0 mappings: 5
Number of file 0 mappings: 5
- Code(Counter(0)) at (prev + 6, 1) to (start + 1, 36)
- Branch { true: Counter(1), false: Zero } at (prev + 1, 8) to (start + 0, 36)
    true  = c1
    false = Zero
- Code(Counter(1)) at (prev + 0, 37) to (start + 2, 6)
- Code(Zero) at (prev + 2, 12) to (start + 2, 6)
- Code(Counter(0)) at (prev + 3, 1) to (start + 0, 2)
stderr: none


---- [coverage-map] tests/coverage/issue-84561.rs stdout ----
---- [coverage-map] tests/coverage/issue-84561.rs stdout ----
diff of cov-map:

54 - Code(Counter(0)) at (prev + 167, 9) to (start + 2, 10)
56 Function name: issue_84561::test3
56 Function name: issue_84561::test3
- Raw bytes (375): 0x[01, 01, 31, 05, 09, 0d, 00, 15, 19, 12, 00, 15, 19, 21, 00, 1e, 00, 21, 00, 31, 00, 3d, 00, 2e, 45, 3d, 00, 42, 49, 45, 00, 3f, 51, 42, 49, 45, 00, 7a, 55, 51, 00, 7a, 55, 51, 00, 77, 5d, 7a, 55, 51, 00, 77, 61, 7a, 55, 51, 00, 72, 65, 77, 61, 7a, 55, 51, 00, 75, be, 01, c2, 01, 79, 69, 6d, 69, 6d, 69, 6d, c2, 01, 00, 69, 6d, c2, 01, 79, 69, 6d, bb, 01, 7d, 75, be, 01, c2, 01, 79, 69, 6d, b6, 01, 00, bb, 01, 7d, 75, be, 01, c2, 01, 79, 69, 6d, 33, 01, 08, 01, 03, 1c, 05, 04, 09, 01, 1c, 02, 02, 05, 04, 1f, 0d, 05, 05, 00, 1f, 06, 01, 05, 00, 1f, 15, 01, 09, 01, 1c, 12, 02, 05, 00, 1f, 0e, 01, 05, 00, 0f, 00, 00, 20, 00, 30, 21, 01, 05, 03, 0f, 00, 03, 20, 00, 30, 00, 00, 33, 00, 41, 00, 00, 4b, 00, 5a, 1e, 01, 05, 00, 0f, 00, 05, 09, 03, 10, 00, 05, 0d, 00, 1b, 00, 02, 0d, 00, 1c, 1a, 04, 09, 05, 06, 31, 06, 05, 03, 06, 22, 04, 05, 03, 06, 3d, 04, 09, 04, 06, 2e, 05, 08, 00, 0f, 45, 01, 09, 03, 0a, 2a, 05, 09, 03, 0a, 3f, 05, 08, 00, 0f, 51, 01, 09, 00, 13, 00, 03, 0d, 00, 1d, 3a, 03, 09, 00, 13, 00, 03, 0d, 00, 1d, 77, 03, 05, 00, 0f, 77, 01, 0c, 00, 13, 5d, 01, 0d, 00, 13, 56, 02, 0d, 00, 13, 72, 04, 05, 02, 13, 65, 03, 0d, 00, 13, 6e, 02, 0d, 00, 13, bb, 01, 03, 05, 00, 0f, 69, 01, 0c, 00, 13, 6d, 01, 0d, 03, 0e, 75, 04, 0d, 00, 13, c2, 01, 02, 0d, 00, 17, c2, 01, 01, 14, 00, 1b, 00, 01, 15, 00, 1b, 92, 01, 02, 15, 00, 1b, be, 01, 04, 0d, 00, 13, 7d, 03, 09, 00, 19, b6, 01, 02, 05, 00, 0f, b2, 01, 03, 09, 00, 22, 00, 02, 05, 00, 0f, 00, 03, 09, 00, 2c, 00, 02, 01, 00, 02]
+ Raw bytes (375): 0x[01, 01, 31, 05, 09, 0d, 00, 15, 19, 12, 00, 15, 19, 21, 00, 1e, 00, 21, 00, 31, 00, 3d, 00, 2e, 45, 3d, 00, 42, 49, 45, 00, 3f, 51, 42, 49, 45, 00, 7a, 55, 51, 00, 7a, 55, 51, 00, 77, 5d, 7a, 55, 51, 00, 77, 61, 7a, 55, 51, 00, 72, 65, 77, 61, 7a, 55, 51, 00, 75, be, 01, c2, 01, 00, 69, 6d, 69, 6d, 69, 6d, c2, 01, 00, 69, 6d, c2, 01, 00, 69, 6d, bb, 01, 7d, 75, be, 01, c2, 01, 00, 69, 6d, b6, 01, 00, bb, 01, 7d, 75, be, 01, c2, 01, 00, 69, 6d, 33, 01, 08, 01, 03, 1c, 05, 04, 09, 01, 1c, 02, 02, 05, 04, 1f, 0d, 05, 05, 00, 1f, 06, 01, 05, 00, 1f, 15, 01, 09, 01, 1c, 12, 02, 05, 00, 1f, 0e, 01, 05, 00, 0f, 00, 00, 20, 00, 30, 21, 01, 05, 03, 0f, 00, 03, 20, 00, 30, 00, 00, 33, 00, 41, 00, 00, 4b, 00, 5a, 1e, 01, 05, 00, 0f, 00, 05, 09, 03, 10, 00, 05, 0d, 00, 1b, 00, 02, 0d, 00, 1c, 1a, 04, 09, 05, 06, 31, 06, 05, 03, 06, 22, 04, 05, 03, 06, 3d, 04, 09, 04, 06, 2e, 05, 08, 00, 0f, 45, 01, 09, 03, 0a, 2a, 05, 09, 03, 0a, 3f, 05, 08, 00, 0f, 51, 01, 09, 00, 13, 00, 03, 0d, 00, 1d, 3a, 03, 09, 00, 13, 00, 03, 0d, 00, 1d, 77, 03, 05, 00, 0f, 77, 01, 0c, 00, 13, 5d, 01, 0d, 00, 13, 56, 02, 0d, 00, 13, 72, 04, 05, 02, 13, 65, 03, 0d, 00, 13, 6e, 02, 0d, 00, 13, bb, 01, 03, 05, 00, 0f, 69, 01, 0c, 00, 13, 6d, 01, 0d, 03, 0e, 75, 04, 0d, 00, 13, c2, 01, 02, 0d, 00, 17, c2, 01, 01, 14, 00, 1b, 00, 01, 15, 00, 1b, 92, 01, 02, 15, 00, 1b, be, 01, 04, 0d, 00, 13, 7d, 03, 09, 00, 19, b6, 01, 02, 05, 00, 0f, b2, 01, 03, 09, 00, 22, 00, 02, 05, 00, 0f, 00, 03, 09, 00, 2c, 00, 02, 01, 00, 02]
59 - file 0 => global file 1
60 Number of expressions: 49


90 - expression 29 operands: lhs = Expression(30, Sub), rhs = Counter(21)
91 - expression 30 operands: lhs = Counter(20), rhs = Zero
92 - expression 31 operands: lhs = Counter(29), rhs = Expression(47, Sub)
- - expression 32 operands: lhs = Expression(48, Sub), rhs = Counter(30)
+ - expression 32 operands: lhs = Expression(48, Sub), rhs = Zero
94 - expression 33 operands: lhs = Counter(26), rhs = Counter(27)
95 - expression 34 operands: lhs = Counter(26), rhs = Counter(27)
96 - expression 35 operands: lhs = Counter(26), rhs = Counter(27)

97 - expression 36 operands: lhs = Expression(48, Sub), rhs = Zero
98 - expression 37 operands: lhs = Counter(26), rhs = Counter(27)
- - expression 38 operands: lhs = Expression(48, Sub), rhs = Counter(30)
+ - expression 38 operands: lhs = Expression(48, Sub), rhs = Zero
100 - expression 39 operands: lhs = Counter(26), rhs = Counter(27)
101 - expression 40 operands: lhs = Expression(46, Add), rhs = Counter(31)
102 - expression 41 operands: lhs = Counter(29), rhs = Expression(47, Sub)

- - expression 42 operands: lhs = Expression(48, Sub), rhs = Counter(30)
+ - expression 42 operands: lhs = Expression(48, Sub), rhs = Zero
104 - expression 43 operands: lhs = Counter(26), rhs = Counter(27)
105 - expression 44 operands: lhs = Expression(45, Sub), rhs = Zero
106 - expression 45 operands: lhs = Expression(46, Add), rhs = Counter(31)

107 - expression 46 operands: lhs = Counter(29), rhs = Expression(47, Sub)
- - expression 47 operands: lhs = Expression(48, Sub), rhs = Counter(30)
+ - expression 47 operands: lhs = Expression(48, Sub), rhs = Zero
109 - expression 48 operands: lhs = Counter(26), rhs = Counter(27)
110 Number of file 0 mappings: 51
111 - Code(Counter(0)) at (prev + 8, 1) to (start + 3, 28)

161 - Code(Expression(27, Sub)) at (prev + 2, 13) to (start + 0, 19)
162     = ((((c20 - Zero) + c21) - c24) - c25)
163 - Code(Expression(46, Add)) at (prev + 3, 5) to (start + 0, 15)
-     = (c29 + ((c26 - c27) - c30))
+     = (c29 + ((c26 - c27) - Zero))
165 - Code(Counter(26)) at (prev + 1, 12) to (start + 0, 19)
166 - Code(Counter(27)) at (prev + 1, 13) to (start + 3, 14)
167 - Code(Counter(29)) at (prev + 4, 13) to (start + 0, 19)

173 - Code(Expression(36, Sub)) at (prev + 2, 21) to (start + 0, 27)
174     = ((c26 - c27) - Zero)
175 - Code(Expression(47, Sub)) at (prev + 4, 13) to (start + 0, 19)
-     = ((c26 - c27) - c30)
+     = ((c26 - c27) - Zero)
177 - Code(Counter(31)) at (prev + 3, 9) to (start + 0, 25)
178 - Code(Expression(45, Sub)) at (prev + 2, 5) to (start + 0, 15)
-     = ((c29 + ((c26 - c27) - c30)) - c31)
+     = ((c29 + ((c26 - c27) - Zero)) - c31)
180 - Code(Expression(44, Sub)) at (prev + 3, 9) to (start + 0, 34)
-     = (((c29 + ((c26 - c27) - c30)) - c31) - Zero)
+     = (((c29 + ((c26 - c27) - Zero)) - c31) - Zero)
182 - Code(Zero) at (prev + 2, 5) to (start + 0, 15)
183 - Code(Zero) at (prev + 3, 9) to (start + 0, 44)
184 - Code(Zero) at (prev + 2, 1) to (start + 0, 2)

The actual cov-map differed from the expected cov-map.
The actual cov-map differed from the expected cov-map.
Actual cov-map saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/coverage/issue-84561.coverage-map/issue-84561.cov-map
error: 1 errors occurred comparing coverage output.
status: exit status: 0
status: exit status: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/coverage-dump" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/coverage/issue-84561.coverage-map/issue-84561.ll"
--- stdout -------------------------------
Function name: <issue_84561::Foo as core::fmt::Debug>::fmt
Raw bytes (27): 0x[01, 01, 01, 01, 05, 04, 01, 8a, 01, 05, 01, 25, 05, 01, 25, 00, 26, 02, 01, 09, 00, 0f, 01, 01, 05, 00, 06]
- file 0 => global file 1
Number of expressions: 1
- expression 0 operands: lhs = Counter(0), rhs = Counter(1)
Number of file 0 mappings: 4
Number of file 0 mappings: 4
- Code(Counter(0)) at (prev + 138, 5) to (start + 1, 37)
- Code(Counter(1)) at (prev + 1, 37) to (start + 0, 38)
- Code(Expression(0, Sub)) at (prev + 1, 9) to (start + 0, 15)
    = (c0 - c1)
- Code(Counter(0)) at (prev + 1, 5) to (start + 0, 6)
Function name: issue_84561::main
Function name: issue_84561::main
Raw bytes (10): 0x[01, 01, 00, 01, 01, b4, 01, 01, 04, 02]
- file 0 => global file 1
Number of expressions: 0
Number of file 0 mappings: 1
Number of file 0 mappings: 1
- Code(Counter(0)) at (prev + 180, 1) to (start + 4, 2)
Function name: issue_84561::test1
Function name: issue_84561::test1
Raw bytes (50): 0x[01, 01, 00, 09, 01, 9a, 01, 01, 01, 0b, 05, 01, 0c, 00, 1e, 01, 01, 05, 00, 0b, 09, 00, 0c, 00, 1e, 01, 01, 0d, 01, 0b, 0d, 01, 0c, 00, 1e, 01, 01, 05, 03, 0b, 11, 03, 0c, 00, 1e, 01, 01, 01, 00, 02]
- file 0 => global file 1
Number of expressions: 0
Number of file 0 mappings: 9
Number of file 0 mappings: 9
- Code(Counter(0)) at (prev + 154, 1) to (start + 1, 11)
- Code(Counter(1)) at (prev + 1, 12) to (start + 0, 30)
- Code(Counter(0)) at (prev + 1, 5) to (start + 0, 11)
- Code(Counter(2)) at (prev + 0, 12) to (start + 0, 30)
- Code(Counter(0)) at (prev + 1, 13) to (start + 1, 11)
- Code(Counter(3)) at (prev + 1, 12) to (start + 0, 30)
- Code(Counter(0)) at (prev + 1, 5) to (start + 3, 11)
- Code(Counter(4)) at (prev + 3, 12) to (start + 0, 30)
- Code(Counter(0)) at (prev + 1, 1) to (start + 0, 2)
Function name: issue_84561::test2
Function name: issue_84561::test2
Raw bytes (20): 0x[01, 01, 00, 03, 01, b0, 01, 01, 01, 10, 05, 01, 11, 00, 23, 01, 01, 01, 00, 02]
- file 0 => global file 1
Number of expressions: 0
Number of file 0 mappings: 3
Number of file 0 mappings: 3
- Code(Counter(0)) at (prev + 176, 1) to (start + 1, 16)
- Code(Counter(1)) at (prev + 1, 17) to (start + 0, 35)
- Code(Counter(0)) at (prev + 1, 1) to (start + 0, 2)
Function name: issue_84561::test2::call_print
Function name: issue_84561::test2::call_print
Raw bytes (10): 0x[01, 01, 00, 01, 01, a7, 01, 09, 02, 0a]
- file 0 => global file 1
Number of expressions: 0
Number of file 0 mappings: 1
Number of file 0 mappings: 1
- Code(Counter(0)) at (prev + 167, 9) to (start + 2, 10)
Function name: issue_84561::test3
Function name: issue_84561::test3
Raw bytes (375): 0x[01, 01, 31, 05, 09, 0d, 00, 15, 19, 12, 00, 15, 19, 21, 00, 1e, 00, 21, 00, 31, 00, 3d, 00, 2e, 45, 3d, 00, 42, 49, 45, 00, 3f, 51, 42, 49, 45, 00, 7a, 55, 51, 00, 7a, 55, 51, 00, 77, 5d, 7a, 55, 51, 00, 77, 61, 7a, 55, 51, 00, 72, 65, 77, 61, 7a, 55, 51, 00, 75, be, 01, c2, 01, 00, 69, 6d, 69, 6d, 69, 6d, c2, 01, 00, 69, 6d, c2, 01, 00, 69, 6d, bb, 01, 7d, 75, be, 01, c2, 01, 00, 69, 6d, b6, 01, 00, bb, 01, 7d, 75, be, 01, c2, 01, 00, 69, 6d, 33, 01, 08, 01, 03, 1c, 05, 04, 09, 01, 1c, 02, 02, 05, 04, 1f, 0d, 05, 05, 00, 1f, 06, 01, 05, 00, 1f, 15, 01, 09, 01, 1c, 12, 02, 05, 00, 1f, 0e, 01, 05, 00, 0f, 00, 00, 20, 00, 30, 21, 01, 05, 03, 0f, 00, 03, 20, 00, 30, 00, 00, 33, 00, 41, 00, 00, 4b, 00, 5a, 1e, 01, 05, 00, 0f, 00, 05, 09, 03, 10, 00, 05, 0d, 00, 1b, 00, 02, 0d, 00, 1c, 1a, 04, 09, 05, 06, 31, 06, 05, 03, 06, 22, 04, 05, 03, 06, 3d, 04, 09, 04, 06, 2e, 05, 08, 00, 0f, 45, 01, 09, 03, 0a, 2a, 05, 09, 03, 0a, 3f, 05, 08, 00, 0f, 51, 01, 09, 00, 13, 00, 03, 0d, 00, 1d, 3a, 03, 09, 00, 13, 00, 03, 0d, 00, 1d, 77, 03, 05, 00, 0f, 77, 01, 0c, 00, 13, 5d, 01, 0d, 00, 13, 56, 02, 0d, 00, 13, 72, 04, 05, 02, 13, 65, 03, 0d, 00, 13, 6e, 02, 0d, 00, 13, bb, 01, 03, 05, 00, 0f, 69, 01, 0c, 00, 13, 6d, 01, 0d, 03, 0e, 75, 04, 0d, 00, 13, c2, 01, 02, 0d, 00, 17, c2, 01, 01, 14, 00, 1b, 00, 01, 15, 00, 1b, 92, 01, 02, 15, 00, 1b, be, 01, 04, 0d, 00, 13, 7d, 03, 09, 00, 19, b6, 01, 02, 05, 00, 0f, b2, 01, 03, 09, 00, 22, 00, 02, 05, 00, 0f, 00, 03, 09, 00, 2c, 00, 02, 01, 00, 02]
- file 0 => global file 1
Number of expressions: 49
- expression 0 operands: lhs = Counter(1), rhs = Counter(2)
- expression 0 operands: lhs = Counter(1), rhs = Counter(2)
- expression 1 operands: lhs = Counter(3), rhs = Zero
- expression 2 operands: lhs = Counter(5), rhs = Counter(6)
- expression 3 operands: lhs = Expression(4, Sub), rhs = Zero
- expression 4 operands: lhs = Counter(5), rhs = Counter(6)
- expression 5 operands: lhs = Counter(8), rhs = Zero
- expression 6 operands: lhs = Expression(7, Sub), rhs = Zero
- expression 7 operands: lhs = Counter(8), rhs = Zero
- expression 8 operands: lhs = Counter(12), rhs = Zero
- expression 9 operands: lhs = Counter(15), rhs = Zero
- expression 10 operands: lhs = Expression(11, Sub), rhs = Counter(17)
- expression 11 operands: lhs = Counter(15), rhs = Zero
- expression 12 operands: lhs = Expression(16, Sub), rhs = Counter(18)
- expression 13 operands: lhs = Counter(17), rhs = Zero
- expression 14 operands: lhs = Expression(15, Add), rhs = Counter(20)
- expression 15 operands: lhs = Expression(16, Sub), rhs = Counter(18)
- expression 16 operands: lhs = Counter(17), rhs = Zero
- expression 17 operands: lhs = Expression(30, Sub), rhs = Counter(21)
- expression 18 operands: lhs = Counter(20), rhs = Zero
- expression 19 operands: lhs = Expression(30, Sub), rhs = Counter(21)
- expression 20 operands: lhs = Counter(20), rhs = Zero
- expression 21 operands: lhs = Expression(29, Add), rhs = Counter(23)
- expression 22 operands: lhs = Expression(30, Sub), rhs = Counter(21)
- expression 23 operands: lhs = Counter(20), rhs = Zero
- expression 24 operands: lhs = Expression(29, Add), rhs = Counter(24)
- expression 25 operands: lhs = Expression(30, Sub), rhs = Counter(21)
- expression 26 operands: lhs = Counter(20), rhs = Zero
- expression 27 operands: lhs = Expression(28, Sub), rhs = Counter(25)
- expression 28 operands: lhs = Expression(29, Add), rhs = Counter(24)
- expression 29 operands: lhs = Expression(30, Sub), rhs = Counter(21)
- expression 30 operands: lhs = Counter(20), rhs = Zero
- expression 31 operands: lhs = Counter(29), rhs = Expression(47, Sub)
- expression 32 operands: lhs = Expression(48, Sub), rhs = Zero
- expression 33 operands: lhs = Counter(26), rhs = Counter(27)
- expression 34 operands: lhs = Counter(26), rhs = Counter(27)
- expression 35 operands: lhs = Counter(26), rhs = Counter(27)
- expression 36 operands: lhs = Expression(48, Sub), rhs = Zero
- expression 37 operands: lhs = Counter(26), rhs = Counter(27)
- expression 38 operands: lhs = Expression(48, Sub), rhs = Zero
- expression 39 operands: lhs = Counter(26), rhs = Counter(27)
- expression 40 operands: lhs = Expression(46, Add), rhs = Counter(31)
- expression 41 operands: lhs = Counter(29), rhs = Expression(47, Sub)
- expression 42 operands: lhs = Expression(48, Sub), rhs = Zero
- expression 43 operands: lhs = Counter(26), rhs = Counter(27)
- expression 44 operands: lhs = Expression(45, Sub), rhs = Zero
- expression 45 operands: lhs = Expression(46, Add), rhs = Counter(31)
- expression 46 operands: lhs = Counter(29), rhs = Expression(47, Sub)
- expression 47 operands: lhs = Expression(48, Sub), rhs = Zero
- expression 48 operands: lhs = Counter(26), rhs = Counter(27)
Number of file 0 mappings: 51
- Code(Counter(0)) at (prev + 8, 1) to (start + 3, 28)
- Code(Counter(1)) at (prev + 4, 9) to (start + 1, 28)
- Code(Expression(0, Sub)) at (prev + 2, 5) to (start + 4, 31)
    = (c1 - c2)
- Code(Counter(3)) at (prev + 5, 5) to (start + 0, 31)
- Code(Expression(1, Sub)) at (prev + 1, 5) to (start + 0, 31)
    = (c3 - Zero)
- Code(Counter(5)) at (prev + 1, 9) to (start + 1, 28)
- Code(Expression(4, Sub)) at (prev + 2, 5) to (start + 0, 31)
    = (c5 - c6)
- Code(Expression(3, Sub)) at (prev + 1, 5) to (start + 0, 15)
    = ((c5 - c6) - Zero)
- Code(Zero) at (prev + 0, 32) to (start + 0, 48)
- Code(Counter(8)) at (prev + 1, 5) to (start + 3, 15)
- Code(Zero) at (prev + 3, 32) to (start + 0, 48)
- Code(Zero) at (prev + 0, 51) to (start + 0, 65)
- Code(Zero) at (prev + 0, 75) to (start + 0, 90)
- Code(Expression(7, Sub)) at (prev + 1, 5) to (start + 0, 15)
    = (c8 - Zero)
- Code(Zero) at (prev + 5, 9) to (start + 3, 16)
- Code(Zero) at (prev + 5, 13) to (start + 0, 27)
- Code(Zero) at (prev + 2, 13) to (start + 0, 28)
- Code(Expression(6, Sub)) at (prev + 4, 9) to (start + 5, 6)
    = ((c8 - Zero) - Zero)
- Code(Counter(12)) at (prev + 6, 5) to (start + 3, 6)
- Code(Expression(8, Sub)) at (prev + 4, 5) to (start + 3, 6)
    = (c12 - Zero)
- Code(Counter(15)) at (prev + 4, 9) to (start + 4, 6)
- Code(Expression(11, Sub)) at (prev + 5, 8) to (start + 0, 15)
    = (c15 - Zero)
- Code(Counter(17)) at (prev + 1, 9) to (start + 3, 10)
- Code(Expression(10, Sub)) at (prev + 5, 9) to (start + 3, 10)
    = ((c15 - Zero) - c17)
- Code(Expression(15, Add)) at (prev + 5, 8) to (start + 0, 15)
    = ((c17 - Zero) + c18)
- Code(Counter(20)) at (prev + 1, 9) to (start + 0, 19)
- Code(Zero) at (prev + 3, 13) to (start + 0, 29)
- Code(Expression(14, Sub)) at (prev + 3, 9) to (start + 0, 19)
    = (((c17 - Zero) + c18) - c20)
- Code(Zero) at (prev + 3, 13) to (start + 0, 29)
- Code(Expression(29, Add)) at (prev + 3, 5) to (start + 0, 15)
    = ((c20 - Zero) + c21)
- Code(Expression(29, Add)) at (prev + 1, 12) to (start + 0, 19)
    = ((c20 - Zero) + c21)
- Code(Counter(23)) at (prev + 1, 13) to (start + 0, 19)
- Code(Expression(21, Sub)) at (prev + 2, 13) to (start + 0, 19)
    = (((c20 - Zero) + c21) - c23)
- Code(Expression(28, Sub)) at (prev + 4, 5) to (start + 2, 19)
    = (((c20 - Zero) + c21) - c24)
- Code(Counter(25)) at (prev + 3, 13) to (start + 0, 19)
- Code(Expression(27, Sub)) at (prev + 2, 13) to (start + 0, 19)
    = ((((c20 - Zero) + c21) - c24) - c25)
- Code(Expression(46, Add)) at (prev + 3, 5) to (start + 0, 15)
    = (c29 + ((c26 - c27) - Zero))
- Code(Counter(26)) at (prev + 1, 12) to (start + 0, 19)
- Code(Counter(27)) at (prev + 1, 13) to (start + 3, 14)
- Code(Counter(29)) at (prev + 4, 13) to (start + 0, 19)
- Code(Expression(48, Sub)) at (prev + 2, 13) to (start + 0, 23)
    = (c26 - c27)
- Code(Expression(48, Sub)) at (prev + 1, 20) to (start + 0, 27)
    = (c26 - c27)
- Code(Zero) at (prev + 1, 21) to (start + 0, 27)
- Code(Expression(36, Sub)) at (prev + 2, 21) to (start + 0, 27)
    = ((c26 - c27) - Zero)
- Code(Expression(47, Sub)) at (prev + 4, 13) to (start + 0, 19)
    = ((c26 - c27) - Zero)
- Code(Counter(31)) at (prev + 3, 9) to (start + 0, 25)
- Code(Expression(45, Sub)) at (prev + 2, 5) to (start + 0, 15)
    = ((c29 + ((c26 - c27) - Zero)) - c31)
- Code(Expression(44, Sub)) at (prev + 3, 9) to (start + 0, 34)
    = (((c29 + ((c26 - c27) - Zero)) - c31) - Zero)
- Code(Zero) at (prev + 2, 5) to (start + 0, 15)
- Code(Zero) at (prev + 3, 9) to (start + 0, 44)
- Code(Zero) at (prev + 2, 1) to (start + 0, 2)
stderr: none


---- [coverage-map] tests/coverage/try_error_result.rs stdout ----
---- [coverage-map] tests/coverage/try_error_result.rs stdout ----
diff of cov-map:

81     = (((c4 + Zero) + Zero) + c3)
83 Function name: try_error_result::test2
83 Function name: try_error_result::test2
- Raw bytes (358): 0x[01, 01, 3b, 01, 07, 05, 09, 03, 0d, 41, 11, 4a, 15, 41, 11, 42, 1d, 46, 19, 4a, 15, 41, 11, 4a, 15, 41, 11, 46, 19, 4a, 15, 41, 11, 42, 1d, 46, 19, 4a, 15, 41, 11, 5e, 25, 49, 21, 49, 21, 5e, 25, 49, 21, 8a, 01, 2d, 8e, 01, 29, 92, 01, 41, 03, 0d, 92, 01, 41, 03, 0d, 8e, 01, 29, 92, 01, 41, 03, 0d, 8a, 01, 2d, 8e, 01, 29, 92, 01, 41, 03, 0d, a6, 01, 35, 45, 31, 45, 31, a6, 01, 35, 45, 31, ba, 01, 3d, 4d, 39, 4d, 39, ba, 01, 3d, 4d, 39, c3, 01, 0d, c7, 01, db, 01, cb, 01, cf, 01, 11, 15, d3, 01, d7, 01, 19, 1d, 21, 25, df, 01, e3, 01, 29, 2d, e7, 01, eb, 01, 31, 35, 39, 3d, 28, 01, 3d, 01, 03, 17, 03, 08, 09, 00, 0e, 92, 01, 02, 09, 04, 1a, 41, 06, 0d, 00, 2f, 11, 00, 2f, 00, 30, 4a, 00, 31, 03, 35, 15, 04, 11, 00, 12, 46, 02, 11, 04, 12, 3e, 05, 11, 00, 14, 46, 00, 17, 00, 41, 19, 00, 41, 00, 42, 42, 00, 43, 00, 5f, 1d, 00, 5f, 00, 60, 3e, 01, 0d, 00, 20, 5a, 01, 11, 00, 14, 49, 00, 17, 00, 41, 21, 00, 41, 00, 42, 5e, 00, 43, 00, 60, 25, 00, 60, 00, 61, 5a, 01, 0d, 00, 20, 86, 01, 04, 11, 00, 14, 8e, 01, 00, 17, 00, 42, 29, 00, 42, 00, 43, 8a, 01, 00, 44, 00, 61, 2d, 00, 61, 00, 62, 86, 01, 01, 0d, 00, 20, a2, 01, 01, 11, 00, 14, 45, 00, 17, 01, 36, 31, 01, 36, 00, 37, a6, 01, 01, 12, 00, 2f, 35, 00, 2f, 00, 30, a2, 01, 01, 0d, 00, 20, b6, 01, 01, 11, 00, 14, 4d, 00, 17, 01, 36, 39, 02, 11, 00, 12, ba, 01, 01, 12, 00, 2f, 3d, 01, 11, 00, 12, b6, 01, 02, 0d, 00, 20, 0d, 03, 05, 00, 0b, bf, 01, 01, 01, 00, 02]
+ Raw bytes (310): 0x[01, 01, 2d, 01, 07, 00, 09, 03, 0d, 41, 11, 2a, 15, 41, 11, 2a, 15, 41, 11, 26, 19, 2a, 15, 41, 11, 56, 00, 5a, 29, 5e, 41, 03, 0d, 5e, 41, 03, 0d, 5a, 29, 5e, 41, 03, 0d, 56, 00, 5a, 29, 5e, 41, 03, 0d, 72, 35, 45, 31, 45, 31, 72, 35, 45, 31, 86, 01, 3d, 4d, 39, 4d, 39, 86, 01, 3d, 4d, 39, 8f, 01, 0d, 93, 01, a3, 01, 97, 01, 9b, 01, 11, 15, 9f, 01, 00, 19, 1d, a7, 01, ab, 01, 29, 00, af, 01, b3, 01, 31, 35, 39, 3d, 28, 01, 3d, 01, 03, 17, 03, 08, 09, 00, 0e, 5e, 02, 09, 04, 1a, 41, 06, 0d, 00, 2f, 11, 00, 2f, 00, 30, 2a, 00, 31, 03, 35, 15, 04, 11, 00, 12, 26, 02, 11, 04, 12, 00, 05, 11, 00, 14, 26, 00, 17, 00, 41, 19, 00, 41, 00, 42, 22, 00, 43, 00, 5f, 1d, 00, 5f, 00, 60, 00, 01, 0d, 00, 20, 00, 01, 11, 00, 14, 00, 00, 17, 00, 41, 00, 00, 41, 00, 42, 00, 00, 43, 00, 60, 00, 00, 60, 00, 61, 00, 01, 0d, 00, 20, 52, 04, 11, 00, 14, 5a, 00, 17, 00, 42, 29, 00, 42, 00, 43, 56, 00, 44, 00, 61, 00, 00, 61, 00, 62, 52, 01, 0d, 00, 20, 6e, 01, 11, 00, 14, 45, 00, 17, 01, 36, 31, 01, 36, 00, 37, 72, 01, 12, 00, 2f, 35, 00, 2f, 00, 30, 6e, 01, 0d, 00, 20, 82, 01, 01, 11, 00, 14, 4d, 00, 17, 01, 36, 39, 02, 11, 00, 12, 86, 01, 01, 12, 00, 2f, 3d, 01, 11, 00, 12, 82, 01, 02, 0d, 00, 20, 0d, 03, 05, 00, 0b, 8b, 01, 01, 01, 00, 02]
86 - file 0 => global file 1
- Number of expressions: 59
+ Number of expressions: 45
+ Number of expressions: 45
88 - expression 0 operands: lhs = Counter(0), rhs = Expression(1, Add)
- - expression 1 operands: lhs = Counter(1), rhs = Counter(2)
+ - expression 1 operands: lhs = Zero, rhs = Counter(2)
90 - expression 2 operands: lhs = Expression(0, Add), rhs = Counter(3)
91 - expression 3 operands: lhs = Counter(16), rhs = Counter(4)
- - expression 4 operands: lhs = Expression(18, Sub), rhs = Counter(5)
+ - expression 4 operands: lhs = Expression(10, Sub), rhs = Counter(5)
93 - expression 5 operands: lhs = Counter(16), rhs = Counter(4)
- - expression 6 operands: lhs = Expression(16, Sub), rhs = Counter(7)
- - expression 7 operands: lhs = Expression(17, Sub), rhs = Counter(6)
- - expression 8 operands: lhs = Expression(18, Sub), rhs = Counter(5)
- - expression 9 operands: lhs = Counter(16), rhs = Counter(4)
- - expression 10 operands: lhs = Expression(18, Sub), rhs = Counter(5)
- - expression 11 operands: lhs = Counter(16), rhs = Counter(4)
- - expression 12 operands: lhs = Expression(17, Sub), rhs = Counter(6)
- - expression 13 operands: lhs = Expression(18, Sub), rhs = Counter(5)
- - expression 14 operands: lhs = Counter(16), rhs = Counter(4)
- - expression 15 operands: lhs = Expression(16, Sub), rhs = Counter(7)
- - expression 16 operands: lhs = Expression(17, Sub), rhs = Counter(6)
- - expression 17 operands: lhs = Expression(18, Sub), rhs = Counter(5)
- - expression 18 operands: lhs = Counter(16), rhs = Counter(4)
- - expression 19 operands: lhs = Expression(23, Sub), rhs = Counter(9)
- - expression 20 operands: lhs = Counter(18), rhs = Counter(8)
- - expression 21 operands: lhs = Counter(18), rhs = Counter(8)
- - expression 22 operands: lhs = Expression(23, Sub), rhs = Counter(9)
- - expression 23 operands: lhs = Counter(18), rhs = Counter(8)
- - expression 24 operands: lhs = Expression(34, Sub), rhs = Counter(11)
- - expression 25 operands: lhs = Expression(35, Sub), rhs = Counter(10)
- - expression 26 operands: lhs = Expression(36, Sub), rhs = Counter(16)
- - expression 27 operands: lhs = Expression(0, Add), rhs = Counter(3)
- - expression 28 operands: lhs = Expression(36, Sub), rhs = Counter(16)
- - expression 29 operands: lhs = Expression(0, Add), rhs = Counter(3)
- - expression 30 operands: lhs = Expression(35, Sub), rhs = Counter(10)
- - expression 31 operands: lhs = Expression(36, Sub), rhs = Counter(16)
- - expression 32 operands: lhs = Expression(0, Add), rhs = Counter(3)
- - expression 33 operands: lhs = Expression(34, Sub), rhs = Counter(11)
- - expression 34 operands: lhs = Expression(35, Sub), rhs = Counter(10)
- - expression 35 operands: lhs = Expression(36, Sub), rhs = Counter(16)
- - expression 36 operands: lhs = Expression(0, Add), rhs = Counter(3)
- - expression 37 operands: lhs = Expression(41, Sub), rhs = Counter(13)
- - expression 38 operands: lhs = Counter(17), rhs = Counter(12)
- - expression 39 operands: lhs = Counter(17), rhs = Counter(12)
- - expression 40 operands: lhs = Expression(41, Sub), rhs = Counter(13)
- - expression 41 operands: lhs = Counter(17), rhs = Counter(12)
- - expression 42 operands: lhs = Expression(46, Sub), rhs = Counter(15)
- - expression 43 operands: lhs = Counter(19), rhs = Counter(14)
- - expression 44 operands: lhs = Counter(19), rhs = Counter(14)
- - expression 45 operands: lhs = Expression(46, Sub), rhs = Counter(15)
- - expression 46 operands: lhs = Counter(19), rhs = Counter(14)
- - expression 47 operands: lhs = Expression(48, Add), rhs = Counter(3)
- - expression 48 operands: lhs = Expression(49, Add), rhs = Expression(54, Add)
- - expression 49 operands: lhs = Expression(50, Add), rhs = Expression(51, Add)
- - expression 50 operands: lhs = Counter(4), rhs = Counter(5)
- - expression 51 operands: lhs = Expression(52, Add), rhs = Expression(53, Add)
- - expression 52 operands: lhs = Counter(6), rhs = Counter(7)
- - expression 53 operands: lhs = Counter(8), rhs = Counter(9)
- - expression 54 operands: lhs = Expression(55, Add), rhs = Expression(56, Add)
- - expression 55 operands: lhs = Counter(10), rhs = Counter(11)
- - expression 56 operands: lhs = Expression(57, Add), rhs = Expression(58, Add)
- - expression 57 operands: lhs = Counter(12), rhs = Counter(13)
- - expression 58 operands: lhs = Counter(14), rhs = Counter(15)
+ - expression 6 operands: lhs = Expression(10, Sub), rhs = Counter(5)
+ - expression 7 operands: lhs = Counter(16), rhs = Counter(4)
+ - expression 8 operands: lhs = Expression(9, Sub), rhs = Counter(6)
+ - expression 9 operands: lhs = Expression(10, Sub), rhs = Counter(5)
+ - expression 10 operands: lhs = Counter(16), rhs = Counter(4)
+ - expression 11 operands: lhs = Expression(21, Sub), rhs = Zero
+ - expression 12 operands: lhs = Expression(22, Sub), rhs = Counter(10)
+ - expression 13 operands: lhs = Expression(23, Sub), rhs = Counter(16)
+ - expression 14 operands: lhs = Expression(0, Add), rhs = Counter(3)
+ - expression 15 operands: lhs = Expression(23, Sub), rhs = Counter(16)
+ - expression 16 operands: lhs = Expression(0, Add), rhs = Counter(3)
+ - expression 17 operands: lhs = Expression(22, Sub), rhs = Counter(10)
+ - expression 18 operands: lhs = Expression(23, Sub), rhs = Counter(16)
+ - expression 19 operands: lhs = Expression(0, Add), rhs = Counter(3)
+ - expression 20 operands: lhs = Expression(21, Sub), rhs = Zero
+ - expression 21 operands: lhs = Expression(22, Sub), rhs = Counter(10)
+ - expression 22 operands: lhs = Expression(23, Sub), rhs = Counter(16)
+ - expression 23 operands: lhs = Expression(0, Add), rhs = Counter(3)
+ - expression 24 operands: lhs = Expression(28, Sub), rhs = Counter(13)
+ - expression 25 operands: lhs = Counter(17), rhs = Counter(12)
+ - expression 26 operands: lhs = Counter(17), rhs = Counter(12)
+ - expression 27 operands: lhs = Expression(28, Sub), rhs = Counter(13)
+ - expression 28 operands: lhs = Counter(17), rhs = Counter(12)
+ - expression 29 operands: lhs = Expression(33, Sub), rhs = Counter(15)
+ - expression 30 operands: lhs = Counter(19), rhs = Counter(14)
+ - expression 31 operands: lhs = Counter(19), rhs = Counter(14)
+ - expression 32 operands: lhs = Expression(33, Sub), rhs = Counter(15)
+ - expression 33 operands: lhs = Counter(19), rhs = Counter(14)
+ - expression 34 operands: lhs = Expression(35, Add), rhs = Counter(3)
+ - expression 35 operands: lhs = Expression(36, Add), rhs = Expression(40, Add)

@bors
Copy link
Contributor

bors commented Sep 7, 2024

☀️ Try build successful - checks-actions
Build commit: 182dada (182dada668a27730142b220c3841f69cd4e880ca)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (182dada): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.0% [0.3%, 4.7%] 202
Regressions ❌
(secondary)		 1.3% [0.1%, 20.2%] 132
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.2% [-2.2%, -0.3%] 11
All ❌✅ (primary) 1.0% [0.3%, 4.7%] 202

Max RSS (memory usage)

Results (primary -0.8%, secondary -1.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.7% [1.1%, 4.3%] 15
Regressions ❌
(secondary)		 2.6% [1.9%, 3.3%] 3
Improvements ✅
(primary)		 -4.6% [-8.3%, -1.4%] 14
Improvements ✅
(secondary)		 -4.4% [-6.9%, -2.4%] 4
All ❌✅ (primary) -0.8% [-8.3%, 4.3%] 29

Cycles

Results (primary 2.7%, secondary 4.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.7% [1.0%, 10.2%] 58
Regressions ❌
(secondary)		 4.4% [2.0%, 18.7%] 25
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) 2.7% [1.0%, 10.2%] 58

Binary size

Results (primary -0.0%, secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.2% [0.0%, 0.8%] 29
Regressions ❌
(secondary)		 0.9% [0.2%, 2.5%] 9
Improvements ✅
(primary)		 -0.2% [-0.5%, -0.0%] 36
Improvements ✅
(secondary)		 -0.4% [-0.6%, -0.1%] 43
All ❌✅ (primary) -0.0% [-0.5%, 0.8%] 65

Bootstrap: 756.798s -> 771.578s (1.95%)
Artifact size: 341.03 MiB -> 341.18 MiB (0.04%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjgillot @rustbot @rust-timer @bors @rust-log-analyzer @chenyukang