Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call fn_arg_names query for non-fn foreign items in resolver #130033

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't call fn_arg_names query for non-fn foreign items in resolver #130033

wants to merge 1 commit into from
+53 −24

Conversation

compiler-errors
Copy link
Member

Fixes #130015

@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2024

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 6, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
fmease
fmease reviewed Sep 7, 2024
View reviewed changes
tests/ui/resolve/dont-compute-arg-names-for-non-fn.stderr
|
help: you might have meant to use the associated type
|
LL | impl Foo for Self::Bar {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol that is incorrect

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but in the resolver we don't really have the right context to avoid this suggestion anyways.

@compiler-errors compiler-errors mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease left review comments

Assignees

@BoxyUwU BoxyUwU

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: does not have a "fn_arg_names"'
5 participants
@compiler-errors @rustbot @rust-log-analyzer @fmease @BoxyUwU