detect incompatible CI LLVM options more precisely #129788
Merged
+147
−34
Commits on Sep 8, 2024
-
detect incompatible CI LLVM options more precisely
Previously, the logic here was simply checking whether the option was set in `config.toml`. This approach was not manageable in our CI runners as we set so many options in config.toml. In reality, those values are not incompatible since they are usually the same value used to generate the CI llvm. Now, the new logic compares the configuration values with the values used to generate the CI llvm, so we get more precise results and make the process more manageable. Signed-off-by: onur-ozkan <work@onurozkan.dev>
-
Signed-off-by: onur-ozkan <work@onurozkan.dev>
-
print incompatible options even if we don't download
Signed-off-by: onur-ozkan <work@onurozkan.dev>
-
Signed-off-by: onur-ozkan <work@onurozkan.dev>
-
use
Config::get_builder_tomlfor ci-rustc config parsingSigned-off-by: onur-ozkan <work@onurozkan.dev>
-
handle dry-run mode in
Config::get_builder_tomlSigned-off-by: onur-ozkan <work@onurozkan.dev>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.