Subpart9 for async drop (major3) - elaborate_drops changes #129745
+1,731
−2,023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This was referenced Aug 29, 2024
azhogin
force-pushed
the
azhogin/async-drop-subpart9-elaborate-drops
branch
from
298c6ec to
06acd8c
Compare
…p from previous async drop glue implementation
azhogin
force-pushed
the
azhogin/async-drop-subpart9-elaborate-drops
branch
from
06acd8c to
04ef2a5
Compare
azhogin
force-pushed
the
azhogin/async-drop-subpart9-elaborate-drops
branch
from
04ef2a5 to
28c0f53
Compare
|
☔ The latest upstream changes (presumably #130165) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @nikomatsakis is going to look into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is subpart 9 PR of #123948, just for review purposes.
Changes in drop elaboration to support async drops.
Drop elaboration is used to generate sync drop glue with drops of all internals included.
Async drop poll function is generated now using a similar way - first splitting dropee type using drop elaboration, and then StateTransform'ing it into coroutine poll function (StateTransform changes and shim generation in latter commits).
Review only last commit, based on previous PR #129744.